March 2017 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: util/intelmetool: Fix access to deleted data on stack
by Philipp Deppenwiese (Code Review) March 31, 2017

March 31, 2017

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19066 ) Change subject: util/intelmetool: Fix access to deleted data on stack ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19066 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I947a4c794ee37fe87e035593eaabcaf963b9875e Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/intelmetool: Fix access to deleted data on stack
by build bot (Jenkins) (Code Review) March 31, 2017

March 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19066 ) Change subject: util/intelmetool: Fix access to deleted data on stack ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/6988/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/51021/ : SUCCESS -- To view, visit https://review.coreboot.org/19066 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I947a4c794ee37fe87e035593eaabcaf963b9875e Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: allow lpss i2c time-based data hold time
by Furquan Shaikh (Code Review) March 31, 2017

March 31, 2017

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19064 ) Change subject: soc/intel/common: allow lpss i2c time-based data hold time ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19064 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86de095186ee396099709cc8a97240bd2f9722c9 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/intelmetool: Fix access to deleted data on stack
by Youness Alaoui (Code Review) March 31, 2017

March 31, 2017

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19066 ) Change subject: util/intelmetool: Fix access to deleted data on stack ...................................................................... Patch Set 1: Note: This could have been fixed also by making 'namebuf' into a static variable, but I didn't think it was an elegant solution, so I modified it this way. the pci_me_interface_scan is a static function and not called anywhere else, so it seemed a good chance. Also, I declared 'char namebuf[1024], *name;' on a single line because that's how it's declared in pci_platform_scan function, if it doesn't match the coding convention, I can change it. -- To view, visit https://review.coreboot.org/19066 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I947a4c794ee37fe87e035593eaabcaf963b9875e Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/intelmetool: Fix access to deleted data on stack
by Youness Alaoui (Code Review) March 31, 2017

March 31, 2017

Youness Alaoui has uploaded a new change for review. ( https://review.coreboot.org/19066 ) Change subject: util/intelmetool: Fix access to deleted data on stack ...................................................................... util/intelmetool: Fix access to deleted data on stack pci_me_interface_scan was returning (via argument 'name') a pointer to the interface name which was stored in a stack variable. This caused part of the name to be printed as garbage stack data in some situations if stack data was overwritten. This moves the name buffer to the calling function so it can be accessed before it gets overwritten. Change-Id: I947a4c794ee37fe87e035593eaabcaf963b9875e Signed-off-by: Youness Alaoui <youness.alaoui(a)puri.sm> --- M util/intelmetool/intelmetool.c 1 file changed, 4 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/19066/1 diff --git a/util/intelmetool/intelmetool.c b/util/intelmetool/intelmetool.c index 45e8c8f..498bf41 100644 --- a/util/intelmetool/intelmetool.c +++ b/util/intelmetool/intelmetool.c @@ -152,10 +152,9 @@ return 0; } -static struct pci_dev *pci_me_interface_scan(char **name) { +static struct pci_dev *pci_me_interface_scan(char **name, char *namebuf, int namebuf_size) { struct pci_access *pacc; struct pci_dev *dev; - char namebuf[1024]; int me = 0; pacc = pci_alloc(); @@ -166,7 +165,7 @@ for (dev=pacc->devices; dev; dev=dev->next) { pci_fill_info(dev, PCI_FILL_IDENT | PCI_FILL_BASES | PCI_FILL_SIZES | PCI_FILL_CLASS); - *name = pci_lookup_name(pacc, namebuf, sizeof(namebuf), + *name = pci_lookup_name(pacc, namebuf, namebuf_size, PCI_LOOKUP_DEVICE, dev->vendor_id, dev->device_id); if (dev->vendor_id == 0x8086) { if (PCI_DEV_HAS_SUPPORTED_ME(dev->device_id)) { @@ -226,7 +225,7 @@ static void dump_me_info() { struct pci_dev *dev; uint32_t stat, stat2; - char *name; + char namebuf[1024], *name; if (pci_platform_scan()) { exit(1); @@ -236,7 +235,7 @@ exit(1); } - dev = pci_me_interface_scan(&name); + dev = pci_me_interface_scan(&name, namebuf, sizeof(namebuf)); if (!dev) { exit(1); } -- To view, visit https://review.coreboot.org/19066 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I947a4c794ee37fe87e035593eaabcaf963b9875e Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com>

1 0

Change in coreboot[master]: amd/pi: Add AMD fam16h TPM ACPI path support
by build bot (Jenkins) (Code Review) March 31, 2017

March 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18522 ) Change subject: amd/pi: Add AMD fam16h TPM ACPI path support ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/6986/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/51019/ : SUCCESS -- To view, visit https://review.coreboot.org/18522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5322d731a0dc655f2da14b87fa6cbc1e54b5abd5 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/pcengines/apu2: Add LPC TPM support
by build bot (Jenkins) (Code Review) March 31, 2017

March 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18523 ) Change subject: mainboard/pcengines/apu2: Add LPC TPM support ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/6987/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/51020/ : SUCCESS -- To view, visit https://review.coreboot.org/18523 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9312370a5071ffbeb6d83888c75fa69a0c27819 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/reef: increase trackpad data hold time
by build bot (Jenkins) (Code Review) March 31, 2017

March 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19065 ) Change subject: mainboard/google/reef: increase trackpad data hold time ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/6984/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/51016/ : SUCCESS -- To view, visit https://review.coreboot.org/19065 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b70f2f53c5a29cc7cfd5035a71ca5811b3bcba0 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/pcengines/apu2: Add LPC TPM support
by build bot (Jenkins) (Code Review) March 31, 2017

March 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18523 ) Change subject: mainboard/pcengines/apu2: Add LPC TPM support ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/51018/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/6985/ : SUCCESS -- To view, visit https://review.coreboot.org/18523 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9312370a5071ffbeb6d83888c75fa69a0c27819 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/pi: Add AMD fam16h TPM ACPI path support
by Philipp Deppenwiese (Code Review) March 31, 2017

March 31, 2017

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/18522 to look at the new patch set (#3). Change subject: amd/pi: Add AMD fam16h TPM ACPI path support ...................................................................... amd/pi: Add AMD fam16h TPM ACPI path support Change-Id: I5322d731a0dc655f2da14b87fa6cbc1e54b5abd5 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/northbridge/amd/pi/00730F01/northbridge.c M src/southbridge/amd/pi/hudson/lpc.c M src/southbridge/amd/pi/hudson/pci_devs.h 3 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/18522/3 -- To view, visit https://review.coreboot.org/18522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5322d731a0dc655f2da14b87fa6cbc1e54b5abd5 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins)

1 0