coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: soc/intel/cannonlake: Add support for D0 stepping
by Lijian Zhao (Code Review) 01 Dec '17

01 Dec '17

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/22676 Change subject: soc/intel/cannonlake: Add support for D0 stepping ...................................................................... soc/intel/cannonlake: Add support for D0 stepping D0 stepping with CPUID 0x60663 need to be added in coreboot. TEST=Boot up with D0 stepping processor Change-Id: I3b0f2616843367d2bfbee1b5bf75772b9e83e931 Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/soc/intel/cannonlake/include/soc/cpu.h M src/soc/intel/common/block/include/intelblocks/mp_init.h 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/22676/1 diff --git a/src/soc/intel/cannonlake/include/soc/cpu.h b/src/soc/intel/cannonlake/include/soc/cpu.h index bd9db37..e50801f 100644 --- a/src/soc/intel/cannonlake/include/soc/cpu.h +++ b/src/soc/intel/cannonlake/include/soc/cpu.h @@ -25,6 +25,7 @@ #define CPUID_CANNONLAKE_A0 0x60660 #define CPUID_CANNONLAKE_B0 0x60661 #define CPUID_CANNONLAKE_C0 0x60662 +#define CPUID_CANNONLAKE_D0 0x60663 /* Latency times in units of 1024ns. */ #define C_STATE_LATENCY_CONTROL_0_LIMIT 0x4e diff --git a/src/soc/intel/common/block/include/intelblocks/mp_init.h b/src/soc/intel/common/block/include/intelblocks/mp_init.h index ab3e1ed..3057209 100644 --- a/src/soc/intel/common/block/include/intelblocks/mp_init.h +++ b/src/soc/intel/common/block/include/intelblocks/mp_init.h @@ -31,6 +31,7 @@ #define CPUID_CANNONLAKE_A0 0x60660 #define CPUID_CANNONLAKE_B0 0x60661 #define CPUID_CANNONLAKE_C0 0x60662 +#define CPUID_CANNONLAKE_D0 0x60663 #define CPUID_APOLLOLAKE_A0 0x506c8 #define CPUID_APOLLOLAKE_B0 0x506c9 #define CPUID_APOLLOLAKE_E0 0x506ca -- To view, visit https://review.coreboot.org/22676 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3b0f2616843367d2bfbee1b5bf75772b9e83e931 Gerrit-Change-Number: 22676 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com>

1 0

Change in coreboot[master]: mainboard/intel/glkrvp: Ignore Audio DMIC IOSSTATE
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22675 ) Change subject: mainboard/intel/glkrvp: Ignore Audio DMIC IOSSTATE ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64002/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18852/ : SUCCESS -- To view, visit https://review.coreboot.org/22675 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I147cf3c12acb11429c6cb234e8c511f57886b6b4 Gerrit-Change-Number: 22675 Gerrit-PatchSet: 1 Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 20:28:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/intel/glkrvp: Ignore Audio DMIC IOSSTATE
by Sathyanarayana Nujella (Code Review) 01 Dec '17

01 Dec '17

Hello Hannah Williams, I'd like you to do a code review. Please visit https://review.coreboot.org/22675 to review the following change. Change subject: mainboard/intel/glkrvp: Ignore Audio DMIC IOSSTATE ...................................................................... mainboard/intel/glkrvp: Ignore Audio DMIC IOSSTATE Audio DMIC_CLK needs to be ON in S0ix to support Wake on Voice. So, configuring GPIO_171 to be as IGNORE IOSSTATE, so that clock is ON in S0ix state. BUG=None TEST=put DUT in S0ix, verified DMIC_CLK in scope when wov capture path is ON Change-Id: I147cf3c12acb11429c6cb234e8c511f57886b6b4 Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- M src/mainboard/intel/glkrvp/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/22675/1 diff --git a/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c b/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c index f6437a2..0361ec7 100644 --- a/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c +++ b/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c @@ -204,7 +204,7 @@ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_168, DN_20K, DEEP, NF2, HIZCRx1, SAME),/* AVS_I2S2_SDI*/ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_169, DN_20K, DEEP, NF2, HIZCRx1, SAME),/*AVS_I2S2_SD0*/ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_170, DN_20K, DEEP, NF2, HIZCRx1, SAME),/*AVS_I2S1_MCLK*/ - PAD_CFG_NF_IOSSTATE(GPIO_171, DN_20K, DEEP, NF1, HIZCRx1),/*AVS_M_CLK_A1*/ + PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_171, DN_20K, DEEP, NF1),/*AVS_M_CLK_A1*/ PAD_CFG_NF_IOSSTATE(GPIO_172, DN_20K, DEEP, NF1, HIZCRx1),/*AVS_M_CLK_B1*/ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_173, DN_20K, DEEP, NF1, HIZCRx1, ENPD),/*AVS_M_DATA_1*/ PAD_CFG_NF_IOSSTATE(GPIO_174, DN_20K, DEEP, NF1, HIZCRx1),/*AVS_M_CLK_AB2*/ -- To view, visit https://review.coreboot.org/22675 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I147cf3c12acb11429c6cb234e8c511f57886b6b4 Gerrit-Change-Number: 22675 Gerrit-PatchSet: 1 Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Fix guarded code in ACPI ASL
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22634 ) Change subject: soc/amd/stoneyridge: Fix guarded code in ACPI ASL ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64001/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18851/ : SUCCESS -- To view, visit https://review.coreboot.org/22634 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71c6acb235df9aa8642dca4c85d2bf604e244bf4 Gerrit-Change-Number: 22634 Gerrit-PatchSet: 6 Gerrit-Owner: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 19:53:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake/acpi/pch_hda: Add _PRW for HD-A
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22637 ) Change subject: soc/intel/apollolake/acpi/pch_hda: Add _PRW for HD-A ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64000/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18850/ : SUCCESS -- To view, visit https://review.coreboot.org/22637 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ad289be8c58e48ad0ec9d2ee0894fe16b8f2e1c Gerrit-Change-Number: 22637 Gerrit-PatchSet: 5 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 18:47:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: acpi/pch_hda: Add _PRW for HD-A
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22637 ) Change subject: acpi/pch_hda: Add _PRW for HD-A ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63999/ : SUCCESS -- To view, visit https://review.coreboot.org/22637 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ad289be8c58e48ad0ec9d2ee0894fe16b8f2e1c Gerrit-Change-Number: 22637 Gerrit-PatchSet: 4 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 18:40:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add RunOnAP support
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22194 ) Change subject: soc/amd/stoneyridge: Add RunOnAP support ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63998/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18849/ : SUCCESS -- To view, visit https://review.coreboot.org/22194 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30cb2e0c6cc474158f3a7710dbb8ecf54f1ffe4 Gerrit-Change-Number: 22194 Gerrit-PatchSet: 6 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 18:20:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake/acpi/pch_hda: Add _PRW for HD-A
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22637 ) Change subject: soc/intel/apollolake/acpi/pch_hda: Add _PRW for HD-A ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63997/ : SUCCESS -- To view, visit https://review.coreboot.org/22637 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ad289be8c58e48ad0ec9d2ee0894fe16b8f2e1c Gerrit-Change-Number: 22637 Gerrit-PatchSet: 3 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 18:02:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake/acpi/cnvi.asl: Add _PRW for CNVi
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22639 ) Change subject: soc/intel/apollolake/acpi/cnvi.asl: Add _PRW for CNVi ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63995/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18848/ : SUCCESS -- To view, visit https://review.coreboot.org/22639 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I682c76b9c5c524face7b540ecb185a3d7b4b2da3 Gerrit-Change-Number: 22639 Gerrit-PatchSet: 2 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 17:57:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake/acpi/pch_hda: Add _PRW for HD-A
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22637 ) Change subject: soc/intel/apollolake/acpi/pch_hda: Add _PRW for HD-A ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63996/ : ABORTED -- To view, visit https://review.coreboot.org/22637 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ad289be8c58e48ad0ec9d2ee0894fe16b8f2e1c Gerrit-Change-Number: 22637 Gerrit-PatchSet: 2 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 17:56:19 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017