coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: google/reef: add more USB tuning for coral variants
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22661 ) Change subject: google/reef: add more USB tuning for coral variants ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63983/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18838/ : SUCCESS -- To view, visit https://review.coreboot.org/22661 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7416ec8d058271700ebe43f8d92af61c6c0d6b42 Gerrit-Change-Number: 22661 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 08:39:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/reef: Fix whitespace inconsistency in coral code
by Patrick Georgi (Code Review) 01 Dec '17

01 Dec '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/22662 Change subject: google/reef: Fix whitespace inconsistency in coral code ...................................................................... google/reef: Fix whitespace inconsistency in coral code BUG=none BRANCH=none TEST=none Change-Id: I4e61f1327027c5100773e2b837f439a939807e72 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/mainboard/google/reef/variants/coral/mainboard.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/22662/1 diff --git a/src/mainboard/google/reef/variants/coral/mainboard.c b/src/mainboard/google/reef/variants/coral/mainboard.c index 503b01e..5daf96c 100644 --- a/src/mainboard/google/reef/variants/coral/mainboard.c +++ b/src/mainboard/google/reef/variants/coral/mainboard.c @@ -21,16 +21,16 @@ #include <soc/intel/common/vbt.h> enum { - SKU_0_ASTRONAUT = 0, - SKU_1_ASTRONAUT = 1, + SKU_0_ASTRONAUT = 0, + SKU_1_ASTRONAUT = 1, SKU_2_SANTA = 2, SKU_3_SANTA = 3, SKU_4_LAVA = 4, SKU_5_LAVA = 5, SKU_9_LAVA = 9, SKU_10_LAVA = 10, - SKU_61_ASTRONAUT = 61, - SKU_62_ASTRONAUT = 62, + SKU_61_ASTRONAUT = 61, + SKU_62_ASTRONAUT = 62, SKU_160_NASHER = 160, SKU_161_NASHER = 161, SKU_162_NASHER = 162, -- To view, visit https://review.coreboot.org/22662 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4e61f1327027c5100773e2b837f439a939807e72 Gerrit-Change-Number: 22662 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: google/reef: add more USB tuning for coral variants
by Patrick Georgi (Code Review) 01 Dec '17

01 Dec '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/22661 Change subject: google/reef: add more USB tuning for coral variants ...................................................................... google/reef: add more USB tuning for coral variants Lava numbers are in. BUG=b:69990330 BRANCH=none TEST=verified that USB signal is within spec Change-Id: I7416ec8d058271700ebe43f8d92af61c6c0d6b42 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/mainboard/google/reef/variants/coral/mainboard.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/22661/1 diff --git a/src/mainboard/google/reef/variants/coral/mainboard.c b/src/mainboard/google/reef/variants/coral/mainboard.c index 5e61a3a..503b01e 100644 --- a/src/mainboard/google/reef/variants/coral/mainboard.c +++ b/src/mainboard/google/reef/variants/coral/mainboard.c @@ -25,6 +25,10 @@ SKU_1_ASTRONAUT = 1, SKU_2_SANTA = 2, SKU_3_SANTA = 3, + SKU_4_LAVA = 4, + SKU_5_LAVA = 5, + SKU_9_LAVA = 9, + SKU_10_LAVA = 10, SKU_61_ASTRONAUT = 61, SKU_62_ASTRONAUT = 62, SKU_160_NASHER = 160, @@ -74,6 +78,13 @@ cfg->usb2eye[1].Usb20PerPortPeTxiSet = 7; cfg->usb2eye[1].Usb20PerPortTxiSet = 2; break; + case SKU_4_LAVA: + case SKU_5_LAVA: + case SKU_9_LAVA: + case SKU_10_LAVA: + cfg->usb2eye[1].Usb20PerPortPeTxiSet = 7; + cfg->usb2eye[1].Usb20PerPortTxiSet = 2; + break; case SKU_61_ASTRONAUT: case SKU_62_ASTRONAUT: cfg->usb2eye[1].Usb20PerPortPeTxiSet = 7; -- To view, visit https://review.coreboot.org/22661 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7416ec8d058271700ebe43f8d92af61c6c0d6b42 Gerrit-Change-Number: 22661 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Add Baseboard GPIOs
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22546 ) Change subject: mainboard/google/kahlee: Add Baseboard GPIOs ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63979/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18836/ : SUCCESS -- To view, visit https://review.coreboot.org/22546 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4efcee7dbf54fb9ea82e5e9394db805bb69203c8 Gerrit-Change-Number: 22546 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 04:16:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add GPIO40 to GPIO list
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22658 ) Change subject: soc/amd/stoneyridge: Add GPIO40 to GPIO list ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63980/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18837/ : SUCCESS -- To view, visit https://review.coreboot.org/22658 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20fce60ff1a61761b907518c0a6e1685a17f2886 Gerrit-Change-Number: 22658 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 04:16:26 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Remove usb_oc.asl files
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22659 ) Change subject: mainboard/google/kahlee: Remove usb_oc.asl files ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63981/ : SUCCESS -- To view, visit https://review.coreboot.org/22659 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dcd50a249e387ccf1142949b359cee09942460a Gerrit-Change-Number: 22659 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 03:45:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Remove usb_oc.asl files
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22659 ) Change subject: mainboard/google/kahlee: Remove usb_oc.asl files ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63978/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18835/ : SUCCESS -- To view, visit https://review.coreboot.org/22659 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dcd50a249e387ccf1142949b359cee09942460a Gerrit-Change-Number: 22659 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 03:38:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Remove usb_oc.asl files
by Martin Roth (Code Review) 01 Dec '17

01 Dec '17

Martin Roth has uploaded a new patch set (#2). ( https://review.coreboot.org/22659 ) Change subject: mainboard/google/kahlee: Remove usb_oc.asl files ...................................................................... mainboard/google/kahlee: Remove usb_oc.asl files These files aren't needed for the overcurrent functionality. BUG=b:69305596, b:69229635 TEST=Build Grunt & Kahlee. Overcurrent wasn't yet enabled so no other testing was needed. Change-Id: I8dcd50a249e387ccf1142949b359cee09942460a Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/google/kahlee/dsdt.asl D src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/usb_oc.asl D src/mainboard/google/kahlee/variants/grunt/include/variant/acpi/usb_oc.asl D src/mainboard/google/kahlee/variants/kahlee/include/variant/acpi/usb_oc.asl 4 files changed, 0 insertions(+), 85 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/22659/2 -- To view, visit https://review.coreboot.org/22659 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8dcd50a249e387ccf1142949b359cee09942460a Gerrit-Change-Number: 22659 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: mainboard/googke/kahlee: Remove usb_oc.asl files
by Martin Roth (Code Review) 01 Dec '17

01 Dec '17

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/22659 Change subject: mainboard/googke/kahlee: Remove usb_oc.asl files ...................................................................... mainboard/googke/kahlee: Remove usb_oc.asl files These files aren't needed for the overcurrent functionality. BUG=b:69305596, b:69229635 TEST=Build Grunt & Kahlee. Overcurrent wasn't yet enabled so no other testing was needed. Change-Id: I8dcd50a249e387ccf1142949b359cee09942460a Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/google/kahlee/dsdt.asl D src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/usb_oc.asl D src/mainboard/google/kahlee/variants/grunt/include/variant/acpi/usb_oc.asl D src/mainboard/google/kahlee/variants/kahlee/include/variant/acpi/usb_oc.asl 4 files changed, 0 insertions(+), 85 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/22659/1 diff --git a/src/mainboard/google/kahlee/dsdt.asl b/src/mainboard/google/kahlee/dsdt.asl index ded0dc8..ff3bb73 100644 --- a/src/mainboard/google/kahlee/dsdt.asl +++ b/src/mainboard/google/kahlee/dsdt.asl @@ -33,9 +33,6 @@ /* Globals for the platform */ #include "acpi/mainboard.asl" - /* Describe the USB Overcurrent pins */ - #include "variant/acpi/usb_oc.asl" - /* PCI IRQ mapping for the Southbridge */ #include <pcie.asl> diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/usb_oc.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/usb_oc.asl deleted file mode 100644 index 72f26d8..0000000 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/usb_oc.asl +++ /dev/null @@ -1,29 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Advanced Micro Devices, Inc. - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* USB overcurrent mapping pins. */ -Name (UOM0, 0) -Name (UOM1, 0) -Name (UOM2, 0) -Name (UOM3, 0) -Name (UOM4, 0) -Name (UOM5, 0) -Name (UOM6, 0) -Name (UOM7, 0) -Name (UOM8, 0) -Name (UOM9, 0) - -/* USB Overcurrent GPEs */ diff --git a/src/mainboard/google/kahlee/variants/grunt/include/variant/acpi/usb_oc.asl b/src/mainboard/google/kahlee/variants/grunt/include/variant/acpi/usb_oc.asl deleted file mode 100644 index d22628c..0000000 --- a/src/mainboard/google/kahlee/variants/grunt/include/variant/acpi/usb_oc.asl +++ /dev/null @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright 2017 Google Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <baseboard/acpi/usb_oc.asl> diff --git a/src/mainboard/google/kahlee/variants/kahlee/include/variant/acpi/usb_oc.asl b/src/mainboard/google/kahlee/variants/kahlee/include/variant/acpi/usb_oc.asl deleted file mode 100644 index 068d6fd..0000000 --- a/src/mainboard/google/kahlee/variants/kahlee/include/variant/acpi/usb_oc.asl +++ /dev/null @@ -1,37 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Advanced Micro Devices, Inc. - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* simple name description */ -/* - * DefinitionBlock ("DSDT.AML","DSDT",0x01,"XXXXXX","XXXXXXXX",0x00010001) - * { - * #include "usb.asl" - * } - */ - -/* USB overcurrent mapping pins. */ -Name (UOM0, 0) -Name (UOM1, 2) -Name (UOM2, 0) -Name (UOM3, 7) -Name (UOM4, 2) -Name (UOM5, 2) -Name (UOM6, 6) -Name (UOM7, 2) -Name (UOM8, 6) -Name (UOM9, 6) - -/* USB Overcurrent GPEs */ -- To view, visit https://review.coreboot.org/22659 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8dcd50a249e387ccf1142949b359cee09942460a Gerrit-Change-Number: 22659 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add GPIO40 to GPIO list
by Martin Roth (Code Review) 01 Dec '17

01 Dec '17

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/22658 Change subject: soc/amd/stoneyridge: Add GPIO40 to GPIO list ...................................................................... soc/amd/stoneyridge: Add GPIO40 to GPIO list GPIO40 is a valid GPIO for the Stoney FT4 package, so add it to the list of GPIOs BUG=b:69305596 TEST=Build Kahlee & Grunt Change-Id: I20fce60ff1a61761b907518c0a6e1685a17f2886 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/soc/amd/stoneyridge/include/soc/gpio.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/22658/1 diff --git a/src/soc/amd/stoneyridge/include/soc/gpio.h b/src/soc/amd/stoneyridge/include/soc/gpio.h index 0854cf3..b3dddd4 100644 --- a/src/soc/amd/stoneyridge/include/soc/gpio.h +++ b/src/soc/amd/stoneyridge/include/soc/gpio.h @@ -61,6 +61,7 @@ #define GPIO_25 25 #define GPIO_26 26 #define GPIO_39 39 +#define GPIO_40 40 #define GPIO_42 42 /* GPIO_64 - GPIO_127 */ -- To view, visit https://review.coreboot.org/22658 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I20fce60ff1a61761b907518c0a6e1685a17f2886 Gerrit-Change-Number: 22658 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017