coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: mb/*/*/Kconfig: Remove default MMCONF_BASE_ADDRESS on Sandy Bridge
by Arthur Heymans (Code Review) 01 Dec '17

01 Dec '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/22664 ) Change subject: mb/*/*/Kconfig: Remove default MMCONF_BASE_ADDRESS on Sandy Bridge ...................................................................... Patch Set 2: > I'm wondering why they set it to f0000000 despite the `select > USE_NATIVE_RAMINIT`. afaik autoport used to do that. -- To view, visit https://review.coreboot.org/22664 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f0d6d7fefc77fb05cdb629d09de8cb72496a9cc Gerrit-Change-Number: 22664 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 11:31:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/*/*/Kconfig: Remove default MMCONF_BASE_ADDRESS on Sandy Bridge
by Nico Huber (Code Review) 01 Dec '17

01 Dec '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22664 ) Change subject: mb/*/*/Kconfig: Remove default MMCONF_BASE_ADDRESS on Sandy Bridge ...................................................................... Patch Set 2: Code-Review+2 I'm wondering why they set it to f0000000 despite the `select USE_NATIVE_RAMINIT`. -- To view, visit https://review.coreboot.org/22664 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f0d6d7fefc77fb05cdb629d09de8cb72496a9cc Gerrit-Change-Number: 22664 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 10:57:16 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/*/*/Kconfig: Remove default MMCONF_BASE_ADDRESS on Sandy Bridge
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22664 ) Change subject: mb/*/*/Kconfig: Remove default MMCONF_BASE_ADDRESS on Sandy Bridge ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63987/ : SUCCESS -- To view, visit https://review.coreboot.org/22664 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f0d6d7fefc77fb05cdb629d09de8cb72496a9cc Gerrit-Change-Number: 22664 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 10:30:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/*/*/Kconfig: Remove default MMCONF_BASE_ADDRESS on Sandy Bridge
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22664 ) Change subject: mb/*/*/Kconfig: Remove default MMCONF_BASE_ADDRESS on Sandy Bridge ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63986/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18841/ : SUCCESS -- To view, visit https://review.coreboot.org/22664 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f0d6d7fefc77fb05cdb629d09de8cb72496a9cc Gerrit-Change-Number: 22664 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 10:23:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/*/*/Kconfig: Remove default MMCONF_BASE_ADDRESS on Sandy Bridge
by Arthur Heymans (Code Review) 01 Dec '17

01 Dec '17

Hello Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/22664 to look at the new patch set (#2). Change subject: mb/*/*/Kconfig: Remove default MMCONF_BASE_ADDRESS on Sandy Bridge ...................................................................... mb/*/*/Kconfig: Remove default MMCONF_BASE_ADDRESS on Sandy Bridge Change-Id: I6f0d6d7fefc77fb05cdb629d09de8cb72496a9cc Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/compulab/intense_pc/Kconfig M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/s230u/Kconfig 3 files changed, 0 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/22664/2 -- To view, visit https://review.coreboot.org/22664 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6f0d6d7fefc77fb05cdb629d09de8cb72496a9cc Gerrit-Change-Number: 22664 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: mb/*/*: Remove setting default MMCONF_BASE_ADDRESS on Sandy Bridge
by Arthur Heymans (Code Review) 01 Dec '17

01 Dec '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/22664 Change subject: mb/*/*: Remove setting default MMCONF_BASE_ADDRESS on Sandy Bridge ...................................................................... mb/*/*: Remove setting default MMCONF_BASE_ADDRESS on Sandy Bridge Change-Id: I6f0d6d7fefc77fb05cdb629d09de8cb72496a9cc Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/compulab/intense_pc/Kconfig M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/s230u/Kconfig 3 files changed, 0 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/22664/1 diff --git a/src/mainboard/compulab/intense_pc/Kconfig b/src/mainboard/compulab/intense_pc/Kconfig index 283d63a..81085bc 100644 --- a/src/mainboard/compulab/intense_pc/Kconfig +++ b/src/mainboard/compulab/intense_pc/Kconfig @@ -47,10 +47,6 @@ hex default 0x8086 -config MMCONF_BASE_ADDRESS - hex - default 0xf0000000 - config DRAM_RESET_GATE_GPIO # FIXME: check this int default 60 diff --git a/src/mainboard/lenovo/l520/Kconfig b/src/mainboard/lenovo/l520/Kconfig index 7043184..20ed67c 100644 --- a/src/mainboard/lenovo/l520/Kconfig +++ b/src/mainboard/lenovo/l520/Kconfig @@ -50,10 +50,6 @@ hex default 0x17aa -config MMCONF_BASE_ADDRESS - hex - default 0xf0000000 - config DRAM_RESET_GATE_GPIO int default 10 diff --git a/src/mainboard/lenovo/s230u/Kconfig b/src/mainboard/lenovo/s230u/Kconfig index 4b6727ca..f724784 100644 --- a/src/mainboard/lenovo/s230u/Kconfig +++ b/src/mainboard/lenovo/s230u/Kconfig @@ -35,10 +35,6 @@ string default "ThinkPad S230U (Twist)" -config MMCONF_BASE_ADDRESS - hex - default 0xf0000000 - config EC_BASE_ADDRESS hex default 0xff000000 -- To view, visit https://review.coreboot.org/22664 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6f0d6d7fefc77fb05cdb629d09de8cb72496a9cc Gerrit-Change-Number: 22664 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: google/reef: add more USB tuning for coral variants
by Ren Kuo (Code Review) 01 Dec '17

01 Dec '17

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/22661 ) Change subject: google/reef: add more USB tuning for coral variants ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/22661 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7416ec8d058271700ebe43f8d92af61c6c0d6b42 Gerrit-Change-Number: 22661 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 10:12:21 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: update RAMID table
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22663 ) Change subject: google/gru: update RAMID table ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63985/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18840/ : SUCCESS -- To view, visit https://review.coreboot.org/22663 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44215b4a6668074575a5df691ac1ff8fa3d15492 Gerrit-Change-Number: 22663 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 08:55:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: update RAMID table
by Lin Huang (Code Review) 01 Dec '17

01 Dec '17

Lin Huang has uploaded this change for review. ( https://review.coreboot.org/22663 Change subject: google/gru: update RAMID table ...................................................................... google/gru: update RAMID table There are some confusion with old RAMID table, make it clear, and let's no longer tangle it in future. Change-Id: I44215b4a6668074575a5df691ac1ff8fa3d15492 Signed-off-by: Lin Huang <hl(a)rock-chips.com> --- M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/gru/sdram_params/sdram-lpddr3-hynix-4GB-928.c 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/22663/1 diff --git a/src/mainboard/google/gru/sdram_configs.c b/src/mainboard/google/gru/sdram_configs.c index eec8a0d..956a1c8 100644 --- a/src/mainboard/google/gru/sdram_configs.c +++ b/src/mainboard/google/gru/sdram_configs.c @@ -23,10 +23,10 @@ #include <types.h> static const char *sdram_configs[] = { - [0] = "sdram-lpddr3-hynix-4GB", + [0] = "sdram-lpddr3-samsung-4GB-04EB", + [1] = "sdram-lpddr3-hynix-4GB", [3] = "sdram-lpddr3-samsung-2GB-24EB", [4] = "sdram-lpddr3-micron-2GB", - [5] = "sdram-lpddr3-samsung-4GB-04EB", [6] = "sdram-lpddr3-micron-4GB", }; diff --git a/src/mainboard/google/gru/sdram_params/sdram-lpddr3-hynix-4GB-928.c b/src/mainboard/google/gru/sdram_params/sdram-lpddr3-hynix-4GB-928.c index f75e6b5..0f20b60 100644 --- a/src/mainboard/google/gru/sdram_params/sdram-lpddr3-hynix-4GB-928.c +++ b/src/mainboard/google/gru/sdram_params/sdram-lpddr3-hynix-4GB-928.c @@ -13,6 +13,7 @@ #include <soc/sdram.h> +/* 2 Hynix H9CCNNNBJTALAR chips */ struct rk3399_sdram_params params = { { { -- To view, visit https://review.coreboot.org/22663 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I44215b4a6668074575a5df691ac1ff8fa3d15492 Gerrit-Change-Number: 22663 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com>

1 0

Change in coreboot[master]: google/reef: Fix whitespace inconsistency in coral code
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22662 ) Change subject: google/reef: Fix whitespace inconsistency in coral code ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63984/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18839/ : SUCCESS -- To view, visit https://review.coreboot.org/22662 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e61f1327027c5100773e2b837f439a939807e72 Gerrit-Change-Number: 22662 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 08:43:07 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017