coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: cr50: Make EC clear AP_OFF before hibnernate
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22657 ) Change subject: cr50: Make EC clear AP_OFF before hibnernate ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63977/ : SUCCESS -- To view, visit https://review.coreboot.org/22657 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f590286393ac21382cab64afdccae92d3fc14ba Gerrit-Change-Number: 22657 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 02:25:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: cr50: Make EC clear AP_OFF before hibnernate
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22657 ) Change subject: cr50: Make EC clear AP_OFF before hibnernate ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63976/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18834/ : ABORTED -- To view, visit https://review.coreboot.org/22657 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f590286393ac21382cab64afdccae92d3fc14ba Gerrit-Change-Number: 22657 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 02:17:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: cr50: Make EC clear AP_OFF before hibnernate
by Daisuke Nojiri (Code Review) 01 Dec '17

01 Dec '17

Daisuke Nojiri has uploaded a new patch set (#2). ( https://review.coreboot.org/22657 ) Change subject: cr50: Make EC clear AP_OFF before hibnernate ...................................................................... cr50: Make EC clear AP_OFF before hibnernate WORK_IN_PROGRESS This patch makes AP send EC_REBOOT_HIBERNATE_CLEAR_AP_OFF, which makes EC clear AP_OFF flag then hibernate. This is needed to make Chromebox boot when cr50 toggles the EC's reset line. BUG=b:69721737 BRANCH=none TEST=Verify Fizz reboot after cr50 update. Change-Id: I5f590286393ac21382cab64afdccae92d3fc14ba Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M src/ec/google/chromeec/ec_commands.h M src/vendorcode/google/chromeos/cr50_enable_update.c 2 files changed, 7 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/22657/2 -- To view, visit https://review.coreboot.org/22657 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5f590286393ac21382cab64afdccae92d3fc14ba Gerrit-Change-Number: 22657 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Change in coreboot[master]: cr50: Make EC clear AP_OFF before hibnernate
by Daisuke Nojiri (Code Review) 01 Dec '17

01 Dec '17

Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/22657 Change subject: cr50: Make EC clear AP_OFF before hibnernate ...................................................................... cr50: Make EC clear AP_OFF before hibnernate This patch makes AP send EC_REBOOT_HIBERNATE_CLEAR_AP_OFF, which makes EC clear AP_OFF flag then hibernate. This is needed to make Chromebox boot when cr50 toggles the EC's reset line. BUG=b:69721737 BRANCH=none TEST=Verify Fizz reboot after cr50 update. Change-Id: I5f590286393ac21382cab64afdccae92d3fc14ba Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M src/ec/google/chromeec/ec_commands.h M src/vendorcode/google/chromeos/cr50_enable_update.c 2 files changed, 7 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/22657/1 diff --git a/src/ec/google/chromeec/ec_commands.h b/src/ec/google/chromeec/ec_commands.h index aa63aa7..ee889b7 100644 --- a/src/ec/google/chromeec/ec_commands.h +++ b/src/ec/google/chromeec/ec_commands.h @@ -3785,7 +3785,8 @@ /* (command 3 was jump to RW-B) */ EC_REBOOT_COLD = 4, /* Cold-reboot */ EC_REBOOT_DISABLE_JUMP = 5, /* Disable jump until next reboot */ - EC_REBOOT_HIBERNATE = 6 /* Hibernate EC */ + EC_REBOOT_HIBERNATE = 6, /* Hibernate EC */ + EC_REBOOT_HIBERNATE_CLEAR_AP_OFF = 7, /* and clears AP_OFF flag */ }; /* Flags for ec_params_reboot_ec.reboot_flags */ diff --git a/src/vendorcode/google/chromeos/cr50_enable_update.c b/src/vendorcode/google/chromeos/cr50_enable_update.c index 6e67cc2..7917f1c 100644 --- a/src/vendorcode/google/chromeos/cr50_enable_update.c +++ b/src/vendorcode/google/chromeos/cr50_enable_update.c @@ -60,10 +60,12 @@ printk(BIOS_INFO, "Waiting for CR50 reset to pick up update.\n"); if (IS_ENABLED(CONFIG_POWER_OFF_ON_CR50_UPDATE)) { - if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)) + if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)) { printk(BIOS_INFO, "Hibernating EC.\n"); - google_chromeec_reboot(0, EC_REBOOT_HIBERNATE, - EC_REBOOT_FLAG_ON_AP_SHUTDOWN); + google_chromeec_reboot(0, + EC_REBOOT_HIBERNATE_CLEAR_AP_OFF, + EC_REBOOT_FLAG_ON_AP_SHUTDOWN); + } poweroff(); } halt(); -- To view, visit https://review.coreboot.org/22657 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5f590286393ac21382cab64afdccae92d3fc14ba Gerrit-Change-Number: 22657 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Enable elog in Kconfig
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22638 ) Change subject: mainboard/google/kahlee: Enable elog in Kconfig ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63975/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18833/ : SUCCESS -- To view, visit https://review.coreboot.org/22638 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fe396c8f532b319481bc073f7541bcd743b92b9 Gerrit-Change-Number: 22638 Gerrit-PatchSet: 6 Gerrit-Owner: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 00:40:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Enable elog
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22636 ) Change subject: soc/amd/stoneyridge: Enable elog ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63973/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18831/ : SUCCESS -- To view, visit https://review.coreboot.org/22636 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I595a27ac27daa42c2499de1a343bc30be9a89fa6 Gerrit-Change-Number: 22636 Gerrit-PatchSet: 7 Gerrit-Owner: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 00:27:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Enable elog in Kconfig
by build bot (Jenkins) (Code Review) 01 Dec '17

01 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22638 ) Change subject: mainboard/google/kahlee: Enable elog in Kconfig ...................................................................... Patch Set 5: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/63974/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/18832/ : SUCCESS -- To view, visit https://review.coreboot.org/22638 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fe396c8f532b319481bc073f7541bcd743b92b9 Gerrit-Change-Number: 22638 Gerrit-PatchSet: 5 Gerrit-Owner: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Dec 2017 00:27:27 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017