coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: soc/intel/common/block: Add Intel common Graphics controller support
by build bot (Jenkins) (Code Review) 02 Dec '17

02 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22614 ) Change subject: soc/intel/common/block: Add Intel common Graphics controller support ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64015/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18864/ : SUCCESS -- To view, visit https://review.coreboot.org/22614 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbc73854ce9fc21a8a3e3663a98e01fc94d5a5e4 Gerrit-Change-Number: 22614 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Dec 2017 13:58:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/hp/8460p: Add TPM support
by build bot (Jenkins) (Code Review) 02 Dec '17

02 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22602 ) Change subject: mb/hp/8460p: Add TPM support ...................................................................... Patch Set 13: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64014/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18863/ : SUCCESS -- To view, visit https://review.coreboot.org/22602 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b845928954d203d1c3608b6704fedbd590e1fa9 Gerrit-Change-Number: 22602 Gerrit-PatchSet: 13 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Dec 2017 13:16:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add USB OC support
by Martin Roth (Code Review) 02 Dec '17

02 Dec '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/22678 ) Change subject: soc/amd/stoneyridge: Add USB OC support ...................................................................... Patch Set 1: (3 comments) https://review.coreboot.org/#/c/22678/1/src/soc/amd/stoneyridge/usb.c File src/soc/amd/stoneyridge/usb.c: https://review.coreboot.org/#/c/22678/1/src/soc/amd/stoneyridge/usb.c@30 PS1, Line 30: nit: Extra newlines here and above https://review.coreboot.org/#/c/22678/1/src/soc/amd/stoneyridge/usb.c@32 PS1, Line 32: == Is there a reason for this spacing? https://review.coreboot.org/#/c/22678/1/src/soc/amd/stoneyridge/usb.c@36 PS1, Line 36: (uint32_t) I don't think this cast is needed. -- To view, visit https://review.coreboot.org/22678 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie54c7a2baa78f21cf1cd30d5ed70c8c832cf3674 Gerrit-Change-Number: 22678 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Dec 2017 05:49:21 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: google/kahlee: Set USB OC pins
by Martin Roth (Code Review) 02 Dec '17

02 Dec '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/22679 ) Change subject: google/kahlee: Set USB OC pins ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variant… File src/mainboard/google/kahlee/variants/baseboard/gpio.c: https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variant… PS1, Line 50: return 0; Do we need to add something to disable the other 2? *map |= USB_OC_DISABLE << OC_PORT2_SHIFT; *map |= USB_OC_DISABLE << OC_PORT3_SHIFT; https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variant… File src/mainboard/google/kahlee/variants/kahlee/gpio.c: https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variant… PS1, Line 155: *map &= ~(USB_OC_DISABLE << OC_PORT0_SHIFT); wouldn't it be cleaner just to disable ports 2 & 3? -- To view, visit https://review.coreboot.org/22679 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a9b3409d9c91b89fd02f8eecf9e04c435f14342 Gerrit-Change-Number: 22679 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Dec 2017 05:42:35 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add XHCI PM register access functions
by Martin Roth (Code Review) 02 Dec '17

02 Dec '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/22677 ) Change subject: soc/amd/stoneyridge: Add XHCI PM register access functions ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/22677/1/src/soc/amd/stoneyridge/sb_util.c File src/soc/amd/stoneyridge/sb_util.c: https://review.coreboot.org/#/c/22677/1/src/soc/amd/stoneyridge/sb_util.c@96 PS1, Line 96: } : v Insert a newline? -- To view, visit https://review.coreboot.org/22677 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81b4c0a448eb17c5ee0562a2c3548a074d533a98 Gerrit-Change-Number: 22677 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Dec 2017 05:30:37 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/hp/8460p: Add TPM support
by build bot (Jenkins) (Code Review) 02 Dec '17

02 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22602 ) Change subject: mb/hp/8460p: Add TPM support ...................................................................... Patch Set 12: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64013/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18862/ : SUCCESS -- To view, visit https://review.coreboot.org/22602 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b845928954d203d1c3608b6704fedbd590e1fa9 Gerrit-Change-Number: 22602 Gerrit-PatchSet: 12 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Dec 2017 03:37:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add USB OC support
by build bot (Jenkins) (Code Review) 02 Dec '17

02 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22678 ) Change subject: soc/amd/stoneyridge: Add USB OC support ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64012/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18861/ : SUCCESS -- To view, visit https://review.coreboot.org/22678 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie54c7a2baa78f21cf1cd30d5ed70c8c832cf3674 Gerrit-Change-Number: 22678 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Dec 2017 00:40:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Set USB OC pins
by build bot (Jenkins) (Code Review) 02 Dec '17

02 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22679 ) Change subject: google/kahlee: Set USB OC pins ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64011/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18860/ : SUCCESS -- To view, visit https://review.coreboot.org/22679 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a9b3409d9c91b89fd02f8eecf9e04c435f14342 Gerrit-Change-Number: 22679 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Dec 2017 00:31:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add XHCI PM register access functions
by build bot (Jenkins) (Code Review) 02 Dec '17

02 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22677 ) Change subject: soc/amd/stoneyridge: Add XHCI PM register access functions ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64010/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18859/ : SUCCESS -- To view, visit https://review.coreboot.org/22677 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81b4c0a448eb17c5ee0562a2c3548a074d533a98 Gerrit-Change-Number: 22677 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Dec 2017 00:30:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Set USB OC pins
by Marc Jones (Code Review) 02 Dec '17

02 Dec '17

Marc Jones has posted comments on this change. ( https://review.coreboot.org/22679 ) Change subject: google/kahlee: Set USB OC pins ...................................................................... Patch Set 1: The als oc code is also removed in this patch:https://review.coreboot.org/#/c/22659/ This will need a rebase when that is committed. -- To view, visit https://review.coreboot.org/22679 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a9b3409d9c91b89fd02f8eecf9e04c435f14342 Gerrit-Change-Number: 22679 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Sat, 02 Dec 2017 00:26:27 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017