coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: google/fizz: Remove tpm i2c configs from Kconfig
by Shelley Chen (Code Review) 22 Nov '17

22 Nov '17

Hello build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/22577 to look at the new patch set (#3). Change subject: google/fizz: Remove tpm i2c configs from Kconfig ...................................................................... google/fizz: Remove tpm i2c configs from Kconfig We are disabling tpm over i2c, so the configs are not needed anymore. BUG=b:65056998 BRANCH=None TEST=emerge fizz and make sure can still boot up. Change-Id: Id88f32fa952801749544534442fc15d85fc1a892 Signed-off-by: Shelley Chen <shchen(a)chromium.org> --- M src/mainboard/google/fizz/Kconfig M src/mainboard/google/fizz/gpio.h M src/mainboard/google/fizz/mainboard.c 3 files changed, 3 insertions(+), 63 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/22577/3 -- To view, visit https://review.coreboot.org/22577 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id88f32fa952801749544534442fc15d85fc1a892 Gerrit-Change-Number: 22577 Gerrit-PatchSet: 3 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: google/fizz: Remove tpm i2c configs from Kconfig
by Furquan Shaikh (Code Review) 22 Nov '17

22 Nov '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/22577 ) Change subject: google/fizz: Remove tpm i2c configs from Kconfig ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/22577/1/src/mainboard/google/fizz/mainboard… File src/mainboard/google/fizz/mainboard.c: https://review.coreboot.org/#/c/22577/1/src/mainboard/google/fizz/mainboard… PS1, Line 144: /* Disable unused interface for TPM. */ : tpm = PCH_DEV_I2C1; : if (tpm) : tpm->enabled = 0; This is already done in the devicetree. -- To view, visit https://review.coreboot.org/22577 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id88f32fa952801749544534442fc15d85fc1a892 Gerrit-Change-Number: 22577 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 23 Nov 2017 01:37:54 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: google/fizz: Remove tpm i2c configs from Kconfig
by build bot (Jenkins) (Code Review) 22 Nov '17

22 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22577 ) Change subject: google/fizz: Remove tpm i2c configs from Kconfig ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63693/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18589/ : SUCCESS -- To view, visit https://review.coreboot.org/22577 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id88f32fa952801749544534442fc15d85fc1a892 Gerrit-Change-Number: 22577 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 23 Nov 2017 01:37:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/fizz: Remove tpm i2c configs from Kconfig
by Shelley Chen (Code Review) 22 Nov '17

22 Nov '17

Shelley Chen has uploaded a new patch set (#2). ( https://review.coreboot.org/22577 ) Change subject: google/fizz: Remove tpm i2c configs from Kconfig ...................................................................... google/fizz: Remove tpm i2c configs from Kconfig We are disabling tpm over i2c, so the configs are not needed anymore. BUG=b:65056998 BRANCH=None TEST=emerge fizz and make sure can still boot up. Change-Id: Id88f32fa952801749544534442fc15d85fc1a892 Signed-off-by: Shelley Chen <shchen(a)chromium.org> --- M src/mainboard/google/fizz/Kconfig M src/mainboard/google/fizz/gpio.h M src/mainboard/google/fizz/mainboard.c 3 files changed, 6 insertions(+), 59 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/22577/2 -- To view, visit https://review.coreboot.org/22577 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id88f32fa952801749544534442fc15d85fc1a892 Gerrit-Change-Number: 22577 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: google/fizz: Remove tpm i2c configs from Kconfig
by Shelley Chen (Code Review) 22 Nov '17

22 Nov '17

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/22577 Change subject: google/fizz: Remove tpm i2c configs from Kconfig ...................................................................... google/fizz: Remove tpm i2c configs from Kconfig We are disabling tpm over i2c, so the configs are not needed anymore. BUG=b:65056998 BRANCH=None TEST=emerge fizz and make sure can still boot up. Change-Id: Id88f32fa952801749544534442fc15d85fc1a892 Signed-off-by: Shelley Chen <shchen(a)chromium.org> --- M src/mainboard/google/fizz/Kconfig M src/mainboard/google/fizz/gpio.h M src/mainboard/google/fizz/mainboard.c 3 files changed, 6 insertions(+), 59 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/22577/1 diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig index b1f353d..ce5c8bd 100644 --- a/src/mainboard/google/fizz/Kconfig +++ b/src/mainboard/google/fizz/Kconfig @@ -15,7 +15,9 @@ select MAINBOARD_USES_FSP2_0 select NO_FADT_8042 select SOC_INTEL_KABYLAKE - select FIZZ_USE_SPI_TPM + select MAINBOARD_HAS_SPI_TPM_CR50 + select SPI_TPM + select TPM2 select GENERIC_SPD_BIN select RT8168_GET_MAC_FROM_VPD select RT8168_SET_LED_MODE @@ -29,16 +31,7 @@ select HAS_RECOVERY_MRC_CACHE select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN -config DRIVER_TPM_I2C_BUS - depends on FIZZ_USE_I2C_TPM - default 0x1 - -config DRIVER_TPM_I2C_ADDR - depends on FIZZ_USE_I2C_TPM - default 0x50 - config DRIVER_TPM_SPI_BUS - depends on FIZZ_USE_SPI_TPM default 0x1 config GBB_HWID @@ -69,22 +62,6 @@ config DIMM_SPD_SIZE int default 512 - -# Select this option to enable use of cr50 I2C TPM on fizz. -config FIZZ_USE_I2C_TPM - bool - default n - select I2C_TPM - select MAINBOARD_HAS_I2C_TPM_CR50 - select TPM2 - -# Select this option to enable use of cr50 I2C TPM on fizz. -config FIZZ_USE_SPI_TPM - bool - default n - select MAINBOARD_HAS_SPI_TPM_CR50 - select SPI_TPM - select TPM2 config TPM_TIS_ACPI_INTERRUPT int diff --git a/src/mainboard/google/fizz/gpio.h b/src/mainboard/google/fizz/gpio.h index d54a1fe..e6dc3a7 100644 --- a/src/mainboard/google/fizz/gpio.h +++ b/src/mainboard/google/fizz/gpio.h @@ -92,7 +92,6 @@ /* SLP_S0# */ PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), /* PM_SLP_S0# */ /* PLTRST# */ PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), /* PCI_PLTRST# */ /* SPKR */ PAD_CFG_NF(GPP_B14, NONE, DEEP, NF1), /* SPKR */ -#if IS_ENABLED(CONFIG_FIZZ_USE_SPI_TPM) /* GSPI0_CS# */ PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1), /* PCH_SPI_H1_3V3_CS_L */ /* GSPI0_CLK */ PAD_CFG_NF(GPP_B16, NONE, DEEP, @@ -101,12 +100,6 @@ NF1), /* PCH_SPI_H1_3V3_MISO */ /* GSPI0_MOSI */ PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1), /* PCH_SPI_H1_3V3_MOSI */ -#else -/* GSPI0_CS# */ PAD_CFG_NC(GPP_B15), -/* GSPI0_CLK */ PAD_CFG_NC(GPP_B16), -/* GSPI0_MISO */ PAD_CFG_NC(GPP_B17), -/* GSPI0_MOSI */ PAD_CFG_NC(GPP_B18), -#endif /* GSPI1_CS# */ PAD_CFG_NC(GPP_B19), /* TP111 */ /* GSPI1_CLK */ PAD_CFG_GPI_GPIO_DRIVER(GPP_B20, 20K_PU, DEEP), /* VR_DISABLE_L */ @@ -142,15 +135,8 @@ DEEP), /* SKU_ID3 */ /* I2C0_SDA */ PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), /* I2C0_SCL */ PAD_CFG_NF(GPP_C17, NONE, DEEP, NF1), -#if IS_ENABLED(CONFIG_FIZZ_USE_I2C_TPM) -/* I2C1_SDA */ PAD_CFG_NF(GPP_C18, NONE, DEEP, - NF1), /* PCH_I2C1_H1_3V3_SDA */ -/* I2C1_SCL */ PAD_CFG_NF(GPP_C19, NONE, DEEP, - NF1), /* PCH_I2C1_H1_3V3_SCL */ -#else /* I2C1_SDA */ PAD_CFG_NC(GPP_C18), /* I2C1_SCL */ PAD_CFG_NC(GPP_C19), -#endif /* UART2_RXD */ PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), /* SERVO */ /* UART2_TXD */ PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), /* SERVO */ /* UART2_RTS# */ PAD_CFG_NC(GPP_C22), /* TP309 */ @@ -275,7 +261,6 @@ /* Early pad configuration in bootblock */ static const struct pad_config early_gpio_table[] = { -#if IS_ENABLED(CONFIG_FIZZ_USE_SPI_TPM) /* GSPI0_CS# */ PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1), /* PCH_SPI_H1_3V3_CS_L */ /* GSPI0_CLK */ PAD_CFG_NF(GPP_B16, NONE, DEEP, @@ -284,13 +269,6 @@ NF1), /* PCH_SPI_H1_3V3_MISO */ /* GSPI0_MOSI */ PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1), /* PCH_SPI_H1_3V3_MOSI */ -#endif -#if IS_ENABLED(CONFIG_FIZZ_USE_I2C_TPM) -/* I2C1_SDA */ PAD_CFG_NF(GPP_C18, NONE, DEEP, - NF1), /* PCH_I2C1_H1_3V3_SDA */ -/* I2C1_SCL */ PAD_CFG_NF(GPP_C19, NONE, DEEP, - NF1), /* PCH_I2C1_H1_3V3_SCL */ -#endif /* SATAXPCI0 */ PAD_CFG_GPI_APIC_INVERT(GPP_E0, NONE, PLTRST), /* H1_PCH_INT_ODL */ /* Ensure UART pins are in native mode for H1. */ diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index 54d7c4c..32776ba 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -142,17 +142,9 @@ dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator; /* Disable unused interface for TPM. */ - if (!IS_ENABLED(CONFIG_FIZZ_USE_SPI_TPM)) { - tpm = PCH_DEV_GSPI0; - if (tpm) - tpm->enabled = 0; - } - - if (!IS_ENABLED(CONFIG_FIZZ_USE_I2C_TPM)) { - tpm = PCH_DEV_I2C1; - if (tpm) - tpm->enabled = 0; - } + tpm = PCH_DEV_I2C1; + if (tpm) + tpm->enabled = 0; dev->ops->write_acpi_tables = mainboard_write_acpi_tables; } -- To view, visit https://review.coreboot.org/22577 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id88f32fa952801749544534442fc15d85fc1a892 Gerrit-Change-Number: 22577 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com>

1 0

Change in coreboot[master]: rockchip/rk3399: support dual mipi dsi
by build bot (Jenkins) (Code Review) 22 Nov '17

22 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22471 ) Change subject: rockchip/rk3399: support dual mipi dsi ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18587/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63691/ : SUCCESS -- To view, visit https://review.coreboot.org/22471 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1286c0ccbe50c89514c8daee66439116d3f1ca4 Gerrit-Change-Number: 22471 Gerrit-PatchSet: 7 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sean Paul <seanpaul(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nickey yang <nickey.yang(a)rock-chips.com> Gerrit-Comment-Date: Thu, 23 Nov 2017 01:35:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/scarlet: support kd097d04 panel
by build bot (Jenkins) (Code Review) 22 Nov '17

22 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22472 ) Change subject: google/scarlet: support kd097d04 panel ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18588/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63692/ : SUCCESS -- To view, visit https://review.coreboot.org/22472 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8bc0cbb79840f1924a8cc111f2511292203731f Gerrit-Change-Number: 22472 Gerrit-PatchSet: 10 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sean Paul <seanpaul(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nickey yang <nickey.yang(a)rock-chips.com> Gerrit-Comment-Date: Thu, 23 Nov 2017 01:31:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/fizz: Disable cr50 i2c lines
by build bot (Jenkins) (Code Review) 22 Nov '17

22 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22576 ) Change subject: google/fizz: Disable cr50 i2c lines ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18585/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63689/ : SUCCESS -- To view, visit https://review.coreboot.org/22576 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac3e31264a937a1d7ed6bd41632e7e065317781b Gerrit-Change-Number: 22576 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Pronin <apronin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 23 Nov 2017 01:19:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/fizz: Disable cr50 i2c lines
by Shelley Chen (Code Review) 22 Nov '17

22 Nov '17

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/22576 Change subject: google/fizz: Disable cr50 i2c lines ...................................................................... google/fizz: Disable cr50 i2c lines As cr50 has now switched to using SPI, no need to enable the i2c anymore. BUG=b:69374421 BRANCH=None TEST=test on fizz celeron. Make sure /dev/tpm0 created on (many) reboots. cat /proc/interrupts. Make sure # interrupts for 16 after booting is reasonable (not > 10k). and idma64.0, i2c_designware.0 are not listed with that line anymore. Should look something like: 16: 1174 0 IO-APIC 16-fasteoi i801_smbus, snd_soc_skl, AudioDSP Change-Id: Iac3e31264a937a1d7ed6bd41632e7e065317781b Signed-off-by: Shelley Chen <shchen(a)chromium.org> --- M src/mainboard/google/fizz/devicetree.cb 1 file changed, 7 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/22576/1 diff --git a/src/mainboard/google/fizz/devicetree.cb b/src/mainboard/google/fizz/devicetree.cb index 73a5c50..df664b2 100644 --- a/src/mainboard/google/fizz/devicetree.cb +++ b/src/mainboard/google/fizz/devicetree.cb @@ -233,17 +233,11 @@ .early_init = 1, }" - # Configure I2C1 for cr50 TPM. Early init is required to set up a BAR - # for TPM communication before memory is up. - register "i2c[1]" = "{ - .early_init = 1, - }" - # Must leave UART0 enabled or SD/eMMC will not work as PCI register "SerialIoDevMode" = "{ - [PchSerialIoIndexI2C0] = PchSerialIoPci, - [PchSerialIoIndexI2C1] = PchSerialIoPci, - [PchSerialIoIndexI2C2] = PchSerialIoPci, + [PchSerialIoIndexI2C0] = PchSerialIoDisabled, + [PchSerialIoIndexI2C1] = PchSerialIoDisabled, + [PchSerialIoIndexI2C2] = PchSerialIoDisabled, [PchSerialIoIndexI2C3] = PchSerialIoDisabled, [PchSerialIoIndexI2C4] = PchSerialIoDisabled, [PchSerialIoIndexI2C5] = PchSerialIoPci, @@ -273,18 +267,10 @@ device pci 14.0 on end # USB xHCI device pci 14.1 off end # USB xDCI (OTG) device pci 14.2 on end # Thermal Subsystem - device pci 15.0 on - end # I2C #0 - device pci 15.1 on - chip drivers/i2c/tpm - register "hid" = ""GOOG0005"" - register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_E0_IRQ)" - device i2c 50 on end - end - end # I2C #1 - device pci 15.2 on end # I2C #2 - device pci 15.3 off - end # I2C #3 + device pci 15.0 off end # I2C #0 + device pci 15.1 off end # I2C #1 + device pci 15.2 off end # I2C #2 + device pci 15.3 off end # I2C #3 device pci 16.0 on end # Management Engine Interface 1 device pci 16.1 off end # Management Engine Interface 2 device pci 16.2 off end # Management Engine IDE-R -- To view, visit https://review.coreboot.org/22576 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iac3e31264a937a1d7ed6bd41632e7e065317781b Gerrit-Change-Number: 22576 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com>

1 0

Change in coreboot[master]: amd/stoneyridge: Delete early_setup.c
by Marc Jones (Code Review) 22 Nov '17

22 Nov '17

Marc Jones has posted comments on this change. ( https://review.coreboot.org/22569 ) Change subject: amd/stoneyridge: Delete early_setup.c ...................................................................... Patch Set 1: This change should be split. First change kahlee, then delete the file. -- To view, visit https://review.coreboot.org/22569 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe75a2d5cc46641e9d0af462a8a0ba5bb7a0f9c3 Gerrit-Change-Number: 22569 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 23 Nov 2017 00:43:49 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017