November 2017 - coreboot-gerrit

Change in coreboot[master]: soc/amd/stoneyridge: Fix guarded code in ACPI ASL
by build bot (Jenkins) (Code Review) Dec. 1, 2017

Dec. 1, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22634 ) Change subject: soc/amd/stoneyridge: Fix guarded code in ACPI ASL ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63972/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18830/ : SUCCESS -- To view, visit https://review.coreboot.org/22634 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71c6acb235df9aa8642dca4c85d2bf604e244bf4 Gerrit-Change-Number: 22634 Gerrit-PatchSet: 5 Gerrit-Owner: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 23:47:29 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge/acpi: Fix guarded code in ACPI ASL
by build bot (Jenkins) (Code Review) Dec. 1, 2017

Dec. 1, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22634 ) Change subject: soc/amd/stoneyridge/acpi: Fix guarded code in ACPI ASL ...................................................................... Patch Set 4: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63971/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/18829/ : SUCCESS -- To view, visit https://review.coreboot.org/22634 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71c6acb235df9aa8642dca4c85d2bf604e244bf4 Gerrit-Change-Number: 22634 Gerrit-PatchSet: 4 Gerrit-Owner: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 23:36:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge/acpi: Fix guarded code in ACPI ASL
by build bot (Jenkins) (Code Review) Dec. 1, 2017

Dec. 1, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22634 ) Change subject: soc/amd/stoneyridge/acpi: Fix guarded code in ACPI ASL ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63970/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/18828/ : SUCCESS -- To view, visit https://review.coreboot.org/22634 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71c6acb235df9aa8642dca4c85d2bf604e244bf4 Gerrit-Change-Number: 22634 Gerrit-PatchSet: 3 Gerrit-Owner: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 23:31:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: acpi/tpm: remove non-existent IRQ for Infineon TPM chip
by Philipp Deppenwiese (Code Review) Nov. 30, 2017

Nov. 30, 2017

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22582 ) Change subject: acpi/tpm: remove non-existent IRQ for Infineon TPM chip ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/22582 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id510c73cfdc14b7f82b0cc695691b55423185a0b Gerrit-Change-Number: 22582 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 20:17:44 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Update Kconfig string used in makefiles
by build bot (Jenkins) (Code Review) Nov. 30, 2017

Nov. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22656 ) Change subject: mainboard/google/kahlee: Update Kconfig string used in makefiles ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63969/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18827/ : SUCCESS -- To view, visit https://review.coreboot.org/22656 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieffabaae5516a893f1dc1f7195a17c4cdeae8853 Gerrit-Change-Number: 22656 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 20:01:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Update Kconfig string used in makefiles
by Martin Roth (Code Review) Nov. 30, 2017

Nov. 30, 2017

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/22656 Change subject: mainboard/google/kahlee: Update Kconfig string used in makefiles ...................................................................... mainboard/google/kahlee: Update Kconfig string used in makefiles Update the variable ${CONFIG_VARIANT_DIR} to use parens instead. Either is valid, but since we use parenthesis everywhere else, it's better to be consistent. BUG=b:69691210 TEST=Build grunt & kahlee Change-Id: Ieffabaae5516a893f1dc1f7195a17c4cdeae8853 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/google/kahlee/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/22656/1 diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index 690faa9..80cfe88 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -58,7 +58,7 @@ config FMDFILE string - default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/variants/${CONFIG_VARIANT_DIR}/chromeos.fmd" if CHROMEOS + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/variants/$(CONFIG_VARIANT_DIR)/chromeos.fmd" if CHROMEOS default "" help The build system creates a default FMAP from ROM_SIZE and CBFS_SIZE, -- To view, visit https://review.coreboot.org/22656 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ieffabaae5516a893f1dc1f7195a17c4cdeae8853 Gerrit-Change-Number: 22656 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: src/soc/intel/cannonlake: Add _PRW for CNVi
by build bot (Jenkins) (Code Review) Nov. 30, 2017

Nov. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22611 ) Change subject: src/soc/intel/cannonlake: Add _PRW for CNVi ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63968/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18826/ : SUCCESS -- To view, visit https://review.coreboot.org/22611 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6689754d1c4100615e4e4ae5a7f9846f4bf785f Gerrit-Change-Number: 22611 Gerrit-PatchSet: 4 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 19:27:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/mainboard/glkrvp: Turn on CPU fan
by build bot (Jenkins) (Code Review) Nov. 30, 2017

Nov. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22235 ) Change subject: src/mainboard/glkrvp: Turn on CPU fan ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63964/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18822/ : SUCCESS -- To view, visit https://review.coreboot.org/22235 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I361e53d4fd53678f3abb8fe9862071aec6e149a7 Gerrit-Change-Number: 22235 Gerrit-PatchSet: 7 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 19:00:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoney: clean up and update reset.c
by build bot (Jenkins) (Code Review) Nov. 30, 2017

Nov. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22439 ) Change subject: soc/amd/stoney: clean up and update reset.c ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63967/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18825/ : SUCCESS -- To view, visit https://review.coreboot.org/22439 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cc4c04b53b7fec38d45e962ff1292d8c717269c Gerrit-Change-Number: 22439 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 18:48:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Enable elog
by build bot (Jenkins) (Code Review) Nov. 30, 2017

Nov. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22636 ) Change subject: soc/amd/stoneyridge: Enable elog ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63966/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18824/ : SUCCESS -- To view, visit https://review.coreboot.org/22636 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I595a27ac27daa42c2499de1a343bc30be9a89fa6 Gerrit-Change-Number: 22636 Gerrit-PatchSet: 6 Gerrit-Owner: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 18:41:55 +0000 Gerrit-HasComments: No

1 0