coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: soraka: move WLAN_PE_RST gpio pad entry to early_gpio_table
by build bot (Jenkins) (Code Review) 23 Nov '17

23 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22587 ) Change subject: soraka: move WLAN_PE_RST gpio pad entry to early_gpio_table ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18626/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63737/ : SUCCESS -- To view, visit https://review.coreboot.org/22587 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c7a4a3871a3bff69c1136379c78a8368c6258a6 Gerrit-Change-Number: 22587 Gerrit-PatchSet: 1 Gerrit-Owner: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Nov 2017 04:06:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soraka: move WLAN_PE_RST gpio pad entry to early_gpio_table
by Divya Chellappa (Code Review) 23 Nov '17

23 Nov '17

Divya Chellappa has uploaded this change for review. ( https://review.coreboot.org/22587 Change subject: soraka: move WLAN_PE_RST gpio pad entry to early_gpio_table ...................................................................... soraka: move WLAN_PE_RST gpio pad entry to early_gpio_table RSMRST reset config doesn't preserve the gpio configuration across deepSx, in such scenarios, gpio pad configuration should be done in early pad configuration in bootblock. BUG=none BRANCH=none TEST= WiFi functionality across S3, DeepS3, S0ix and warm/cold reboot. Change-Id: I5c7a4a3871a3bff69c1136379c78a8368c6258a6 Signed-off-by: Divya Chellap <divya.chellappa(a)intel.com> --- M src/mainboard/google/poppy/variants/soraka/gpio.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/22587/1 diff --git a/src/mainboard/google/poppy/variants/soraka/gpio.c b/src/mainboard/google/poppy/variants/soraka/gpio.c index 84a8294..ae1d07d 100644 --- a/src/mainboard/google/poppy/variants/soraka/gpio.c +++ b/src/mainboard/google/poppy/variants/soraka/gpio.c @@ -78,8 +78,7 @@ PAD_CFG_NF(GPP_B6, NONE, DEEP, NF1), /* B7 : SRCCLKREQ2# ==> NC */ PAD_CFG_NC(GPP_B7), - /* B8 : SRCCLKREQ3# ==> WLAN_PE_RST */ - PAD_CFG_GPO(GPP_B8, 0, RSMRST), + /* B9 : SRCCLKREQ4# ==> NC */ PAD_CFG_NC(GPP_B9), /* B10 : SRCCLKREQ5# ==> NC */ @@ -371,6 +370,8 @@ /* Early pad configuration in bootblock */ static const struct pad_config early_gpio_table[] = { + /* B8 : SRCCLKREQ3# ==> WLAN_PE_RST */ + PAD_CFG_GPO(GPP_B8, 0, RSMRST), #if IS_ENABLED(CONFIG_POPPY_USE_SPI_TPM) /* B15 : GSPI0_CS# ==> PCH_SPI_H1_3V3_CS_L */ PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1), @@ -388,7 +389,6 @@ /* C19 : I2C1_SCL ==> PCH_I2C1_H1_3V3_SCL */ PAD_CFG_NF(GPP_C19, NONE, DEEP, NF1), #endif - /* Ensure UART pins are in native mode for H1. */ /* C20 : UART2_RXD ==> PCHRX_SERVOTX_UART */ PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), -- To view, visit https://review.coreboot.org/22587 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5c7a4a3871a3bff69c1136379c78a8368c6258a6 Gerrit-Change-Number: 22587 Gerrit-PatchSet: 1 Gerrit-Owner: Divya Chellappa <divya.chellappa(a)intel.com>

1 0

Change in coreboot[master]: amd/stoneyridge/southbridge.c: Fix table intr_types[]
by build bot (Jenkins) (Code Review) 23 Nov '17

23 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22548 ) Change subject: amd/stoneyridge/southbridge.c: Fix table intr_types[] ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18625/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63736/ : SUCCESS -- To view, visit https://review.coreboot.org/22548 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f0921e0a540a31b1fb7ec3940006d632cb25f55 Gerrit-Change-Number: 22548 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Nov 2017 03:34:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: correct the SIO_EC_ENABLE_P2SK typo
by build bot (Jenkins) (Code Review) 23 Nov '17

23 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22586 ) Change subject: mb/google/poppy/variants/nautilus: correct the SIO_EC_ENABLE_P2SK typo ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18624/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63735/ : SUCCESS -- To view, visit https://review.coreboot.org/22586 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaded458e202bc975c73cd295f7b363e2c9bfa861 Gerrit-Change-Number: 22586 Gerrit-PatchSet: 1 Gerrit-Owner: Chris Wang <chriswang(a)ami.com.tw> Gerrit-Reviewer: Chris Wang <chriswang(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Nov 2017 03:14:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: correct the SIO_EC_ENABLE_P2SK typo
by Chris Wang (Code Review) 23 Nov '17

23 Nov '17

Hello Chris Wang, I'd like you to do a code review. Please visit https://review.coreboot.org/22586 to review the following change. Change subject: mb/google/poppy/variants/nautilus: correct the SIO_EC_ENABLE_P2SK typo ...................................................................... mb/google/poppy/variants/nautilus: correct the SIO_EC_ENABLE_P2SK typo correct the typo from SIO_EC_ENABLE_P2SK to SIO_EC_ENABLE_PS2K. BRANCH=master BUG=b:66462881 TEST=compiled/boot to ChromeOS. Change-Id: Iaded458e202bc975c73cd295f7b363e2c9bfa861 Signed-off-by: Chris Wang <chriswang(a)ami.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/22586/1 diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h b/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h index cf8682b..ca9f865 100644 --- a/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h +++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h @@ -75,6 +75,6 @@ #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ -#define SIO_EC_ENABLE_P2SK +#define SIO_EC_ENABLE_PS2K #endif /* __MAINBOARD_EC_H__ */ -- To view, visit https://review.coreboot.org/22586 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iaded458e202bc975c73cd295f7b363e2c9bfa861 Gerrit-Change-Number: 22586 Gerrit-PatchSet: 1 Gerrit-Owner: Chris Wang <chriswang(a)ami.com.tw> Gerrit-Reviewer: Chris Wang <chriswang(a)ami.corp-partner.google.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: remove ALS for nautilus
by build bot (Jenkins) (Code Review) 23 Nov '17

23 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22584 ) Change subject: mb/google/poppy/variants/nautilus: remove ALS for nautilus ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63734/ : SUCCESS -- To view, visit https://review.coreboot.org/22584 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib357328799015f78b18cd260db221e524e98cef7 Gerrit-Change-Number: 22584 Gerrit-PatchSet: 3 Gerrit-Owner: Chris Wang <chriswang(a)ami.com.tw> Gerrit-Reviewer: Chris Wang <chriswang(a)ami.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: shkim <sh_.kim(a)samsung.com> Gerrit-Comment-Date: Fri, 24 Nov 2017 03:06:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: remove ALS for nautilus
by build bot (Jenkins) (Code Review) 23 Nov '17

23 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22584 ) Change subject: mb/google/poppy/variants/nautilus: remove ALS for nautilus ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63733/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18623/ : SUCCESS -- To view, visit https://review.coreboot.org/22584 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib357328799015f78b18cd260db221e524e98cef7 Gerrit-Change-Number: 22584 Gerrit-PatchSet: 2 Gerrit-Owner: Chris Wang <chriswang(a)ami.com.tw> Gerrit-Reviewer: Chris Wang <chriswang(a)ami.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: shkim <sh_.kim(a)samsung.com> Gerrit-Comment-Date: Fri, 24 Nov 2017 03:00:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge/lpc.c: Use new wide IO functions
by build bot (Jenkins) (Code Review) 23 Nov '17

23 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22574 ) Change subject: amd/stoneyridge/lpc.c: Use new wide IO functions ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18622/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63732/ : SUCCESS -- To view, visit https://review.coreboot.org/22574 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8533e8ff766df8a8261298559aace7666487826d Gerrit-Change-Number: 22574 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Nov 2017 02:56:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Set low maximum temperature threshold for Thermal ...
by build bot (Jenkins) (Code Review) 23 Nov '17

23 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22419 ) Change subject: soc/intel/skylake: Set low maximum temperature threshold for Thermal Device ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18621/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63731/ : SUCCESS -- To view, visit https://review.coreboot.org/22419 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94d09a28bf1ea07a53cfa04c54752358bafca610 Gerrit-Change-Number: 22419 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Rushikesh S Kadam <rushikesh.s.kadam(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Fri, 24 Nov 2017 02:49:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Delete early_setup.c
by build bot (Jenkins) (Code Review) 23 Nov '17

23 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22569 ) Change subject: amd/stoneyridge: Delete early_setup.c ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18620/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63730/ : SUCCESS -- To view, visit https://review.coreboot.org/22569 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe75a2d5cc46641e9d0af462a8a0ba5bb7a0f9c3 Gerrit-Change-Number: 22569 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Nov 2017 02:21:43 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017