coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: mb/google/poppy/variants/nautilus: set I2C speed to 400KHz
by Chris Wang (Code Review) 23 Nov '17

23 Nov '17

Hello Chris Wang, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22589 to look at the new patch set (#3). Change subject: mb/google/poppy/variants/nautilus: set I2C speed to 400KHz ...................................................................... mb/google/poppy/variants/nautilus: set I2C speed to 400KHz Add "speed_config" for each I2C port configuration to set speed to 400KHz. BRANCH=master BUG=none TEST=compiled/verified Change-Id: Icb48733b87cefc92577547b1eab661a8cbb12be6 Signed-off-by: Chris Wang <chriswang(a)ami.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nautilus/devicetree.cb 1 file changed, 52 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/22589/3 -- To view, visit https://review.coreboot.org/22589 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icb48733b87cefc92577547b1eab661a8cbb12be6 Gerrit-Change-Number: 22589 Gerrit-PatchSet: 3 Gerrit-Owner: Chris Wang <chriswang(a)ami.com.tw> Gerrit-Reviewer: Chris Wang <chriswang(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: set I2C speed to 400KHz
by build bot (Jenkins) (Code Review) 23 Nov '17

23 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22589 ) Change subject: mb/google/poppy/variants/nautilus: set I2C speed to 400KHz ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63741/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18628/ : SUCCESS -- To view, visit https://review.coreboot.org/22589 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb48733b87cefc92577547b1eab661a8cbb12be6 Gerrit-Change-Number: 22589 Gerrit-PatchSet: 1 Gerrit-Owner: Chris Wang <chriswang(a)ami.com.tw> Gerrit-Reviewer: Chris Wang <chriswang(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Nov 2017 06:08:01 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: set I2C speed to 400KHz
by Chris Wang (Code Review) 23 Nov '17

23 Nov '17

Hello Chris Wang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/22589 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/nautilus: set I2C speed to 400KHz ...................................................................... mb/google/poppy/variants/nautilus: set I2C speed to 400KHz Add "speed_config" for each I2C port configuration to set speed to 400KHz. BRANCH=master BUG=none TEST=compiled/verified Change-Id: Icb48733b87cefc92577547b1eab661a8cbb12be6 Signed-off-by: Chris Wang <chriswang(a)ami.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nautilus/devicetree.cb 1 file changed, 53 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/22589/2 -- To view, visit https://review.coreboot.org/22589 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icb48733b87cefc92577547b1eab661a8cbb12be6 Gerrit-Change-Number: 22589 Gerrit-PatchSet: 2 Gerrit-Owner: Chris Wang <chriswang(a)ami.com.tw> Gerrit-Reviewer: Chris Wang <chriswang(a)ami.corp-partner.google.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Change IA/GT/SA slow slew rate set...
by build bot (Jenkins) (Code Review) 23 Nov '17

23 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22588 ) Change subject: mb/google/poppy/variants/nautilus: Change IA/GT/SA slow slew rate settings ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63740/ : SUCCESS -- To view, visit https://review.coreboot.org/22588 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf11aba7bafb3b02c510905d7d904507eee6394b Gerrit-Change-Number: 22588 Gerrit-PatchSet: 2 Gerrit-Owner: Chris Wang <chriswang(a)ami.com.tw> Gerrit-Reviewer: Chris Wang <chriswang(a)ami.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: shkim <sh_.kim(a)samsung.com> Gerrit-Comment-Date: Fri, 24 Nov 2017 06:05:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: set I2C speed to 400KHz
by Chris Wang (Code Review) 23 Nov '17

23 Nov '17

Hello Chris Wang, I'd like you to do a code review. Please visit https://review.coreboot.org/22589 to review the following change. Change subject: mb/google/poppy/variants/nautilus: set I2C speed to 400KHz ...................................................................... mb/google/poppy/variants/nautilus: set I2C speed to 400KHz Add "speed_config" for each I2C port configuration to set speed to 400KHz. BRANCH=master BUG=none TEST=compiled/verified Change-Id: Icb48733b87cefc92577547b1eab661a8cbb12be6 Signed-off-by: Chris Wang <chriswang(a)ami.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nautilus/devicetree.cb 1 file changed, 53 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/22589/1 diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb index 6ee7a52..83feda5 100644 --- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb @@ -78,6 +78,7 @@ register "SlowSlewRateForIa" = "3" # Fast/16 register "SlowSlewRateForGt" = "3" # Fast/16 register "SlowSlewRateForSa" = "3" # Fast/16 + # VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS | @@ -175,6 +176,15 @@ # Touchscreen register "i2c_voltage[0]" = "I2C_VOLTAGE_3V3" + register "i2c[0]" = "{ + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 100, + .sda_hold = 36, + }, + }" # H1 register "i2c_voltage[1]" = "I2C_VOLTAGE_3V3" @@ -182,20 +192,62 @@ # for TPM communication before memory is up. register "i2c[1]" = "{ .early_init = 1, + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 100, + .sda_hold = 36, + }, }" # Trackpad register "i2c_voltage[2]" = "I2C_VOLTAGE_1V8" + register "i2c[2]" = "{ + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 100, + .sda_hold = 36, + }, + }" # Pen register "i2c_voltage[3]" = "I2C_VOLTAGE_1V8" + register "i2c[3]" = "{ + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 100, + .sda_hold = 36, + }, + }" # Camera register "i2c_voltage[4]" = "I2C_VOLTAGE_1V8" + register "i2c[4]" = "{ + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 100, + .sda_hold = 36, + }, + }" # Audio register "i2c_voltage[5]" = "I2C_VOLTAGE_1V8" - + register "i2c[5]" = "{ + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 100, + .sda_hold = 36, + }, + }" # Must leave UART0 enabled or SD/eMMC will not work as PCI register "SerialIoDevMode" = "{ @@ -210,13 +262,6 @@ [PchSerialIoIndexUart0] = PchSerialIoPci, [PchSerialIoIndexUart1] = PchSerialIoDisabled, [PchSerialIoIndexUart2] = PchSerialIoSkipInit, - }" - - # Enable I2C5 for audio codec at 400kHz - register "i2c[5]" = "{ - .speed = I2C_SPEED_FAST, - .rise_time_ns = 104, - .fall_time_ns = 52, }" register "speed_shift_enable" = "1" -- To view, visit https://review.coreboot.org/22589 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icb48733b87cefc92577547b1eab661a8cbb12be6 Gerrit-Change-Number: 22589 Gerrit-PatchSet: 1 Gerrit-Owner: Chris Wang <chriswang(a)ami.com.tw> Gerrit-Reviewer: Chris Wang <chriswang(a)ami.corp-partner.google.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: correct the SIO_EC_ENABLE_P2SK typo
by shkim (Code Review) 23 Nov '17

23 Nov '17

shkim has posted comments on this change. ( https://review.coreboot.org/22586 ) Change subject: mb/google/poppy/variants/nautilus: correct the SIO_EC_ENABLE_P2SK typo ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/22586 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaded458e202bc975c73cd295f7b363e2c9bfa861 Gerrit-Change-Number: 22586 Gerrit-PatchSet: 1 Gerrit-Owner: Chris Wang <chriswang(a)ami.com.tw> Gerrit-Reviewer: Chris Wang <chriswang(a)ami.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: shkim <sh_.kim(a)samsung.com> Gerrit-Comment-Date: Fri, 24 Nov 2017 05:50:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Change IA/GT/SA slow slew rate set...
by build bot (Jenkins) (Code Review) 23 Nov '17

23 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22588 ) Change subject: mb/google/poppy/variants/nautilus: Change IA/GT/SA slow slew rate settings ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63739/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18627/ : SUCCESS -- To view, visit https://review.coreboot.org/22588 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf11aba7bafb3b02c510905d7d904507eee6394b Gerrit-Change-Number: 22588 Gerrit-PatchSet: 1 Gerrit-Owner: Chris Wang <chriswang(a)ami.com.tw> Gerrit-Reviewer: Chris Wang <chriswang(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Nov 2017 05:50:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Change IA/GT/SA slow slew rate set...
by Chris Wang (Code Review) 23 Nov '17

23 Nov '17

Hello Chris Wang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/22588 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/nautilus: Change IA/GT/SA slow slew rate settings ...................................................................... mb/google/poppy/variants/nautilus: Change IA/GT/SA slow slew rate settings Change IA/GT/SA slow slew rate settings. System's audible noise will be reduced with them. - Slow slew rate for IA/GT/SA : fast/16 - Fast PKG C-state ramp for IA/GT/SA: disabled BRANCH=master BUG=none TEST=compiled/verified Change-Id: Ibf11aba7bafb3b02c510905d7d904507eee6394b Signed-off-by: Chris Wang <chriswang(a)ami.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nautilus/devicetree.cb 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/22588/2 -- To view, visit https://review.coreboot.org/22588 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibf11aba7bafb3b02c510905d7d904507eee6394b Gerrit-Change-Number: 22588 Gerrit-PatchSet: 2 Gerrit-Owner: Chris Wang <chriswang(a)ami.com.tw> Gerrit-Reviewer: Chris Wang <chriswang(a)ami.corp-partner.google.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Change IA/GT/SA slow slew rate set...
by Chris Wang (Code Review) 23 Nov '17

23 Nov '17

Hello Chris Wang, I'd like you to do a code review. Please visit https://review.coreboot.org/22588 to review the following change. Change subject: mb/google/poppy/variants/nautilus: Change IA/GT/SA slow slew rate settings ...................................................................... mb/google/poppy/variants/nautilus: Change IA/GT/SA slow slew rate settings Change IA/GT/SA slow slew rate settings. System's audible noise will be reduced with them. - Slow slew rate for IA/GT/SA : fast/16 - Fast PKG C-state ramp for IA/GT/SA: disabled BRANCH=master BUG=b:66462881 TEST=compiled/verified Change-Id: Ibf11aba7bafb3b02c510905d7d904507eee6394b Signed-off-by: Chris Wang <chriswang(a)ami.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nautilus/devicetree.cb 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/22588/1 diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb index efaea3f..6ee7a52 100644 --- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb @@ -70,6 +70,14 @@ register "pirqg_routing" = "PCH_IRQ11" register "pirqh_routing" = "PCH_IRQ11" + # VR Slew rate setting for improving audible noise + register "AcousticNoiseMitigation" = "1" + register "FastPkgCRampDisableIa" = "1" + register "FastPkgCRampDisableGt" = "1" + register "FastPkgCRampDisableSa" = "1" + register "SlowSlewRateForIa" = "3" # Fast/16 + register "SlowSlewRateForGt" = "3" # Fast/16 + register "SlowSlewRateForSa" = "3" # Fast/16 # VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS | -- To view, visit https://review.coreboot.org/22588 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf11aba7bafb3b02c510905d7d904507eee6394b Gerrit-Change-Number: 22588 Gerrit-PatchSet: 1 Gerrit-Owner: Chris Wang <chriswang(a)ami.com.tw> Gerrit-Reviewer: Chris Wang <chriswang(a)ami.corp-partner.google.com>

1 0

Change in coreboot[master]: mainboard/intel/saddlebrook: add support for Saddle Brook
by build bot (Jenkins) (Code Review) 23 Nov '17

23 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21436 ) Change subject: mainboard/intel/saddlebrook: add support for Saddle Brook ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63738/ : SUCCESS -- To view, visit https://review.coreboot.org/21436 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie221eb58e8ab8ff15e9ef19c1d145a5eb2921b4e Gerrit-Change-Number: 21436 Gerrit-PatchSet: 7 Gerrit-Owner: Anuj Mittal <anujx.mittal(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Anuj Mittal <anujx.mittal(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Nov 2017 04:28:08 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017