coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: src/soc/intel/cannonlake: Add gpio groups
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22572 ) Change subject: src/soc/intel/cannonlake: Add gpio groups ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18690/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63821/ : SUCCESS -- To view, visit https://review.coreboot.org/22572 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00be5e9bf25f1723a3d9e177588135d63ab89662 Gerrit-Change-Number: 22572 Gerrit-PatchSet: 3 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 01:07:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add GPIO community 3 definition
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22482 ) Change subject: soc/intel/cannonlake: Add GPIO community 3 definition ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18688/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63819/ : SUCCESS -- To view, visit https://review.coreboot.org/22482 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73b7803c73446660f5c25b1263e47bb50a955c56 Gerrit-Change-Number: 22482 Gerrit-PatchSet: 6 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 01:06:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block/gpio: change the way group offset is calculated.
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22571 ) Change subject: soc/intel/common/block/gpio: change the way group offset is calculated. ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18689/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63820/ : SUCCESS -- To view, visit https://review.coreboot.org/22571 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02ab1d878bc83d32222be074bd2db5e23adaf580 Gerrit-Change-Number: 22571 Gerrit-PatchSet: 3 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 01:00:00 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22612 ) Change subject: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63818/ : SUCCESS -- To view, visit https://review.coreboot.org/22612 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic435b1290c9d3667b890ecc29c5147a25c16b96f Gerrit-Change-Number: 22612 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 00:45:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check
by Richard Spiegel (Code Review) 28 Nov '17

28 Nov '17

Hello build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/22612 to look at the new patch set (#2). Change subject: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check ...................................................................... amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check Coverity reported pointer dev being dereferenced when assigning pointer conf, before checking dev for NULL. Pointer dev must be NULL checked before assigning a value to pointer conf. Fixes coverity CID 1241851: Dereference before NULL check. BUG=b:69810057 TEST=Build and platform boot to OS Change-Id: Ic435b1290c9d3667b890ecc29c5147a25c16b96f Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/soc/amd/stoneyridge/dimm_spd.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/22612/2 -- To view, visit https://review.coreboot.org/22612 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic435b1290c9d3667b890ecc29c5147a25c16b96f Gerrit-Change-Number: 22612 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check
by Richard Spiegel (Code Review) 28 Nov '17

28 Nov '17

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22612 ) Change subject: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check ...................................................................... Patch Set 1: (3 comments) https://review.coreboot.org/#/c/22612/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/22612/1//COMMIT_MSG@12 PS1, Line 12: > Please add a line like: Ok https://review.coreboot.org/#/c/22612/1//COMMIT_MSG@13 PS1, Line 13: 69669995 > Instead of marking this against the overall tracking bug, I'd ask that you Ok, will do https://review.coreboot.org/#/c/22612/1//COMMIT_MSG@14 PS1, Line 14: > Please add a "TEST=" line just saying what you did or what someone else wou Ok -- To view, visit https://review.coreboot.org/22612 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic435b1290c9d3667b890ecc29c5147a25c16b96f Gerrit-Change-Number: 22612 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 00:12:37 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: src/soc/intel/cannonlake: Add _PRW for CNVi
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22611 ) Change subject: src/soc/intel/cannonlake: Add _PRW for CNVi ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63817/ : SUCCESS -- To view, visit https://review.coreboot.org/22611 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6689754d1c4100615e4e4ae5a7f9846f4bf785f Gerrit-Change-Number: 22611 Gerrit-PatchSet: 2 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 00:11:56 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/soc/intel/cannonlake: Add _PRW for CNVi
by Bora Guvendik (Code Review) 28 Nov '17

28 Nov '17

Hello Hima B Chilmakuru, Hannah Williams, I'd like you to reexamine a change. Please visit https://review.coreboot.org/22611 to look at the new patch set (#2). Change subject: src/soc/intel/cannonlake: Add _PRW for CNVi ...................................................................... src/soc/intel/cannonlake: Add _PRW for CNVi TEST=Boot to OS and check if WLAN device wake host Change-Id: Id6689754d1c4100615e4e4ae5a7f9846f4bf785f Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> --- A src/soc/intel/cannonlake/acpi/cnvi.asl M src/soc/intel/cannonlake/acpi/southbridge.asl 2 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/22611/2 -- To view, visit https://review.coreboot.org/22611 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id6689754d1c4100615e4e4ae5a7f9846f4bf785f Gerrit-Change-Number: 22611 Gerrit-PatchSet: 2 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com>

1 0

Change in coreboot[master]: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check
by Martin Roth (Code Review) 28 Nov '17

28 Nov '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/22612 ) Change subject: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check ...................................................................... Patch Set 1: Code-Review+1 (3 comments) +2 after the commit message is updated. https://review.coreboot.org/#/c/22612/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/22612/1//COMMIT_MSG@12 PS1, Line 12: Please add a line like: Fixes coverity CID 1241851: Dereference before null check https://review.coreboot.org/#/c/22612/1//COMMIT_MSG@13 PS1, Line 13: 69669995 Instead of marking this against the overall tracking bug, I'd ask that you create a new bug and mark that as blocking 69669995. https://review.coreboot.org/#/c/22612/1//COMMIT_MSG@14 PS1, Line 14: Please add a "TEST=" line just saying what you did or what someone else would need to do to test the change. TEST=Build or TEST=None are both valid, but if you did something more extensive, please describe it. This should be done for all changes done for Google bugs. -- To view, visit https://review.coreboot.org/22612 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic435b1290c9d3667b890ecc29c5147a25c16b96f Gerrit-Change-Number: 22612 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 27 Nov 2017 23:34:29 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check
by build bot (Jenkins) (Code Review) 27 Nov '17

27 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22612 ) Change subject: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18687/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63816/ : SUCCESS -- To view, visit https://review.coreboot.org/22612 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic435b1290c9d3667b890ecc29c5147a25c16b96f Gerrit-Change-Number: 22612 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 27 Nov 2017 22:35:51 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017