coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check
by Richard Spiegel (Code Review) 27 Nov '17

27 Nov '17

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/22612 Change subject: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check ...................................................................... amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check Coverity reported pointer dev being dereferenced when assigning pointer conf, before checking dev for NULL. Pointer dev must be NULL checked before assigning a value to pointer conf. BUG=b:69669995 Change-Id: Ic435b1290c9d3667b890ecc29c5147a25c16b96f Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/soc/amd/stoneyridge/dimm_spd.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/22612/1 diff --git a/src/soc/amd/stoneyridge/dimm_spd.c b/src/soc/amd/stoneyridge/dimm_spd.c index d9f6355..26cd335 100644 --- a/src/soc/amd/stoneyridge/dimm_spd.c +++ b/src/soc/amd/stoneyridge/dimm_spd.c @@ -26,9 +26,12 @@ { uint8_t spd_address; DEVTREE_CONST struct device *dev = dev_find_slot(0, DCT_DEVFN); - DEVTREE_CONST struct soc_amd_stoneyridge_config *conf = dev->chip_info; + DEVTREE_CONST struct soc_amd_stoneyridge_config *conf; - if ((dev == 0) || (conf == 0)) + if (dev == 0) + return AGESA_ERROR; + conf = dev->chip_info; + if (conf == 0) return AGESA_ERROR; if (info->SocketId >= ARRAY_SIZE(conf->spd_addr_lookup)) return AGESA_ERROR; -- To view, visit https://review.coreboot.org/22612 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic435b1290c9d3667b890ecc29c5147a25c16b96f Gerrit-Change-Number: 22612 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: intel/bd82x6x: Refactor and complete IRQ routing
by build bot (Jenkins) (Code Review) 27 Nov '17

27 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22601 ) Change subject: intel/bd82x6x: Refactor and complete IRQ routing ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18686/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63815/ : SUCCESS -- To view, visit https://review.coreboot.org/22601 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7229aee3817f1f4979325a2abccbb3b99ad312f6 Gerrit-Change-Number: 22601 Gerrit-PatchSet: 8 Gerrit-Owner: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 27 Nov 2017 21:06:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/bd82x6x: Refactor and complete IRQ routing
by build bot (Jenkins) (Code Review) 27 Nov '17

27 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22601 ) Change subject: intel/bd82x6x: Refactor and complete IRQ routing ...................................................................... Patch Set 7: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63814/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18685/ : SUCCESS -- To view, visit https://review.coreboot.org/22601 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7229aee3817f1f4979325a2abccbb3b99ad312f6 Gerrit-Change-Number: 22601 Gerrit-PatchSet: 7 Gerrit-Owner: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 27 Nov 2017 20:59:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/bd82x6x: Refactor and complete IRQ routing
by build bot (Jenkins) (Code Review) 27 Nov '17

27 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22601 ) Change subject: intel/bd82x6x: Refactor and complete IRQ routing ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18684/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63813/ : SUCCESS -- To view, visit https://review.coreboot.org/22601 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7229aee3817f1f4979325a2abccbb3b99ad312f6 Gerrit-Change-Number: 22601 Gerrit-PatchSet: 6 Gerrit-Owner: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 27 Nov 2017 20:03:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/intelmetool: Add Skylake support
by Philipp Deppenwiese (Code Review) 27 Nov '17

27 Nov '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22599 ) Change subject: util/intelmetool: Add Skylake support ...................................................................... Patch Set 3: Code-Review-1 -- To view, visit https://review.coreboot.org/22599 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I920b1dac124bf0fc6d13fd9ceab12ecd575c1252 Gerrit-Change-Number: 22599 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 27 Nov 2017 19:35:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Update chromeos.fmd
by build bot (Jenkins) (Code Review) 27 Nov '17

27 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22579 ) Change subject: mainboard/google/kahlee: Update chromeos.fmd ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63812/ : SUCCESS -- To view, visit https://review.coreboot.org/22579 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e41a0aa6bd4b29b8014c6559126a29cd7ed45d8 Gerrit-Change-Number: 22579 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 27 Nov 2017 18:41:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/hp/8460p: Add TPM support
by build bot (Jenkins) (Code Review) 27 Nov '17

27 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22602 ) Change subject: mb/hp/8460p: Add TPM support ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63811/ : SUCCESS -- To view, visit https://review.coreboot.org/22602 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b845928954d203d1c3608b6704fedbd590e1fa9 Gerrit-Change-Number: 22602 Gerrit-PatchSet: 7 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 27 Nov 2017 17:16:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/hp/8460p: Add TPM support
by build bot (Jenkins) (Code Review) 27 Nov '17

27 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22602 ) Change subject: mb/hp/8460p: Add TPM support ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63810/ : SUCCESS -- To view, visit https://review.coreboot.org/22602 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b845928954d203d1c3608b6704fedbd590e1fa9 Gerrit-Change-Number: 22602 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 27 Nov 2017 16:04:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/hp/8460p: Add TPM support
by build bot (Jenkins) (Code Review) 27 Nov '17

27 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22602 ) Change subject: mb/hp/8460p: Add TPM support ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63809/ : SUCCESS -- To view, visit https://review.coreboot.org/22602 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b845928954d203d1c3608b6704fedbd590e1fa9 Gerrit-Change-Number: 22602 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 27 Nov 2017 15:52:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/hp/8460p: Add TPM support
by build bot (Jenkins) (Code Review) 27 Nov '17

27 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22602 ) Change subject: mb/hp/8460p: Add TPM support ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18683/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63808/ : SUCCESS -- To view, visit https://review.coreboot.org/22602 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b845928954d203d1c3608b6704fedbd590e1fa9 Gerrit-Change-Number: 22602 Gerrit-PatchSet: 4 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 27 Nov 2017 13:23:41 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017