coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: chromeec: Notify CREC device of wakeup events
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22625 ) Change subject: chromeec: Notify CREC device of wakeup events ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18745/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63877/ : SUCCESS -- To view, visit https://review.coreboot.org/22625 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I723f7f4e4c99e7a5b57c6296da66cf30cd413c27 Gerrit-Change-Number: 22625 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 22:48:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: chromeec: Notify CREC device of wakeup events
by Furquan Shaikh (Code Review) 28 Nov '17

28 Nov '17

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22625 Change subject: chromeec: Notify CREC device of wakeup events ...................................................................... chromeec: Notify CREC device of wakeup events Whenever there is a new EC event that could be wake-capable, notify CREC device of this using notification value 0x2 i.e. device wake. This allows Linux kernel to track active_count value correctly for CREC device. BUG=b:69118395 BRANCH=None TEST=Verified on Soraka: 1. Put device into suspend 2. Wakeup using mode change/lid open 3. Check that the active_count for GOOG0004 has increased (cat wakeup_sources | grep GOOG0004) Change-Id: I723f7f4e4c99e7a5b57c6296da66cf30cd413c27 Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/ec/google/chromeec/acpi/ec.asl 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/22625/1 diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index 0d05110..d295a8d 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -212,6 +212,7 @@ { Store ("EC: LID OPEN", Debug) Store (LIDS, \LIDS) + Notify (CREC, 0x2) #ifdef EC_ENABLE_LID_SWITCH Notify (LID0, 0x80) #endif @@ -297,6 +298,7 @@ Method (_Q0D, 0, NotSerialized) { Store ("EC: KEY PRESSED", Debug) + Notify (CREC, 0x2) } // Thermal Shutdown Imminent @@ -354,17 +356,18 @@ Notify (CREC, 0x80) } -#ifdef EC_ENABLE_TABLET_EVENT // TABLET mode switch Event Method (_Q1D, 0, NotSerialized) { Store ("EC: TABLET mode switch Event", Debug) + Notify (CREC, 0x2) +#ifdef EC_ENABLE_TABLET_EVENT If (CondRefOf (\_SB.DPTF.TPET)) { \_SB.DPTF.TPET() } Notify (TBMC, 0x80) - } #endif + } /* * Dynamic Platform Thermal Framework support -- To view, visit https://review.coreboot.org/22625 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I723f7f4e4c99e7a5b57c6296da66cf30cd413c27 Gerrit-Change-Number: 22625 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: google/fizz: Set BJ max current and voltage
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22623 ) Change subject: google/fizz: Set BJ max current and voltage ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18744/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63876/ : SUCCESS -- To view, visit https://review.coreboot.org/22623 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifebee09096e0935cc7d3e53920a251b0496d3c55 Gerrit-Change-Number: 22623 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 22:39:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: chromeec: Add command to override charger limit
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22624 ) Change subject: chromeec: Add command to override charger limit ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18743/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63875/ : SUCCESS -- To view, visit https://review.coreboot.org/22624 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c6fc54e519ce13e3db82ee2cecaa96c6eb42d8a Gerrit-Change-Number: 22624 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 22:34:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: chromeec: Add command to override charger limit
by Daisuke Nojiri (Code Review) 28 Nov '17

28 Nov '17

Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/22624 Change subject: chromeec: Add command to override charger limit ...................................................................... chromeec: Add command to override charger limit This patch adds EC_CMD_OVERRIDE_DEDICATED_CHARGER_LIMIT, which overrides the max input current and voltage when a barrel jack adapter supplies power. BUG=b:64442692 BRANCH=none TEST=Boot Fizz. Use chgsup console command to verify the max current and voltage are set as expected. Change-Id: I8c6fc54e519ce13e3db82ee2cecaa96c6eb42d8a Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h M src/ec/google/chromeec/ec_commands.h 3 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/22624/1 diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index b44fffe..588d115 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -638,6 +638,26 @@ return 0; } +int google_chromeec_override_dedicated_charger_limit(u16 current_lim, + u16 voltage_lim) +{ + struct ec_params_dedicated_charger_limit p = { + .current_lim = current_lim, + .voltage_lim = voltage_lim, + }; + struct chromeec_command cmd = { + .cmd_code = EC_CMD_OVERRIDE_DEDICATED_CHARGER_LIMIT, + .cmd_version = 0, + .cmd_data_in = &p, + .cmd_size_in = sizeof(p), + .cmd_data_out = NULL, + .cmd_size_out = 0, + .cmd_dev_index = 0, + }; + + return google_chromeec_command(&cmd); +} + int google_chromeec_set_usb_pd_role(u8 port, enum usb_pd_control_role role) { struct ec_params_usb_pd_control req = { diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index 0b6f880..e1bf6c8 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -91,6 +91,16 @@ int google_chromeec_get_usb_pd_power_info(enum usb_chg_type *type, u32 *max_watts); +/* + * Set max current and voltage of a dedicated charger. + * + * @param current_lim Max current in mA + * @param voltage_lim Max voltage in mV + * @return non-zero for error, otherwise 0. + */ +int google_chromeec_override_dedicated_charger_limit(u16 current_lim, + u16 voltage_lim); + /* internal structure to send a command to the EC and wait for response. */ struct chromeec_command { uint16_t cmd_code; /* command code in, status out */ diff --git a/src/ec/google/chromeec/ec_commands.h b/src/ec/google/chromeec/ec_commands.h index aa63aa7..57e48e7 100644 --- a/src/ec/google/chromeec/ec_commands.h +++ b/src/ec/google/chromeec/ec_commands.h @@ -3533,6 +3533,16 @@ #define EC_POWER_LIMIT_NONE 0xffff +/* + * Set maximum voltage & current of a dedicated charge port + */ +#define EC_CMD_OVERRIDE_DEDICATED_CHARGER_LIMIT 0x00A3 + +struct __ec_align2 ec_params_dedicated_charger_limit { + uint16_t current_lim; /* in mA */ + uint16_t voltage_lim; /* in mV */ +}; + /*****************************************************************************/ /* Hibernate/Deep Sleep Commands */ -- To view, visit https://review.coreboot.org/22624 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8c6fc54e519ce13e3db82ee2cecaa96c6eb42d8a Gerrit-Change-Number: 22624 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Change in coreboot[master]: google/fizz: Set BJ max current and voltage
by Daisuke Nojiri (Code Review) 28 Nov '17

28 Nov '17

Daisuke Nojiri has uploaded a new patch set (#2). ( https://review.coreboot.org/22623 ) Change subject: google/fizz: Set BJ max current and voltage ...................................................................... google/fizz: Set BJ max current and voltage This patch makes coreboot set the max current and voltage for barrel jack adapters. BUG=b:64442692 BRANCH=none TEST=Boot Fizz. Use chgsup console command to verify the max current and voltage are set as expected. Change-Id: Ifebee09096e0935cc7d3e53920a251b0496d3c55 Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M src/mainboard/google/fizz/mainboard.c 1 file changed, 97 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/22623/2 -- To view, visit https://review.coreboot.org/22623 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifebee09096e0935cc7d3e53920a251b0496d3c55 Gerrit-Change-Number: 22623 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Change in coreboot[master]: google/fizz: Set BJ max current and voltage
by Daisuke Nojiri (Code Review) 28 Nov '17

28 Nov '17

Daisuke Nojiri has restored this change. ( https://review.coreboot.org/22623 ) Change subject: google/fizz: Set BJ max current and voltage ...................................................................... Restored -- To view, visit https://review.coreboot.org/22623 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: restore Gerrit-Change-Id: Ifebee09096e0935cc7d3e53920a251b0496d3c55 Gerrit-Change-Number: 22623 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Change in coreboot[master]: google/kahlee: Rename board_id to memory_sku
by build bot (Jenkins) (Code Review) 28 Nov '17

28 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22561 ) Change subject: google/kahlee: Rename board_id to memory_sku ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18737/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63869/ : SUCCESS -- To view, visit https://review.coreboot.org/22561 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84bacead3daf829c97f595c4c11a243953243c29 Gerrit-Change-Number: 22561 Gerrit-PatchSet: 3 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Nov 2017 22:13:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/fizz: Set BJ max current and voltage
by Daisuke Nojiri (Code Review) 28 Nov '17

28 Nov '17

Daisuke Nojiri has abandoned this change. ( https://review.coreboot.org/22623 ) Change subject: google/fizz: Set BJ max current and voltage ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/22623 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ifebee09096e0935cc7d3e53920a251b0496d3c55 Gerrit-Change-Number: 22623 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Change in coreboot[master]: google/fizz: Set BJ max current and voltage
by Daisuke Nojiri (Code Review) 28 Nov '17

28 Nov '17

Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/22623 Change subject: google/fizz: Set BJ max current and voltage ...................................................................... google/fizz: Set BJ max current and voltage This patch makes coreboot set the max current and voltage for barrel jack adapters. BUG=b:64442692 BRANCH=none TEST=Boot Fizz. Use chgsup console command to verify the max current and voltage are set as expected. Change-Id: Ifebee09096e0935cc7d3e53920a251b0496d3c55 Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h M src/ec/google/chromeec/ec_commands.h M src/mainboard/google/fizz/mainboard.c 4 files changed, 137 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/22623/1 diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index b44fffe..588d115 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -638,6 +638,26 @@ return 0; } +int google_chromeec_override_dedicated_charger_limit(u16 current_lim, + u16 voltage_lim) +{ + struct ec_params_dedicated_charger_limit p = { + .current_lim = current_lim, + .voltage_lim = voltage_lim, + }; + struct chromeec_command cmd = { + .cmd_code = EC_CMD_OVERRIDE_DEDICATED_CHARGER_LIMIT, + .cmd_version = 0, + .cmd_data_in = &p, + .cmd_size_in = sizeof(p), + .cmd_data_out = NULL, + .cmd_size_out = 0, + .cmd_dev_index = 0, + }; + + return google_chromeec_command(&cmd); +} + int google_chromeec_set_usb_pd_role(u8 port, enum usb_pd_control_role role) { struct ec_params_usb_pd_control req = { diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index 0b6f880..e1bf6c8 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -91,6 +91,16 @@ int google_chromeec_get_usb_pd_power_info(enum usb_chg_type *type, u32 *max_watts); +/* + * Set max current and voltage of a dedicated charger. + * + * @param current_lim Max current in mA + * @param voltage_lim Max voltage in mV + * @return non-zero for error, otherwise 0. + */ +int google_chromeec_override_dedicated_charger_limit(u16 current_lim, + u16 voltage_lim); + /* internal structure to send a command to the EC and wait for response. */ struct chromeec_command { uint16_t cmd_code; /* command code in, status out */ diff --git a/src/ec/google/chromeec/ec_commands.h b/src/ec/google/chromeec/ec_commands.h index aa63aa7..57e48e7 100644 --- a/src/ec/google/chromeec/ec_commands.h +++ b/src/ec/google/chromeec/ec_commands.h @@ -3533,6 +3533,16 @@ #define EC_POWER_LIMIT_NONE 0xffff +/* + * Set maximum voltage & current of a dedicated charge port + */ +#define EC_CMD_OVERRIDE_DEDICATED_CHARGER_LIMIT 0x00A3 + +struct __ec_align2 ec_params_dedicated_charger_limit { + uint16_t current_lim; /* in mA */ + uint16_t voltage_lim; /* in mV */ +}; + /*****************************************************************************/ /* Hibernate/Deep Sleep Commands */ diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index ce60283..56376fb 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -37,8 +37,69 @@ */ #define GET_TYPEC_PL2(w) (9 * (w) / 10) +#define OEM_ID_COUNT 5 +#define SKU_ID_COUNT 7 + +/* List of BJ adapters shipped with Fizz or its variants */ +enum bj_adapter { + BJ_UNKNOWN, + BJ_PPP012C_S, + BJ_ADP_65HB_HCE, + BJ_PA_1650_30, + BJ_PA_1900_92, + BJ_COUNT, +}; + +/* BJ adapter specs */ +static const struct { + uint16_t current_lim; /* in mA */ + uint16_t voltage_lim; /* in mV */ +} bj_adapters[] = { + [BJ_PPP012C_S] = { .current_lim = 4620, .voltage_lim = 19500 }, + [BJ_ADP_65HB_HCE] = { .current_lim = 3330, .voltage_lim = 19500 }, + [BJ_PA_1650_30] = { .current_lim = 3420, .voltage_lim = 19000 }, + [BJ_PA_1900_92] = { .current_lim = 4740, .voltage_lim = 19000 }, +}; + +/* + * The table showing which device is shipped with which BJ adapter. + * + * | SKU0 SKU1 ... + * OEM0 | AdapterX AdapterZ ... + * OEM1 | AdapterY ... + * ... | + */ +static const enum bj_adapter bj_adapter_table[OEM_ID_COUNT][SKU_ID_COUNT] = { + { BJ_PPP012C_S, BJ_ADP_65HB_HCE, BJ_PA_1650_30, BJ_PA_1900_92, + BJ_PA_1900_92, BJ_PA_1900_92, BJ_UNKNOWN }, + { BJ_PPP012C_S, BJ_ADP_65HB_HCE, BJ_PA_1650_30, BJ_PA_1900_92, + BJ_PA_1900_92, BJ_PA_1900_92, BJ_UNKNOWN }, + { BJ_PPP012C_S, BJ_ADP_65HB_HCE, BJ_PA_1650_30, BJ_PA_1900_92, + BJ_PA_1900_92, BJ_PA_1900_92, BJ_UNKNOWN }, + { BJ_PPP012C_S, BJ_ADP_65HB_HCE, BJ_PA_1650_30, BJ_PA_1900_92, + BJ_PA_1900_92, BJ_PA_1900_92, BJ_UNKNOWN }, + { BJ_PPP012C_S, BJ_ADP_65HB_HCE, BJ_PA_1650_30, BJ_PA_1900_92, + BJ_PA_1900_92, BJ_PA_1900_92, BJ_UNKNOWN }, +}; + static const char *oem_id = "GOOGLE"; static const char *oem_table_id = "FIZZ"; + + +static uint8_t board_sku_id(void) +{ + static int id = -1; + const gpio_t sku_id_gpios[] = { + GPIO_SKU_ID0, + GPIO_SKU_ID1, + GPIO_SKU_ID2, + GPIO_SKU_ID3, + }; + if (id < 0) + id = gpio_base2_value(sku_id_gpios, + ARRAY_SIZE(sku_id_gpios)); + return id; +} /* * mainboard_get_pl2 @@ -50,25 +111,16 @@ */ static u32 mainboard_get_pl2(void) { - const gpio_t sku_id_gpios[] = { - GPIO_SKU_ID0, - GPIO_SKU_ID1, - GPIO_SKU_ID2, - GPIO_SKU_ID3, - }; enum usb_chg_type type; u32 watts; int rv = google_chromeec_get_usb_pd_power_info(&type, &watts); - int sku_id; /* If we can't get charger info or not PD charger, assume barrel jack */ if (rv != 0 || type != USB_CHG_TYPE_PD) { /* using the barrel jack, get PL2 based on sku id */ watts = FIZZ_PL2_OTHERS; - sku_id = gpio_base2_value(sku_id_gpios, - ARRAY_SIZE(sku_id_gpios)); - if (sku_id == FIZZ_SKU_ID_I7_U42) + if (board_sku_id() == FIZZ_SKU_ID_I7_U42) watts = FIZZ_PL2_I7_U42; } else watts = GET_TYPEC_PL2(watts); @@ -78,16 +130,15 @@ static uint8_t board_oem_id(void) { - static int board_oem_id = -1; + static int id = -1; const gpio_t oem_id_gpios[] = { GPIO_OEM_ID1, GPIO_OEM_ID2, GPIO_OEM_ID3, }; - if (board_oem_id < 0) - board_oem_id = gpio_base2_value(oem_id_gpios, - ARRAY_SIZE(oem_id_gpios)); - return board_oem_id; + if (id < 0) + id = gpio_base2_value(oem_id_gpios, ARRAY_SIZE(oem_id_gpios)); + return id; } const char *smbios_mainboard_sku(void) @@ -130,6 +181,35 @@ return end_addr; } +/* + * Set max current and voltage for a barrel jack adapter based on {OEM, SKU}. + * If this fails, the limit will remain unchanged = default values, which make + * the system run under safe but under-rated power. + * If a BJ adapter isn't plugged, this is a no-op. + */ +static void set_bj_adapter_limit(void) +{ + uint8_t oem = board_oem_id(); + uint8_t sku = board_sku_id(); + enum bj_adapter bj; + + if (oem >= OEM_ID_COUNT || sku >= SKU_ID_COUNT) { + printk(BIOS_ERR, "Unrecognized OEM or SKU: %d/%d\n", oem, sku); + return; + } + + bj = bj_adapter_table[oem][sku]; + if (bj <= BJ_UNKNOWN || BJ_COUNT <= bj) { + printk(BIOS_ERR, "Invalid BJ adapter ID: %d\n", bj); + return; + } + printk(BIOS_INFO, "Setting BJ limit: %dmA/%dmV\n", + bj_adapters[bj].current_lim, bj_adapters[bj].voltage_lim); + google_chromeec_override_dedicated_charger_limit( + bj_adapters[bj].current_lim, + bj_adapters[bj].voltage_lim); +} + static void mainboard_enable(device_t dev) { device_t root = SA_DEV_ROOT; @@ -137,6 +217,8 @@ conf->tdp_pl2_override = mainboard_get_pl2(); + set_bj_adapter_limit(); + dev->ops->init = mainboard_init; dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator; dev->ops->write_acpi_tables = mainboard_write_acpi_tables; -- To view, visit https://review.coreboot.org/22623 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifebee09096e0935cc7d3e53920a251b0496d3c55 Gerrit-Change-Number: 22623 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017