Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15477
-gerrit
commit 1eefff4d9417f65dd2ce3aa8911c5eb1e19b2526
Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Date: Mon Jun 27 13:09:56 2016 +0300
ACPI S3: Drop too early resume backup
No longer needed as low memory backup is implemented as part of
the ramstage loader, when the actual requirement of the ramstage
to load is known.
Change-Id: I5f5ad94bae2afef915927b9737c79431b6f75f22
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
src/arch/x86/acpi_s3.c | 17 -----------------
src/arch/x86/include/arch/acpi.h | 2 --
2 files changed, 19 deletions(-)
diff --git a/src/arch/x86/acpi_s3.c b/src/arch/x86/acpi_s3.c
index 1892731..1b7976d 100644
--- a/src/arch/x86/acpi_s3.c
+++ b/src/arch/x86/acpi_s3.c
@@ -145,23 +145,6 @@ void backup_ramstage_section(uintptr_t base, size_t size)
backup_mem->valid = 1;
}
-/* Make backup of low-memory region, relying on the base and size
- * of the ramstage that was loaded before entry to ACPI S3.
- *
- * DEPRECATED
- */
-void acpi_prepare_for_resume(void)
-{
- struct resume_backup *backup_mem = cbmem_find(CBMEM_ID_RESUME);
- if (!backup_mem)
- return;
-
- /* Back up the OS-controlled memory where ramstage will be loaded. */
- memcpy((void*)(uintptr_t)backup_mem->cbmem,
- (void*)(uintptr_t)backup_mem->lowmem, (size_t)backup_mem->size);
- backup_mem->valid = 1;
-}
-
/* Let's prepare the ACPI S3 Resume area now already, so we can rely on
* it being there during reboot time. If this fails, ACPI resume will
* be disabled. We assume that ramstage does not change while in suspend,
diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h
index 0b04f56..89041cf 100644
--- a/src/arch/x86/include/arch/acpi.h
+++ b/src/arch/x86/include/arch/acpi.h
@@ -695,13 +695,11 @@ int acpi_is_wakeup(void);
int acpi_is_wakeup_s3(void);
int acpi_is_wakeup_s4(void);
#endif
-void acpi_prepare_for_resume(void);
#else
static inline int acpi_is_wakeup(void) { return 0; }
static inline int acpi_is_wakeup_s3(void) { return 0; }
static inline int acpi_is_wakeup_s4(void) { return 0; }
-static inline void acpi_prepare_for_resume(void) { }
#endif
static inline uintptr_t acpi_align_current(uintptr_t current)
Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/2562
-gerrit
commit 9b978c883c62ce3dd6d359de39d0c3804d657de7
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Fri Mar 1 13:05:04 2013 +0100
AMD CIMx SB800: late.c: Use variable `device` from for loop condition
Use the variable `device` instead of `dev` in the predicate of
the if condition, as `dev` is not changed in the for loop.
The for loop was added in the following commit.
commit 8fed77ae4c46122859d0718678e54546e126d4bc
Author: Scott Duplichan <scott(a)notabs.org>
Date: Sat Jun 18 10:46:45 2011 -0500
ASRock E350M1: Configure SB800 GPP ports to support onboard pcie nic
Reviewed-on: http://review.coreboot.org/44
The assumption that the devices are ordered in the tree seem to
hold in this case (although it is not ensured) and therefore at
least with the ASRock E350M1 no (visible) change is experienced as
the children are all of type `DEVICE_PATH_PCI`.
Change-Id: Iaa2fa13305dbe924965d27680cd02fe30c2f58a5
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
src/southbridge/amd/cimx/sb800/late.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/southbridge/amd/cimx/sb800/late.c b/src/southbridge/amd/cimx/sb800/late.c
index fa47a96..96cdf9a 100644
--- a/src/southbridge/amd/cimx/sb800/late.c
+++ b/src/southbridge/amd/cimx/sb800/late.c
@@ -413,9 +413,8 @@ static void sb800_enable(device_t dev)
case (0x15 << 3) | 0: /* 0:15:0 PCIe PortA */
{
device_t device;
- for (device = dev; device; device = device->next) {
- if (dev->path.type != DEVICE_PATH_PCI) continue;
- if ((device->path.pci.devfn & ~7) != PCI_DEVFN(0x15,0)) break;
+ for (device = dev; device; device = device->sibling) {
+ if ((device->path.pci.devfn & ~3) != PCI_DEVFN(0x15,0)) break;
sb_config->PORTCONFIG[device->path.pci.devfn & 3].PortCfg.PortPresent = device->enabled;
}
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17808
-gerrit
commit e18e0684b48a99f42c1fecaa1d9aa67998204403
Author: Martin Roth <martinroth(a)google.com>
Date: Mon Dec 12 16:48:08 2016 -0700
[WIP] Makefile.inc: Give an error if CBFS_SIZE > ROM_SIZE
Change-Id: I84d2185f222617f88147eaf0ffb14ad67089860e
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
Makefile.inc | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Makefile.inc b/Makefile.inc
index c5ce30f..8f8706a 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -793,6 +793,9 @@ FMAP_FMAP_SIZE := 0x100
# position and size of CBFS, relative to BIOS_BASE
FMAP_CBFS_BASE := $(FMAP_FMAP_SIZE)
FMAP_CBFS_SIZE := $(call int-subtract, $(FMAP_BIOS_SIZE) $(FMAP_FMAP_SIZE))
+ifeq ($(findstring -,$(FMAP_BIOS_BASE)),-)
+$(error ERROR: CBFS_SIZE is greater than ROM_SIZE: $(CONFIG_CBFS_SIZE) > $(CONFIG_ROM_SIZE) )
+endif
else # ifeq ($(CONFIG_ARCH_X86),y)
DEFAULT_FLASHMAP:=$(top)/util/cbfstool/default.fmd
# entire flash