Paul Kocialkowski (contact(a)paulk.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17930
-gerrit
commit f6a2e5055c65a43aded0fb3877de299b5f49ea60
Author: Paul Kocialkowski <contact(a)paulk.fr>
Date: Mon Dec 19 20:23:44 2016 +0100
libpayload: Enable USB HID in veyron configuration
This enables USB HID support in the veyron config, since it seems to
work correctly and is needed for interaction with depthcharge on devices
without an embedded keyboard (such as veyron_jerry).
Change-Id: Icae829e3a132005df17bcb6f7e6f8a190912576d
Signed-off-by: Paul Kocialkowski <contact(a)paulk.fr>
---
payloads/libpayload/configs/config.veyron | 1 -
1 file changed, 1 deletion(-)
diff --git a/payloads/libpayload/configs/config.veyron b/payloads/libpayload/configs/config.veyron
index e80535c..b643e92 100644
--- a/payloads/libpayload/configs/config.veyron
+++ b/payloads/libpayload/configs/config.veyron
@@ -4,4 +4,3 @@ CONFIG_LP_8250_SERIAL_CONSOLE=y
CONFIG_LP_TIMER_RK3288=y
CONFIG_LP_USB_EHCI=y
CONFIG_LP_USB_DWC2=y
-# CONFIG_LP_USB_HID is not set
Paul Kocialkowski (contact(a)paulk.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17929
-gerrit
commit a7b719c5eb657ec541575c9ab05888d888205ff1
Author: Paul Kocialkowski <contact(a)paulk.fr>
Date: Mon Dec 19 19:22:39 2016 +0100
libpayload: Get current tick from high register in generic timer
This fixes the generic timer driver to get the current tick from the
high register, so that comparison with the high count value (obtained
previously from the same register) has a chance to succeed.
Change-Id: I5ce02bfa15a91ad34641b8e24813a5b7ca790ec3
Signed-off-by: Paul Kocialkowski <contact(a)paulk.fr>
---
payloads/libpayload/drivers/timer/generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/payloads/libpayload/drivers/timer/generic.c b/payloads/libpayload/drivers/timer/generic.c
index 4c06618..ac26f40 100644
--- a/payloads/libpayload/drivers/timer/generic.c
+++ b/payloads/libpayload/drivers/timer/generic.c
@@ -53,7 +53,7 @@ uint64_t timer_raw_value(void)
do {
count_h = readl(phys_to_virt(CONFIG_LP_TIMER_GENERIC_HIGH_REG));
count_l = readl(phys_to_virt(CONFIG_LP_TIMER_GENERIC_REG));
- cur_tick = readl(phys_to_virt(CONFIG_LP_TIMER_GENERIC_REG));
+ cur_tick = readl(phys_to_virt(CONFIG_LP_TIMER_GENERIC_HIGH_REG));
} while (cur_tick != count_h);
return (cur_tick << 32) + count_l;
Paul Kocialkowski (contact(a)paulk.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17928
-gerrit
commit 4ae60477ae2a27c0be3a0503d11a602c5422e9bc
Author: Paul Kocialkowski <contact(a)paulk.fr>
Date: Mon Dec 19 18:03:23 2016 +0100
libpayload: Update ARM CrOS devices configuration
This updates the configuration for ARM CrOS devices (nyans and veyrons)
by using the CHROMEOS Kconfig option, thus reducing the number of
options to select. It also brings proper serial console support.
Change-Id: Iffc84c44a1d339c5bb575fbaffc40bc2d56bb6cf
Signed-off-by: Paul Kocialkowski <contact(a)paulk.fr>
---
payloads/libpayload/configs/config.nyan | 10 +++-------
payloads/libpayload/configs/config.veyron | 10 +++-------
2 files changed, 6 insertions(+), 14 deletions(-)
diff --git a/payloads/libpayload/configs/config.nyan b/payloads/libpayload/configs/config.nyan
index 6e593e5..caad2b6 100644
--- a/payloads/libpayload/configs/config.nyan
+++ b/payloads/libpayload/configs/config.nyan
@@ -1,10 +1,6 @@
-CONFIG_LP_GPL=y
+CONFIG_LP_CHROMEOS=y
CONFIG_LP_ARCH_ARM=y
-# CONFIG_LP_CURSES is not set
-CONFIG_LP_SKIP_CONSOLE_INIT=y
-CONFIG_LP_COREBOOT_VIDEO_CONSOLE=y
-# CONFIG_LP_STORAGE is not set
+CONFIG_LP_8250_SERIAL_CONSOLE=y
CONFIG_LP_TIMER_TEGRA_1US=y
-# CONFIG_LP_USB_OHCI is not set
-# CONFIG_LP_USB_XHCI is not set
+CONFIG_LP_USB_EHCI=y
CONFIG_LP_USB_EHCI_HOSTPC_ROOT_HUB_TT=y
diff --git a/payloads/libpayload/configs/config.veyron b/payloads/libpayload/configs/config.veyron
index 793907f..e80535c 100644
--- a/payloads/libpayload/configs/config.veyron
+++ b/payloads/libpayload/configs/config.veyron
@@ -1,11 +1,7 @@
-CONFIG_LP_GPL=y
+CONFIG_LP_CHROMEOS=y
CONFIG_LP_ARCH_ARM=y
-# CONFIG_LP_CURSES is not set
-CONFIG_LP_SKIP_CONSOLE_INIT=y
-CONFIG_LP_COREBOOT_VIDEO_CONSOLE=y
-# CONFIG_LP_STORAGE is not set
-CONFIG_LP_TIMER_RK=y
-CONFIG_LP_USB=y
+CONFIG_LP_8250_SERIAL_CONSOLE=y
+CONFIG_LP_TIMER_RK3288=y
CONFIG_LP_USB_EHCI=y
CONFIG_LP_USB_DWC2=y
# CONFIG_LP_USB_HID is not set
Sumeet R Pawnikar (sumeet.r.pawnikar(a)intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17889
-gerrit
commit c444d3dba34aea72607237878f26d0f9ea3544c8
Author: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com>
Date: Tue Dec 20 22:30:21 2016 +0530
soc/intel/skylake: set TCC activation by BSP only
TCC activation functinality has package scope. It was set
for all CPU in the system which is unnecessary.
In this patch TCC activation is being set by the BSP only.
BUG=chrome-os-partner:59397
BRANCH=None.
TEST=Built for skylake platform and verified the TCC activation
value before and after S3.
Change-Id: Iacf64cbc40871bbec3bede65f196bf292e0149a6
Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com>
---
src/soc/intel/skylake/cpu.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c
index 3ec8d2c..e8616f0 100644
--- a/src/soc/intel/skylake/cpu.c
+++ b/src/soc/intel/skylake/cpu.c
@@ -197,7 +197,7 @@ static void configure_thermal_target(void)
config_t *conf = dev->chip_info;
msr_t msr;
- /* Set TCC activaiton offset if supported */
+ /* Set TCC activation offset if supported */
msr = rdmsr(MSR_PLATFORM_INFO);
if ((msr.lo & (1 << 30)) && conf->tcc_offset) {
msr = rdmsr(MSR_TEMPERATURE_TARGET);
@@ -366,9 +366,6 @@ static void cpu_core_init(device_t cpu)
/* Configure Intel Speed Shift */
configure_isst();
- /* Thermal throttle activation offset */
- configure_thermal_target();
-
/* Enable Direct Cache Access */
configure_dca_cap();
@@ -484,6 +481,9 @@ void soc_init_cpus(device_t dev)
if (mp_init_with_smm(cpu_bus, &mp_ops)) {
printk(BIOS_ERR, "MP initialization failure.\n");
}
+
+ /* Thermal throttle activation offset */
+ configure_thermal_target();
}
int soc_skip_ucode_update(u32 current_patch_id, u32 new_patch_id)
Sumeet R Pawnikar (sumeet.r.pawnikar(a)intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17921
-gerrit
commit 77059ebbfbdaa2a63f36cc5be9f677b4a8ff1cd5
Author: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com>
Date: Tue Dec 20 22:33:56 2016 +0530
mainboard/google/chell: Set TCC activation offset to 10 degree C
With the default TCC activation offset value as 0 and Tjmax
temperature value as 100 degree C, Pcode firmware starts taking
prochot action at 100 degree C [Tjmax-Offset].
But before Pcode firmware starts prochot action at 100 degree C,
device is getting shutdown at 99 degree C due to DPTF critical
CPU temperature.
This patch sets TCC activation offset value to 10 degree C for
thermal throttle action and to prevent this kind of shutdown.
BUG=chrome-os-partner:59397
BRANCH=None.
TEST=Built, booted on skylake and verified target offset value.
Change-Id: I0811ef481a4b3ce4bd6ef24f2aa8160f44f9c990
Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com>
---
src/mainboard/google/chell/devicetree.cb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mainboard/google/chell/devicetree.cb b/src/mainboard/google/chell/devicetree.cb
index 34250d3..2ffaec6 100644
--- a/src/mainboard/google/chell/devicetree.cb
+++ b/src/mainboard/google/chell/devicetree.cb
@@ -183,6 +183,8 @@ chip soc/intel/skylake
# PL2 override 15W
register "tdp_pl2_override" = "15"
+ register "tcc_offset" = "10" # TCC of 90C
+
# Send an extra VR mailbox command for the supported MPS IMVP8 model
register "SendVrMbxCmd" = "1"
Sumeet R Pawnikar (sumeet.r.pawnikar(a)intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17889
-gerrit
commit c725fb2def5fbcd2bbaec5557e7ce2d8aecca8b4
Author: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com>
Date: Tue Dec 20 22:30:21 2016 +0530
skylake: TCC activation functionality set by the BSP
TCC activation functinality has package scope. It was set
for all CPU in the system which is unnecessary.
In this patch TCC activation is being set by the BSP only.
BUG=chrome-os-partner:59397
BRANCH=None.
TEST=Built for skylake platform and verified the TCC activation
value before and after S3.
Change-Id: Iacf64cbc40871bbec3bede65f196bf292e0149a6
Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com>
---
src/soc/intel/skylake/cpu.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c
index 3ec8d2c..e8616f0 100644
--- a/src/soc/intel/skylake/cpu.c
+++ b/src/soc/intel/skylake/cpu.c
@@ -197,7 +197,7 @@ static void configure_thermal_target(void)
config_t *conf = dev->chip_info;
msr_t msr;
- /* Set TCC activaiton offset if supported */
+ /* Set TCC activation offset if supported */
msr = rdmsr(MSR_PLATFORM_INFO);
if ((msr.lo & (1 << 30)) && conf->tcc_offset) {
msr = rdmsr(MSR_TEMPERATURE_TARGET);
@@ -366,9 +366,6 @@ static void cpu_core_init(device_t cpu)
/* Configure Intel Speed Shift */
configure_isst();
- /* Thermal throttle activation offset */
- configure_thermal_target();
-
/* Enable Direct Cache Access */
configure_dca_cap();
@@ -484,6 +481,9 @@ void soc_init_cpus(device_t dev)
if (mp_init_with_smm(cpu_bus, &mp_ops)) {
printk(BIOS_ERR, "MP initialization failure.\n");
}
+
+ /* Thermal throttle activation offset */
+ configure_thermal_target();
}
int soc_skip_ucode_update(u32 current_patch_id, u32 new_patch_id)