Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17940
-gerrit
commit 1d589da5869fa805c08e5f2f4cfc6cf52d93f067
Author: Martin Roth <martinroth(a)google.com>
Date: Thu Dec 22 10:29:20 2016 -0700
Microcode: Show a useful warning when microcode bins are missing
Because the binary repo is disabled by default, we get frequent
questions about why the build failed, relating to microcode in the
binary repository.
- Show an error saying that the file is missing instead of the typical
make error of no rule to build the file.
- Show a note encouraging users to try enabling the binary repo if it's
not enabled.
Change-Id: If4148c18cfb781ed2932bd2ae4a289b621afdebf
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
src/cpu/Makefile.inc | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/src/cpu/Makefile.inc b/src/cpu/Makefile.inc
index 4ac6812..0aec4ef 100644
--- a/src/cpu/Makefile.inc
+++ b/src/cpu/Makefile.inc
@@ -37,7 +37,19 @@ endif
# updates are wrapped in a container, like AMD's microcode update container. If
# there is only one microcode binary (i.e. one container), then we don't have
# this issue, and this rule will continue to work.
-$(obj)/cpu_microcode_blob.bin: $$(cpu_microcode_bins)
+$(obj)/cpu_microcode_blob.bin:
+ for bin in $(cpu_microcode_bins); do \
+ if [ ! -f "$$bin" ]; then \
+ echo "Microcode error: $$bin does not exist"; \
+ NO_MICROCODE_FILE=1; \
+ fi; \
+ done; \
+ if [ -n "$$NO_MICROCODE_FILE" ]; then \
+ if [ -z "$(CONFIG_USE_BLOBS)" ] && [ -n "$(CONFIG_CPU_MICROCODE_CBFS_GENERATE)" ]; then \
+ echo "Try enabling binary-only repository in Kconfig 'General setup' menu."; \
+ fi; \
+ false; \
+ fi
@printf " MICROCODE $(subst $(obj)/,,$(@))\n"
@echo $(cpu_microcode_bins)
cat /dev/null $+ > $@
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17939
-gerrit
commit ef210c35f91b3101e528e762a78fa2e01b77ea3d
Author: Martin Roth <martinroth(a)google.com>
Date: Thu Dec 22 10:21:11 2016 -0700
Kconfig: Remind users to delete .config when switching boards
Because Kconfig default values *ONLY* get set when they are first
configured, if you switch mainboards with an existing .config,
the values will not be set as expected for the new board.
This seems to confuse most users, so put a warning in a visible
location to let them know.
Change-Id: Ie6a9c2d139ecd841d654943f14c119ebafd632f2
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
src/mainboard/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mainboard/Kconfig b/src/mainboard/Kconfig
index 24c1fe3..08af722 100644
--- a/src/mainboard/Kconfig
+++ b/src/mainboard/Kconfig
@@ -1,3 +1,5 @@
+comment "Important: Always start with an empty .config when switching mainboards"
+
choice
prompt "Mainboard vendor"
default VENDOR_EMULATION
the following patch was just integrated into master:
commit 6390e525fcbad63fbf4c0043ae248b24b9a9d0c6
Author: Arthur Heymans <arthur(a)aheymans.xyz>
Date: Mon Nov 21 17:11:48 2016 +0100
mb/asus/p5gc-mx: Add mainboard
Tested to work:
* GPU (Nvidia gt210) in PCIe x16 slot;
* SATA;
* serial;
* 800MHz and 1067MHz FSB Core 2 Duo CPUs;
* ethernet;
* native VGA graphic init.
What does not work:
* resume from s3 suspend;
* superio hardware monitor (not initialised in coreboot).
Quirks:
* does not boot with just one dimm in slot B.
Change-Id: Ide5494be7f2f16d6b5cfd2ccf4ec438f0587add5
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Reviewed-on: https://review.coreboot.org/17558
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
See https://review.coreboot.org/17558 for details.
-gerrit
the following patch was just integrated into master:
commit f5d9d1454a9e607e59c6b2e1533f70c1ffb565ad
Author: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Date: Fri Dec 16 12:53:53 2016 -0500
agesa and binaryPI mainboards: Fix devicetree hudson comments
Make the ending comment associated with "chip ...hudson" match the
appropriate directory name.
Change-Id: I5e0d6d41a2e3f963760aad08ed6108acac5b66b3
Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Reviewed-on: https://review.coreboot.org/17904
Reviewed-by: Martin Roth <martinroth(a)google.com>
Tested-by: build bot (Jenkins)
See https://review.coreboot.org/17904 for details.
-gerrit
Marshall Dawson (marshalldawson3rd(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17904
-gerrit
commit 6cb046cdd3e6cb1c9f8ca392c91ecef3b7b8b3f0
Author: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Date: Fri Dec 16 12:53:53 2016 -0500
agesa and binaryPI mainboards: Fix devicetree hudson comments
Make the ending comment associated with "chip ...hudson" match the
appropriate directory name.
Change-Id: I5e0d6d41a2e3f963760aad08ed6108acac5b66b3
Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com>
---
src/mainboard/amd/bettong/devicetree.cb | 2 +-
src/mainboard/amd/gardenia/devicetree.cb | 2 +-
src/mainboard/amd/olivehill/devicetree.cb | 2 +-
src/mainboard/amd/parmer/devicetree.cb | 2 +-
src/mainboard/amd/thatcher/devicetree.cb | 2 +-
src/mainboard/asrock/imb-a180/devicetree.cb | 2 +-
src/mainboard/asus/f2a85-m/devicetree.cb | 2 +-
src/mainboard/asus/f2a85-m_le/devicetree.cb | 2 +-
src/mainboard/bap/ode_e20XX/devicetree.cb | 2 +-
src/mainboard/biostar/am1ml/devicetree.cb | 2 +-
src/mainboard/gizmosphere/gizmo2/devicetree.cb | 2 +-
src/mainboard/hp/abm/devicetree.cb | 2 +-
src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb | 2 +-
src/mainboard/lenovo/g505s/devicetree.cb | 2 +-
src/mainboard/msi/ms7721/devicetree.cb | 2 +-
15 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/src/mainboard/amd/bettong/devicetree.cb b/src/mainboard/amd/bettong/devicetree.cb
index e490423..a259e92 100644
--- a/src/mainboard/amd/bettong/devicetree.cb
+++ b/src/mainboard/amd/bettong/devicetree.cb
@@ -54,7 +54,7 @@ chip northbridge/amd/pi/00660F01/root_complex
#device pci 14.2 on end # HDA 0x4383
device pci 14.3 on end # LPC 0x439d
device pci 14.7 on end # SD
- end #chip southbridge/amd/hudson
+ end #chip southbridge/amd/pi/hudson
device pci 18.0 on end
device pci 18.1 on end
diff --git a/src/mainboard/amd/gardenia/devicetree.cb b/src/mainboard/amd/gardenia/devicetree.cb
index a7573b1..be070d0 100644
--- a/src/mainboard/amd/gardenia/devicetree.cb
+++ b/src/mainboard/amd/gardenia/devicetree.cb
@@ -48,7 +48,7 @@ chip northbridge/amd/pi/00670F00/root_complex
end # SM
device pci 14.3 on end # LPC 0x790e
device pci 14.7 on end # SD
- end #chip southbridge/amd/hudson
+ end #chip southbridge/amd/pi/hudson
device pci 18.0 on end
device pci 18.1 on end
diff --git a/src/mainboard/amd/olivehill/devicetree.cb b/src/mainboard/amd/olivehill/devicetree.cb
index 5f0d09a..a027db9 100644
--- a/src/mainboard/amd/olivehill/devicetree.cb
+++ b/src/mainboard/amd/olivehill/devicetree.cb
@@ -53,7 +53,7 @@ chip northbridge/amd/agesa/family16kb/root_complex
device pci 14.2 on end # HDA 0x4383
device pci 14.3 on end # LPC 0x439d
device pci 14.7 on end # SD
- end #chip southbridge/amd/hudson
+ end #chip southbridge/amd/agesa/hudson
device pci 18.0 on end
device pci 18.1 on end
diff --git a/src/mainboard/amd/parmer/devicetree.cb b/src/mainboard/amd/parmer/devicetree.cb
index 29d0a53..da0028c 100644
--- a/src/mainboard/amd/parmer/devicetree.cb
+++ b/src/mainboard/amd/parmer/devicetree.cb
@@ -64,7 +64,7 @@ chip northbridge/amd/agesa/family15tn/root_complex
device pci 15.1 off end # PCIe 1
device pci 15.2 off end # PCIe 2
device pci 15.3 off end # PCIe 3
- end #chip southbridge/amd/hudson
+ end #chip southbridge/amd/agesa/hudson
device pci 18.0 on end
device pci 18.1 on end
diff --git a/src/mainboard/amd/thatcher/devicetree.cb b/src/mainboard/amd/thatcher/devicetree.cb
index e7715fa..cee1608 100644
--- a/src/mainboard/amd/thatcher/devicetree.cb
+++ b/src/mainboard/amd/thatcher/devicetree.cb
@@ -79,7 +79,7 @@ chip northbridge/amd/agesa/family15tn/root_complex
device pci 15.1 off end # PCIe 1
device pci 15.2 off end # PCIe 2
device pci 15.3 off end # PCIe 3
- end #chip southbridge/amd/hudson
+ end #chip southbridge/amd/agesa/hudson
device pci 18.0 on end
device pci 18.1 on end
diff --git a/src/mainboard/asrock/imb-a180/devicetree.cb b/src/mainboard/asrock/imb-a180/devicetree.cb
index e769420..238326d 100644
--- a/src/mainboard/asrock/imb-a180/devicetree.cb
+++ b/src/mainboard/asrock/imb-a180/devicetree.cb
@@ -94,7 +94,7 @@ chip northbridge/amd/agesa/family16kb/root_complex
end # w83627uhg
end # LPC 0x439d
device pci 14.7 on end # SD
- end #chip southbridge/amd/hudson
+ end #chip southbridge/amd/agesa/hudson
device pci 18.0 on end
device pci 18.1 on end
diff --git a/src/mainboard/asus/f2a85-m/devicetree.cb b/src/mainboard/asus/f2a85-m/devicetree.cb
index 6b728d5..d942445 100644
--- a/src/mainboard/asus/f2a85-m/devicetree.cb
+++ b/src/mainboard/asus/f2a85-m/devicetree.cb
@@ -113,7 +113,7 @@ chip northbridge/amd/agesa/family15tn/root_complex
device pci 15.2 off end # unused
device pci 15.3 off end # unused
- end #chip southbridge/amd/hudson
+ end #chip southbridge/amd/agesa/hudson
device pci 18.0 on end
device pci 18.1 on end
diff --git a/src/mainboard/asus/f2a85-m_le/devicetree.cb b/src/mainboard/asus/f2a85-m_le/devicetree.cb
index c209942..b9873d0 100644
--- a/src/mainboard/asus/f2a85-m_le/devicetree.cb
+++ b/src/mainboard/asus/f2a85-m_le/devicetree.cb
@@ -111,7 +111,7 @@ chip northbridge/amd/agesa/family15tn/root_complex
device pci 15.1 on end # PCIe 1 onboard gigabit
device pci 15.2 off end # unused
device pci 15.3 off end # unused
- end #chip southbridge/amd/hudson
+ end #chip southbridge/amd/agesa/hudson
device pci 18.0 on end
device pci 18.1 on end
diff --git a/src/mainboard/bap/ode_e20XX/devicetree.cb b/src/mainboard/bap/ode_e20XX/devicetree.cb
index 32ca9cf..959912e 100644
--- a/src/mainboard/bap/ode_e20XX/devicetree.cb
+++ b/src/mainboard/bap/ode_e20XX/devicetree.cb
@@ -102,7 +102,7 @@ chip northbridge/amd/agesa/family16kb/root_complex
end # f81866d
end #LPC
device pci 14.7 on end # SD
- end #chip southbridge/amd/hudson
+ end #chip southbridge/amd/agesa/hudson
device pci 18.0 on end
device pci 18.1 on end
diff --git a/src/mainboard/biostar/am1ml/devicetree.cb b/src/mainboard/biostar/am1ml/devicetree.cb
index 9b31bc6..59fb593 100644
--- a/src/mainboard/biostar/am1ml/devicetree.cb
+++ b/src/mainboard/biostar/am1ml/devicetree.cb
@@ -97,7 +97,7 @@ chip northbridge/amd/agesa/family16kb/root_complex
end #superio/ite/it8728f
end #device pci 14.3 # LPC
device pci 14.7 off end # SD
- end #chip southbridge/amd/hudson
+ end #chip southbridge/amd/agesa/hudson
device pci 18.0 on end
device pci 18.1 on end
diff --git a/src/mainboard/gizmosphere/gizmo2/devicetree.cb b/src/mainboard/gizmosphere/gizmo2/devicetree.cb
index 625e033..896c03d 100644
--- a/src/mainboard/gizmosphere/gizmo2/devicetree.cb
+++ b/src/mainboard/gizmosphere/gizmo2/devicetree.cb
@@ -46,7 +46,7 @@ chip northbridge/amd/agesa/family16kb/root_complex
device pci 14.2 on end # HDA 0x4383
device pci 14.3 on end # LPC 0x439d
device pci 14.7 on end # SD
- end #chip southbridge/amd/hudson
+ end #chip southbridge/amd/agesa/hudson
device pci 18.0 on end
device pci 18.1 on end
diff --git a/src/mainboard/hp/abm/devicetree.cb b/src/mainboard/hp/abm/devicetree.cb
index 5ff52aa..c9ca1d8 100644
--- a/src/mainboard/hp/abm/devicetree.cb
+++ b/src/mainboard/hp/abm/devicetree.cb
@@ -74,7 +74,7 @@ chip northbridge/amd/agesa/family16kb/root_complex
device pci 14.7 off end # SD
device pci 16.0 on end # USB
device pci 16.2 on end # USB
- end #chip southbridge/amd/hudson
+ end #chip southbridge/amd/agesa/hudson
device pci 18.0 on end
device pci 18.1 on end
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb b/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb
index a27b551..75d45d3 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb
+++ b/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb
@@ -65,7 +65,7 @@ chip northbridge/amd/agesa/family15tn/root_complex
device pci 15.1 off end # PCIe 1
device pci 15.2 off end # PCIe 2
device pci 15.3 off end # PCIe 3
- end #chip southbridge/amd/hudson
+ end #chip southbridge/amd/agesa/hudson
device pci 18.0 on end
device pci 18.1 on end
diff --git a/src/mainboard/lenovo/g505s/devicetree.cb b/src/mainboard/lenovo/g505s/devicetree.cb
index 1a9da04..a1cf338 100644
--- a/src/mainboard/lenovo/g505s/devicetree.cb
+++ b/src/mainboard/lenovo/g505s/devicetree.cb
@@ -69,7 +69,7 @@ chip northbridge/amd/agesa/family15rl/root_complex
device pci 15.1 off end # PCIe 1
device pci 15.2 off end # PCIe 2
device pci 15.3 off end # PCIe 3
- end #chip southbridge/amd/hudson
+ end #chip southbridge/amd/agesa/hudson
device pci 18.0 on end
device pci 18.1 on end
diff --git a/src/mainboard/msi/ms7721/devicetree.cb b/src/mainboard/msi/ms7721/devicetree.cb
index ced99f8..d46eb84 100644
--- a/src/mainboard/msi/ms7721/devicetree.cb
+++ b/src/mainboard/msi/ms7721/devicetree.cb
@@ -155,7 +155,7 @@ chip northbridge/amd/agesa/family15tn/root_complex
device pci 15.2 off end # unused
device pci 15.3 off end # unused
- end #chip southbridge/amd/hudson
+ end #chip southbridge/amd/agesa/hudson
device pci 18.0 on end
device pci 18.1 on end