coreboot-gerrit February 2014

coreboot-gerrit@coreboot.org

1 participants
1135 discussions

Patch merged into coreboot/master: abedcd3 uart8250: Drop includes in superio
by gerrit＠coreboot.org 06 Feb '14

06 Feb '14

the following patch was just integrated into master: commit abedcd314645f914bd84c76841cd13cf7d83908b Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Jan 30 16:45:29 2014 +0200 uart8250: Drop includes in superio Change-Id: If723896cc31da75dbb3a63d5dc959764e96fded1 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> See http://review.coreboot.org/5139 for details. -gerrit

1 0

Patch merged into coreboot/master: afb6bbe uart8250: Drop unused declarations
by gerrit＠coreboot.org 06 Feb '14

06 Feb '14

the following patch was just integrated into master: commit afb6bbec7a064304b3b159ba7f37e0a4ced3061f Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Tue Feb 4 20:28:23 2014 +0200 uart8250: Drop unused declarations Change-Id: Ie915ef9dbc45604bd5ca1b610acb12af634fdebe Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> See http://review.coreboot.org/5138 for details. -gerrit

1 0

Patch merged into coreboot/master: 4aadd22 uart8250: Drop xmodem support
by gerrit＠coreboot.org 06 Feb '14

06 Feb '14

the following patch was just integrated into master: commit 4aadd22ae0284aa57427c575d7d1a8c88105654b Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Jan 30 10:51:32 2014 +0200 uart8250: Drop xmodem support Unused and hard-coded to use uart8250 on IO. Change-Id: I3f84c50039a450a2ae97a5fd2af89992f8567e6c Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> See http://review.coreboot.org/5137 for details. -gerrit

1 0

Patch merged into coreboot/master: 1795782 QEMU debugcon: Move under drivers/emulation/qemu
by gerrit＠coreboot.org 06 Feb '14

06 Feb '14

the following patch was just integrated into master: commit 179578255d1a275524f17b17749a7dfff3335b61 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Sun Feb 2 19:12:14 2014 +0200 QEMU debugcon: Move under drivers/emulation/qemu Also prepare this console for use in romstage. Change-Id: I26a4d4b5db1e44a261396a21bb0f0574d72aa86d Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> See http://review.coreboot.org/5136 for details. -gerrit

1 0

Patch merged into coreboot/master: 56e9caf ne2k: Move under drivers/net
by gerrit＠coreboot.org 06 Feb '14

06 Feb '14

the following patch was just integrated into master: commit 56e9caf5f1b4a6a469ac396e45bf1d2c1c3fe85f Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Fri Jan 31 07:38:21 2014 +0200 ne2k: Move under drivers/net Change-Id: I978b6009c09c31be4429f57be40ef82f438f7574 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> See http://review.coreboot.org/5135 for details. -gerrit

1 0

Patch merged into coreboot/master: 7207305 spkmodem: Move under drivers/pc80
by gerrit＠coreboot.org 06 Feb '14

06 Feb '14

the following patch was just integrated into master: commit 720730520bf512fd302b1a0f71c8be915d0d9880 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Fri Jan 31 07:38:21 2014 +0200 spkmodem: Move under drivers/pc80 Change-Id: I46eb17ab19cea8759b3e4822019285cbe907e83a Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> See http://review.coreboot.org/5134 for details. -gerrit

1 0

Patch merged into coreboot/master: b821c90 usbdebug: Move under drivers/usb
by gerrit＠coreboot.org 06 Feb '14

06 Feb '14

the following patch was just integrated into master: commit b821c9068f8ad2942be5ec72fa8de1bb23437bcc Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Wed Feb 5 13:02:55 2014 +0200 usbdebug: Move under drivers/usb Also relocate and split header files, there is some interest for EHCI debug support without PCI. Change-Id: Ibe91730eb72dfe0634fb38bdd184043495e2fb08 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> See http://review.coreboot.org/5129 for details. -gerrit

1 0

Patch merged into coreboot/master: 6bf5292 usbdebug: Drop obsolete code
by gerrit＠coreboot.org 06 Feb '14

06 Feb '14

the following patch was just integrated into master: commit 6bf5292444aa79ec4def55b20cdda26629f4644c Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Tue Feb 4 19:18:59 2014 +0200 usbdebug: Drop obsolete code Change-Id: I918ca1d0d0d7bcb7e16d41a12830a0357f15b8ed Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> See http://review.coreboot.org/5130 for details. -gerrit

1 0

Patch set updated for coreboot: e7799bd util/xcompile/xcompile: Remove `-Wno-unused-but-set-variable` from `CFLAGS`
by Paul Menzel 06 Feb '14

06 Feb '14

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3981 -gerrit commit e7799bde525de0208ff4b9ecbc01733c9b7032f5 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sun Oct 20 00:11:34 2013 +0200 util/xcompile/xcompile: Remove `-Wno-unused-but-set-variable` from `CFLAGS` Do not disable warnings about unused but set variables to further improve the code quality. Change-Id: I25fa29ac42c9d09596d03f11fb01f31635a62a11 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- util/xcompile/xcompile | 5 ----- 1 file changed, 5 deletions(-) diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index df7d558..bfb6da1 100644 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -89,11 +89,6 @@ testas() { detect_special_flags() { local architecture="$1" - # GCC 4.6 is much more picky about unused variables. - # Turn off it's warnings for now: - testcc "$CC" "$CFLAGS -Wno-unused-but-set-variable " && - CFLAGS="$CFLAGS -Wno-unused-but-set-variable " - # Use bfd linker instead of gold if available: testcc "$CC" "$CFLAGS -fuse-ld=bfd" && CFLAGS="$CFLAGS -fuse-ld=bfd" && LINKER_SUFFIX='.bfd'

1 0

Patch set updated for coreboot: 1795782 QEMU debugcon: Move under drivers/emulation/qemu
by Kyösti Mälkki 06 Feb '14

06 Feb '14

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5136 -gerrit commit 179578255d1a275524f17b17749a7dfff3335b61 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Sun Feb 2 19:12:14 2014 +0200 QEMU debugcon: Move under drivers/emulation/qemu Also prepare this console for use in romstage. Change-Id: I26a4d4b5db1e44a261396a21bb0f0574d72aa86d Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/console/qemu_debugcon_console.c | 30 +++------------------- src/drivers/emulation/qemu/Makefile.inc | 3 +++ src/drivers/emulation/qemu/qemu_debugcon.c | 41 ++++++++++++++++++++++++++++++ src/include/console/qemu_debugcon.h | 7 +++++ 4 files changed, 54 insertions(+), 27 deletions(-) diff --git a/src/console/qemu_debugcon_console.c b/src/console/qemu_debugcon_console.c index 1d66d87..d7a53a2 100644 --- a/src/console/qemu_debugcon_console.c +++ b/src/console/qemu_debugcon_console.c @@ -19,43 +19,19 @@ */ #include <console/console.h> -#include <arch/io.h> - -static unsigned char readback; +#include <console/qemu_debugcon.h> static void debugcon_init(void) { - readback = inb(CONFIG_CONSOLE_QEMU_DEBUGCON_PORT); - printk(BIOS_INFO, "QEMU debugcon %s [port 0x%x]\n", - (readback == 0xe9) ? "detected" : "not found", - CONFIG_CONSOLE_QEMU_DEBUGCON_PORT); + qemu_debugcon_init(); } static void debugcon_tx_byte(unsigned char data) { - if (readback == 0xe9) { - outb(data, CONFIG_CONSOLE_QEMU_DEBUGCON_PORT); - } -} - -static void debugcon_tx_flush(void) -{ -} - -static unsigned char debugcon_rx_byte(void) -{ - return 0; -} - -static int debugcon_tst_byte(void) -{ - return 0; + qemu_debugcon_tx_byte(data); } static const struct console_driver debugcon_console __console = { .init = debugcon_init, .tx_byte = debugcon_tx_byte, - .tx_flush = debugcon_tx_flush, - .rx_byte = debugcon_rx_byte, - .tst_byte = debugcon_tst_byte, }; diff --git a/src/drivers/emulation/qemu/Makefile.inc b/src/drivers/emulation/qemu/Makefile.inc index e7dc5ed..3351627 100644 --- a/src/drivers/emulation/qemu/Makefile.inc +++ b/src/drivers/emulation/qemu/Makefile.inc @@ -1,3 +1,6 @@ +romstage-$(CONFIG_CONSOLE_QEMU_DEBUGCON) += qemu_debugcon.c +ramstage-$(CONFIG_CONSOLE_QEMU_DEBUGCON) += qemu_debugcon.c + ramstage-$(CONFIG_DRIVERS_EMULATION_QEMU_BOCHS) += bochs.c ramstage-$(CONFIG_DRIVERS_EMULATION_QEMU_BOCHS) += cirrus.c ramstage-$(CONFIG_DRIVERS_EMULATION_QEMU_BOCHS) += ../../pc80/vga/vga_io.c diff --git a/src/drivers/emulation/qemu/qemu_debugcon.c b/src/drivers/emulation/qemu/qemu_debugcon.c new file mode 100644 index 0000000..9c00585 --- /dev/null +++ b/src/drivers/emulation/qemu/qemu_debugcon.c @@ -0,0 +1,41 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2013 Red Hat Inc. + * Written by Gerd Hoffmann <kraxel(a)redhat.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include <console/console.h> +#include <console/qemu_debugcon.h> +#include <arch/io.h> +#include <arch/early_variables.h> + +static int qemu_debugcon_detected CAR_GLOBAL; + +void qemu_debugcon_init(void) +{ + int detected = (inb(CONFIG_CONSOLE_QEMU_DEBUGCON_PORT) == 0xe9); + car_set_var(qemu_debugcon_detected, detected); + printk(BIOS_INFO, "QEMU debugcon %s [port 0x%x]\n", + detected ? "detected" : "not found", + CONFIG_CONSOLE_QEMU_DEBUGCON_PORT); +} + +void qemu_debugcon_tx_byte(unsigned char data) +{ + if (car_get_var(qemu_debugcon_detected) != 0) + outb(data, CONFIG_CONSOLE_QEMU_DEBUGCON_PORT); +} diff --git a/src/include/console/qemu_debugcon.h b/src/include/console/qemu_debugcon.h new file mode 100644 index 0000000..63b1455 --- /dev/null +++ b/src/include/console/qemu_debugcon.h @@ -0,0 +1,7 @@ +#ifndef _QEMU_DEBUGCON_H_ +#define _QEMU_DEBUGCON_H_ + +void qemu_debugcon_init(void); +void qemu_debugcon_tx_byte(unsigned char data); + +#endif

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2014