coreboot-gerrit February 2014

coreboot-gerrit@coreboot.org

1 participants
1135 discussions

Patch set updated for coreboot: be96510 smbus: Add guards to avoid calling NULL.
by Vladimir Serbinenko 01 Feb '14

01 Feb '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4837 -gerrit commit be9651002c3473df0f3950b24636743beb5e48f1 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Mon Jan 27 23:46:46 2014 +0100 smbus: Add guards to avoid calling NULL. Many of SMBus functions are unavailable on many controllers. While calling unavailable function is bad, it shouldn't lead to spectacular crash. Change-Id: I7912f3bbbb438603893223a586dcedf57e8a7e28 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- src/device/smbus_ops.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/src/device/smbus_ops.c b/src/device/smbus_ops.c index bcef4cd..41b31ed 100644 --- a/src/device/smbus_ops.c +++ b/src/device/smbus_ops.c @@ -79,59 +79,89 @@ int smbus_set_link(device_t dev) return pbus_num; } +#define CHECK_PRESENCE(x) \ + if (!ops_smbus_bus(get_pbus_smbus(dev))->x) { \ + printk(BIOS_ERR, "%s missing " #x "\n", \ + dev_path(dev)); \ + return -1; \ + } + + int smbus_quick_read(device_t dev) { + CHECK_PRESENCE(quick_read); + return ops_smbus_bus(get_pbus_smbus(dev))->quick_read(dev); } int smbus_quick_write(device_t dev) { + CHECK_PRESENCE(quick_write); + return ops_smbus_bus(get_pbus_smbus(dev))->quick_write(dev); } int smbus_recv_byte(device_t dev) { + CHECK_PRESENCE(recv_byte); + return ops_smbus_bus(get_pbus_smbus(dev))->recv_byte(dev); } int smbus_send_byte(device_t dev, u8 byte) { + CHECK_PRESENCE(send_byte); + return ops_smbus_bus(get_pbus_smbus(dev))->send_byte(dev, byte); } int smbus_read_byte(device_t dev, u8 addr) { + CHECK_PRESENCE(read_byte); + return ops_smbus_bus(get_pbus_smbus(dev))->read_byte(dev, addr); } int smbus_write_byte(device_t dev, u8 addr, u8 val) { + CHECK_PRESENCE(write_byte); + return ops_smbus_bus(get_pbus_smbus(dev))->write_byte(dev, addr, val); } int smbus_read_word(device_t dev, u8 addr) { + CHECK_PRESENCE(read_word); + return ops_smbus_bus(get_pbus_smbus(dev))->read_word(dev, addr); } int smbus_write_word(device_t dev, u8 addr, u16 val) { + CHECK_PRESENCE(write_word); + return ops_smbus_bus(get_pbus_smbus(dev))->write_word(dev, addr, val); } int smbus_process_call(device_t dev, u8 cmd, u16 data) { + CHECK_PRESENCE(process_call); + return ops_smbus_bus(get_pbus_smbus(dev))->process_call(dev, cmd, data); } int smbus_block_read(device_t dev, u8 cmd, u8 bytes, u8 *buffer) { + CHECK_PRESENCE(block_read); + return ops_smbus_bus(get_pbus_smbus(dev))->block_read(dev, cmd, bytes, buffer); } int smbus_block_write(device_t dev, u8 cmd, u8 bytes, const u8 *buffer) { + CHECK_PRESENCE(block_write); + return ops_smbus_bus(get_pbus_smbus(dev))->block_write(dev, cmd, bytes, buffer); }

1 0

Patch set updated for coreboot: 953d612 smbus: Add guards to avoid calling NULL.
by Rudolf Marek 01 Feb '14

01 Feb '14

Rudolf Marek (r.marek(a)assembler.cz) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4837 -gerrit commit 953d6126d4dc4c21a0d57f15a79fccc3821af24b Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Mon Jan 27 23:46:46 2014 +0100 smbus: Add guards to avoid calling NULL. Many of SMBus functions are unavailable on many controllers. While calling unavailable function is bad, it shouldn't lead to spectacular crash. Change-Id: I7912f3bbbb438603893223a586dcedf57e8a7e28 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- src/device/smbus_ops.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/src/device/smbus_ops.c b/src/device/smbus_ops.c index bcef4cd..41b31ed 100644 --- a/src/device/smbus_ops.c +++ b/src/device/smbus_ops.c @@ -79,59 +79,89 @@ int smbus_set_link(device_t dev) return pbus_num; } +#define CHECK_PRESENCE(x) \ + if (!ops_smbus_bus(get_pbus_smbus(dev))->x) { \ + printk(BIOS_ERR, "%s missing " #x "\n", \ + dev_path(dev)); \ + return -1; \ + } + + int smbus_quick_read(device_t dev) { + CHECK_PRESENCE(quick_read); + return ops_smbus_bus(get_pbus_smbus(dev))->quick_read(dev); } int smbus_quick_write(device_t dev) { + CHECK_PRESENCE(quick_write); + return ops_smbus_bus(get_pbus_smbus(dev))->quick_write(dev); } int smbus_recv_byte(device_t dev) { + CHECK_PRESENCE(recv_byte); + return ops_smbus_bus(get_pbus_smbus(dev))->recv_byte(dev); } int smbus_send_byte(device_t dev, u8 byte) { + CHECK_PRESENCE(send_byte); + return ops_smbus_bus(get_pbus_smbus(dev))->send_byte(dev, byte); } int smbus_read_byte(device_t dev, u8 addr) { + CHECK_PRESENCE(read_byte); + return ops_smbus_bus(get_pbus_smbus(dev))->read_byte(dev, addr); } int smbus_write_byte(device_t dev, u8 addr, u8 val) { + CHECK_PRESENCE(write_byte); + return ops_smbus_bus(get_pbus_smbus(dev))->write_byte(dev, addr, val); } int smbus_read_word(device_t dev, u8 addr) { + CHECK_PRESENCE(read_word); + return ops_smbus_bus(get_pbus_smbus(dev))->read_word(dev, addr); } int smbus_write_word(device_t dev, u8 addr, u16 val) { + CHECK_PRESENCE(write_word); + return ops_smbus_bus(get_pbus_smbus(dev))->write_word(dev, addr, val); } int smbus_process_call(device_t dev, u8 cmd, u16 data) { + CHECK_PRESENCE(process_call); + return ops_smbus_bus(get_pbus_smbus(dev))->process_call(dev, cmd, data); } int smbus_block_read(device_t dev, u8 cmd, u8 bytes, u8 *buffer) { + CHECK_PRESENCE(block_read); + return ops_smbus_bus(get_pbus_smbus(dev))->block_read(dev, cmd, bytes, buffer); } int smbus_block_write(device_t dev, u8 cmd, u8 bytes, const u8 *buffer) { + CHECK_PRESENCE(block_write); + return ops_smbus_bus(get_pbus_smbus(dev))->block_write(dev, cmd, bytes, buffer); }

1 0

Patch merged into coreboot/master: b9a7160 cpu/intel/model_2065x: Add model 20652
by gerrit＠coreboot.org 01 Feb '14

01 Feb '14

the following patch was just integrated into master: commit b9a7160e505fec6867bf5f5448cd1e9ddd8b00f2 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sat Feb 1 16:24:22 2014 +0100 cpu/intel/model_2065x: Add model 20652 Found in some X201t. Tested on X201t. Change-Id: I3fc4c3f5b1abf9fe61746ab8f401d1b6ee67f3ea Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> See http://review.coreboot.org/5090 for details. -gerrit

1 0

New patch to review for coreboot: b9a7160 cpu/intel/model_2065x: Add model 20652
by Vladimir Serbinenko 01 Feb '14

01 Feb '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5090 -gerrit commit b9a7160e505fec6867bf5f5448cd1e9ddd8b00f2 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sat Feb 1 16:24:22 2014 +0100 cpu/intel/model_2065x: Add model 20652 Found in some X201t. Tested on X201t. Change-Id: I3fc4c3f5b1abf9fe61746ab8f401d1b6ee67f3ea Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- src/cpu/intel/model_2065x/model_2065x_init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cpu/intel/model_2065x/model_2065x_init.c b/src/cpu/intel/model_2065x/model_2065x_init.c index 0fd1bf0..6df45a4 100644 --- a/src/cpu/intel/model_2065x/model_2065x_init.c +++ b/src/cpu/intel/model_2065x/model_2065x_init.c @@ -456,6 +456,7 @@ static struct device_operations cpu_dev_ops = { }; static struct cpu_device_id cpu_table[] = { + { X86_VENDOR_INTEL, 0x20652 }, /* Intel Nehalem */ { X86_VENDOR_INTEL, 0x20655 }, /* Intel Nehalem */ { 0, 0 }, };

1 0

Patch set updated for coreboot: 36f95f1 boardstatus/to-wiki.sh: Accept Kconfig with non-tab separators.
by Vladimir Serbinenko 01 Feb '14

01 Feb '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5069 -gerrit commit 36f95f16ce34e0db48ce206647ec37cf185c4134 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Tue Jan 28 04:16:41 2014 +0100 boardstatus/to-wiki.sh: Accept Kconfig with non-tab separators. Usage of two whitespaces vs a tab is not consistent in Kconfig. It's unreasonable to fail just because 2 whitespaces were used in Kconfig instead of a tab. Change-Id: I3812c6bd6fb11d9e98ef60afb205782f2b1f0e44 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- util/board_status/to-wiki/towiki.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/board_status/to-wiki/towiki.sh b/util/board_status/to-wiki/towiki.sh index a9fb520..b7dab03 100755 --- a/util/board_status/to-wiki/towiki.sh +++ b/util/board_status/to-wiki/towiki.sh @@ -216,9 +216,9 @@ EOF northbridge="$(sed -n "/^[[:space:]]*select NORTHBRIDGE_/ s,^[[:space:]]*select NORTHBRIDGE_,,p" "$vendor_board_dir/Kconfig")" northbridge_nice="$(echo "$northbridge"|sed 's,AMD_AGESA_FAMILY$[0-9a-fA-F]*$$.*$,AMD Family \1h\2 (AGESA),g;s,AMD_FAMILY$[0-9a-fA-F]*$,AMD Family \1h,g;s,AMD_AMDFAM$[0-9a-fA-F]*$,AMD Family \1h,g;s,_, ,g;s,INTEL,Intel®,g;')" - southbridge="$(sed -n "/ select SOUTHBRIDGE_/ s, select SOUTHBRIDGE_,,p" "$vendor_board_dir/Kconfig"|grep -v SKIP_ISA_DMA_INIT)" + southbridge="$(sed -n "/[[:space:]]*select SOUTHBRIDGE_/ s,[[:space:]]*select SOUTHBRIDGE_,,p" "$vendor_board_dir/Kconfig"|grep -v SKIP_ISA_DMA_INIT)" southbridge_nice="$(echo "$southbridge"|sed 's,_, ,g;s,INTEL,Intel®,g')" - superio="$(sed -n "/ select SUPERIO_/ s, select SUPERIO_,,p" "$vendor_board_dir/Kconfig")" + superio="$(sed -n "/[[:space:]]*select SUPERIO_/ s,[[:space:]]*select SUPERIO_,,p" "$vendor_board_dir/Kconfig")" superio_nice="$(echo "$superio"|sed 's,_, ,g;s,WINBOND,Winbond™,g;s,ITE,ITE™,g;s,SMSC,SMSC®,g')" cpu="$(sed -n "/ select CPU_/ s, select CPU_,,p" "$vendor_board_dir/Kconfig"|grep -v "AMD_AGESA_FAMILY")" case "$cpu" in

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2014