coreboot-gerrit April 2013

coreboot-gerrit@coreboot.org

1 participants
506 discussions

Patch merged into coreboot/master: 15a1fd1 inteltool: Use portable type `uint64_t` instead of `u64`
by gerrit＠coreboot.org 14 Apr '13

14 Apr '13

the following patch was just integrated into master: commit 15a1fd1db9dd93004f808badcb15ca635177def6 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sun Apr 14 13:00:22 2013 +0200 inteltool: Use portable type `uint64_t` instead of `u64` In [1] Idwer Vollering noted, that the type `u64` is not portable so on his FreeBSD system, the following warning is shown. $ clang -O2 -Wall -W -I/usr/local/include -c -o amb.o amb.c amb.c:441:22: error: use of undeclared identifier 'u64' ambconfig_phys = ((u64)pci_read_long(dev16, 0x4c) << 32) | The type `uint64_t` seems to be defined also on FreeBSD, so using this fixes the warning. Note, this warning is not reproducable with Debian Sid/unstable for example. I have no idea why though. [1] http://review.coreboot.org/#/c/3015/ Change-Id: Ic22f4371114b68ae8221d84a01fef6888d43f365 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-on: http://review.coreboot.org/3086 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> Build-Tested: build bot (Jenkins) at Sun Apr 14 15:17:24 2013, giving +1 Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Sun Apr 14 23:00:35 2013, giving +2 See http://review.coreboot.org/3086 for details. -gerrit

1 0

Patch merged into coreboot/master: 0b31286 AMD CIMx sb800/SATA.c, sb900/Sata.c: Fix R*AI*D typo in comments
by gerrit＠coreboot.org 14 Apr '13

14 Apr '13

the following patch was just integrated into master: commit 0b3128679688b76f8fc92a770615270707a80afd Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Fri Apr 12 14:03:04 2013 +0200 AMD CIMx sb800/SATA.c, sb900/Sata.c: Fix R*AI*D typo in comments Spell RAID correctly in comments. Found with the following command. $ git grep -i riad Change-Id: I68e8476d885a88df589d25f88cc158d71eb04e07 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-on: http://review.coreboot.org/3081 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> Build-Tested: build bot (Jenkins) at Sat Apr 13 18:35:39 2013, giving +1 Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Sun Apr 14 19:28:50 2013, giving +2 See http://review.coreboot.org/3081 for details. -gerrit

1 0

New patch to review for coreboot: 741b0b3 inteltool: Use portable type `uint64_t` instead of `u64`
by Paul Menzel 14 Apr '13

14 Apr '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3086 -gerrit commit 741b0b37241f5be84e9066bb51ebf85447b8ee23 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sun Apr 14 13:00:22 2013 +0200 inteltool: Use portable type `uint64_t` instead of `u64` In [1] Idwer Vollering noted, that the type `u64` is not portable so on his FreeBSD system, the following warning is shown. $ clang -O2 -Wall -W -I/usr/local/include -c -o amb.o amb.c amb.c:441:22: error: use of undeclared identifier 'u64' ambconfig_phys = ((u64)pci_read_long(dev16, 0x4c) << 32) | The type `uint64_t` seems to be defined also on FreeBSD, so using this fixes the warning. Note, this warning is not reproducable with Debian Sid/unstable for example. I have no idea why though. [1] http://review.coreboot.org/#/c/3015/ Change-Id: Ic22f4371114b68ae8221d84a01fef6888d43f365 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- util/inteltool/amb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/inteltool/amb.c b/util/inteltool/amb.c index a1761ee..13397db 100644 --- a/util/inteltool/amb.c +++ b/util/inteltool/amb.c @@ -438,7 +438,7 @@ int print_ambs(struct pci_dev *dev, struct pci_access *pacc) return 1; } - ambconfig_phys = ((u64)pci_read_long(dev16, 0x4c) << 32) | + ambconfig_phys = ((uint64_t)pci_read_long(dev16, 0x4c) << 32) | pci_read_long(dev16, 0x48); max_channel = pci_read_byte(dev16, 0x56)/max_branch;

1 0

Patch merged into coreboot/master: cb891de cbmem: parse_cbtable: Use length modifier `ll` `u64` argument
by gerrit＠coreboot.org 14 Apr '13

14 Apr '13

the following patch was just integrated into master: commit cb891de07ffe605897010776fc1becc9589d3648 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sat Apr 13 18:35:32 2013 +0200 cbmem: parse_cbtable: Use length modifier `ll` `u64` argument Currently on a 32-bit system cbmem fails to build due to `-Werror` and the following warning. $ make cc -O2 -Wall -Werror -iquote ../../src/include -iquote ../../src/src/arch/x86 -c -o cbmem.o cbmem.c […] cbmem.c: In function ‘parse_cbtable’: cbmem.c:135:2: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘u64’ [-Werror=format] cc1: all warnings being treated as errors […] Using the length modifier `ll` instead of `l` gets rid of this warning. Change-Id: Ib2656e27594c7aaa687aa84bf07042933f840e46 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-on: http://review.coreboot.org/3084 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> Build-Tested: build bot (Jenkins) at Sat Apr 13 19:48:39 2013, giving +1 Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Sun Apr 14 02:06:21 2013, giving +2 See http://review.coreboot.org/3084 for details. -gerrit

1 0

Patch merged into coreboot/master: b8eb0a8 link/graphics: Remove the inclusion of an AMD header.
by gerrit＠coreboot.org 14 Apr '13

14 Apr '13

the following patch was just integrated into master: commit b8eb0a802f777bd4b2c24bca571afc1d89352006 Author: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Date: Sat Apr 13 23:06:17 2013 +0200 link/graphics: Remove the inclusion of an AMD header. link(google chromebook pixel) is an intel machine. Change-Id: I9d40f1e945021d8e190879477cd12be7d0262733 Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Reviewed-on: http://review.coreboot.org/3085 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> Build-Tested: build bot (Jenkins) at Sat Apr 13 23:32:19 2013, giving +1 Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Sun Apr 14 02:05:35 2013, giving +2 See http://review.coreboot.org/3085 for details. -gerrit

1 0

New patch to review for coreboot: 2f00e94 link/graphics: Remove the inclusion of an AMD header.
by Denis Carikli 13 Apr '13

13 Apr '13

Denis Carikli (GNUtoo(a)no-log.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3085 -gerrit commit 2f00e94872b5849c3c6f5529746d1def0d97842a Author: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Date: Sat Apr 13 23:06:17 2013 +0200 link/graphics: Remove the inclusion of an AMD header. link(google chromebook pixel) is an intel machine. Change-Id: I9d40f1e945021d8e190879477cd12be7d0262733 Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> --- src/mainboard/google/link/i915.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mainboard/google/link/i915.c b/src/mainboard/google/link/i915.c index ec959ab..42b9c0f 100644 --- a/src/mainboard/google/link/i915.c +++ b/src/mainboard/google/link/i915.c @@ -43,7 +43,6 @@ #include <cpu/x86/tsc.h> #include <cpu/x86/cache.h> #include <cpu/x86/mtrr.h> -#include <cpu/amd/mtrr.h> #include <cpu/x86/msr.h> #include <edid.h> #include "i915io.h"

1 0

New patch to review for coreboot: 460483c cbmem: parse_cbtable: Use length modifier `ll` `u64` argument
by Paul Menzel 13 Apr '13

13 Apr '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3084 -gerrit commit 460483c419dde788fc3fe2959412bbd87e051d28 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sat Apr 13 18:35:32 2013 +0200 cbmem: parse_cbtable: Use length modifier `ll` `u64` argument Currently on a 32-bit system cbmem fails to build due to `-Werror` and the following warning. $ make cc -O2 -Wall -Werror -iquote ../../src/include -iquote ../../src/src/arch/x86 -c -o cbmem.o cbmem.c […] cbmem.c: In function ‘parse_cbtable’: cbmem.c:135:2: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘u64’ [-Werror=format] cc1: all warnings being treated as errors […] Using the length modifier `ll` instead of `l` gets rid of this warning. Change-Id: Ib2656e27594c7aaa687aa84bf07042933f840e46 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- util/cbmem/cbmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c index f3f5add..ae5dbf6 100644 --- a/util/cbmem/cbmem.c +++ b/util/cbmem/cbmem.c @@ -132,7 +132,7 @@ static int parse_cbtable(u64 address) int i, found = 0; void *buf; - debug("Looking for coreboot table at %lx\n", address); + debug("Looking for coreboot table at %llx\n", address); buf = map_memory(address); /* look at every 16 bytes within 4K of the base */

1 0

New patch to review for coreboot: 59e45c6 cbmem: map_memory: Use length modifier `l` for an argument with type off_t
by Paul Menzel 13 Apr '13

13 Apr '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3083 -gerrit commit 59e45c630ab672cdf6f955aec9355b33de56f510 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sat Apr 13 18:25:56 2013 +0200 cbmem: map_memory: Use length modifier `l` for an argument with type off_t cbmem currently fails to build due to `-Werror` and the following warning. $ make cc -O2 -Wall -Werror -iquote ../../src/include -iquote ../../src/src/arch/x86 -c -o cbmem.o cbmem.c cbmem.c: In function ‘map_memory’: cbmem.c:87:2: error: format ‘%zx’ expects argument of type ‘size_t’, but argument 2 has type ‘off_t’ [-Werror=format] […] Using the length modifier `l` instead of `z` for an argument with type off_t, so `%lx` instead of `%lz`, gets rid of this warning. Change-Id: I1360abbc47aa1662e1edfbe337cf7911695c532f Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- util/cbmem/cbmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c index f3f5add..d94c670 100644 --- a/util/cbmem/cbmem.c +++ b/util/cbmem/cbmem.c @@ -84,7 +84,7 @@ static void *map_memory(u64 physical) /* Mapped memory must be aligned to page size */ p = physical & ~(page - 1); - debug("Mapping 1MB of physical memory at 0x%zx.\n", p); + debug("Mapping 1MB of physical memory at 0x%lx.\n", p); v = mmap(NULL, MAP_BYTES, PROT_READ, MAP_SHARED, fd, p);

1 0

New patch to review for coreboot: b1ccbf6 cbmem: Makefile: Allow to override `CC` variable
by Paul Menzel 13 Apr '13

13 Apr '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3082 -gerrit commit b1ccbf68aeac142342a824b86775e2109ceb1b4e Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Fri Apr 5 11:39:42 2013 +0200 cbmem: Makefile: Allow to override `CC` variable Now users can use a different compiler from GCC like Clang by for example doing `CC=clang make`. Change-Id: I664a36df79f7496a56d89bdb61948b2eda33a6b4 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- util/cbmem/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/cbmem/Makefile b/util/cbmem/Makefile index bf74e08..c93863a 100644 --- a/util/cbmem/Makefile +++ b/util/cbmem/Makefile @@ -19,7 +19,7 @@ PROGRAM = cbmem ROOT = ../../src -CC = $(CROSS_COMPILE)gcc +CC ?= $(CROSS_COMPILE)gcc CFLAGS ?= -O2 CFLAGS += -Wall -Werror CPPFLAGS += -iquote $(ROOT)/include -iquote $(ROOT)/src/arch/x86

1 0

New patch to review for coreboot: f40954b AMD CIMx sb800/SATA.c, sb900/Sata.c: Fix R*AI*D typo in comments
by Paul Menzel 13 Apr '13

13 Apr '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3081 -gerrit commit f40954b731704a213192864e97e77bd52355393e Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Fri Apr 12 14:03:04 2013 +0200 AMD CIMx sb800/SATA.c, sb900/Sata.c: Fix R*AI*D typo in comments Spell RAID correctly in comments. Found with the following command. $ git grep -i riad Change-Id: I68e8476d885a88df589d25f88cc158d71eb04e07 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/vendorcode/amd/cimx/sb800/SATA.c | 2 +- src/vendorcode/amd/cimx/sb900/Sata.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vendorcode/amd/cimx/sb800/SATA.c b/src/vendorcode/amd/cimx/sb800/SATA.c index b7bbacd..4aa3be7 100644 --- a/src/vendorcode/amd/cimx/sb800/SATA.c +++ b/src/vendorcode/amd/cimx/sb800/SATA.c @@ -469,7 +469,7 @@ sataInitAfterPciEnum ( RWPCI (((SATA_BUS_DEV_FUN << 16) + SB_SATA_REG34), AccWidthUint8 | S3_SAVE, 0, 0x70); if (((pConfig->SataClass) != NATIVE_IDE_MODE) && ((pConfig->SataClass) != LEGACY_IDE_MODE)) { - // RIAD or AHCI + // RAID or AHCI if ((pConfig->SATAMODE.SataMode.SataIdeCombinedMode) == SATA_IDE_COMBINE_DISABLE) { RWMEM ((ddBar5 + SB_SATA_BAR5_REG00), AccWidthUint8 | S3_SAVE, ~(BIT2 + BIT1 + BIT0), BIT2 + BIT0); RWMEM ((ddBar5 + SB_SATA_BAR5_REG0C), AccWidthUint8 | S3_SAVE, 0xC0, 0x3F); diff --git a/src/vendorcode/amd/cimx/sb900/Sata.c b/src/vendorcode/amd/cimx/sb900/Sata.c index 9a7cf53..98e1f57 100644 --- a/src/vendorcode/amd/cimx/sb900/Sata.c +++ b/src/vendorcode/amd/cimx/sb900/Sata.c @@ -694,7 +694,7 @@ sataInitAfterPciEnum ( } if (((pConfig->SataClass) != NATIVE_IDE_MODE) && ((pConfig->SataClass) != LEGACY_IDE_MODE)) { - // RIAD or AHCI + // RAID or AHCI if ((pConfig->SATAMODE.SataMode.SataIdeCombinedMode) == DISABLED) { // IDE2 Controller is enabled if ((pConfig->SATAMODE.SataMode.SataIdeCombMdPriSecOpt) == ENABLED) {

1 0

← Newer
1
...
24
25
26
27
28
29
30
...
51
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2013