Change in coreboot[master]: mb/google/deltaur: Update ISH firmware name

[Anil Kumar K (Code Review)]

Anil Kumar K has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40537 )

Change subject: mb/google/deltaur: Update ISH firmware name
......................................................................

mb/google/deltaur: Update ISH firmware name

Bug=b:153847811
Branch=master
Test=make build successfull

Signed-off-by: Anil Kumar 
Change-Id: Ic701f224452731e43207836882d649580b76db3a
---
M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb
1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/40537/1

diff --git a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb
index e0b3d50..831c1c4 100644
--- a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb
@@ -175,7 +175,13 @@
    	device pci 11.2 off end # UART5
    	device pci 11.3 off end # UART6

-		device pci 12.0 on  end # ISH
+		device pci 12.0 on
+			chip drivers/intel/ish
+				register "firmware_name" = ""deltaur_ish.bin""
+				device generic 0 on end
+			end
+		end # ISH
+
    	device pci 12.6 off end # GSPI #2
    	device pci 13.0 off end # GSPI #3
    	device pci 13.1 off end # GSPI #4

[Anil Kumar K (Code Review)]

Anil Kumar K has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/40537 )

Change subject: mb/google/deltaur: Update ISH firmware name
......................................................................

mb/google/deltaur: Update ISH firmware name

Bug=b:153847811
Branch=master
Test=make build successful

Signed-off-by: Anil Kumar 
Change-Id: Ic701f224452731e43207836882d649580b76db3a
---
M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb
1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/40537/2

Change in coreboot[master]: mb/google/deltaur: Register ISH firmware name

[Anil Kumar K (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40537

to look at the new patch set (#4).

Change subject: mb/google/deltaur: Register ISH firmware name
......................................................................

mb/google/deltaur: Register ISH firmware name

Bug=b:153847811
Branch=master
Test=make build successful

Signed-off-by: Anil Kumar 
Change-Id: Ic701f224452731e43207836882d649580b76db3a
---
M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb
1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/40537/4

Change in coreboot[master]: mb/google/deltaur: Register ISH firmware name

[Anil Kumar K (Code Review)]

Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40537 )

Change subject: mb/google/deltaur: Register ISH firmware name
......................................................................

Patch Set 4: Code-Review+1

Change in coreboot[master]: mb/google/deltaur: Register ISH firmware name

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40537 )

Change subject: mb/google/deltaur: Register ISH firmware name
......................................................................

Patch Set 4:

Anil, will this cause any downstream failures because we don't have any initial ISH image checked in yet?

Change in coreboot[master]: mb/google/deltaur: Register ISH firmware name

[Anil Kumar K (Code Review)]

Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40537 )

Change subject: mb/google/deltaur: Register ISH firmware name
......................................................................

Patch Set 4:
> Patch Set 4:
>
> Anil, will this cause any downstream failures because we don't have any initial ISH image checked in yet?

We would need the changes in FIT config for the shim loader (https://chrome-internal-review.googlesource.com/c/chromeos/overlays/baseboar...)

If we are planning to merge the ISH changes i will remove the DONOT MERGE from the fit config patch

@Li, Can you please confirm if these two patches are sufficient for ISH enablement on coreboot side?
Am i missing any other dependencies ? I saw the GPIO pin mux settings already taken care of in gpio.c
https://review.coreboot.org/c/coreboot/+/40537
https://chrome-internal-review.googlesource.com/c/chromeos/overlays/baseboar...

Change in coreboot[master]: mb/google/deltaur: Register ISH firmware name

[Li Feng (Code Review)]

Li Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40537 )

Change subject: mb/google/deltaur: Register ISH firmware name
......................................................................

Patch Set 4:
> Patch Set 4:
> > Patch Set 4:
> >
> > Anil, will this cause any downstream failures because we don't have any initial ISH image checked in yet?
>
> We would need the changes in FIT config for the shim loader (https://chrome-internal-review.googlesource.com/c/chromeos/overlays/baseboar...)
>
> If we are planning to merge the ISH changes i will remove the DONOT MERGE from the fit config patch
>
> @Li, Can you please confirm if these two patches are sufficient for ISH enablement on coreboot side?
> Am i missing any other dependencies ? I saw the GPIO pin mux settings already taken care of in gpio.c
> https://review.coreboot.org/c/coreboot/+/40537
> https://chrome-internal-review.googlesource.com/c/chromeos/overlays/baseboar...

In board Kconfig file, should do "select DRIVERS_INTEL_ISH" to load ISH driver.

Change in coreboot[master]: mb/google/deltaur: Register ISH firmware name

[Anil Kumar K (Code Review)]

Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40537 )

Change subject: mb/google/deltaur: Register ISH firmware name
......................................................................

Patch Set 4:
> Patch Set 4:
> > Patch Set 4:
> > > Patch Set 4:
> > >
> > > Anil, will this cause any downstream failures because we don't have any initial ISH image checked in yet?
> >
> > We would need the changes in FIT config for the shim loader (https://chrome-internal-review.googlesource.com/c/chromeos/overlays/baseboar...)
> >
> > If we are planning to merge the ISH changes i will remove the DONOT MERGE from the fit config patch
> >
> > @Li, Can you please confirm if these two patches are sufficient for ISH enablement on coreboot side?
> > Am i missing any other dependencies ? I saw the GPIO pin mux settings already taken care of in gpio.c
> > https://review.coreboot.org/c/coreboot/+/40537
> > https://chrome-internal-review.googlesource.com/c/chromeos/overlays/baseboar...
>
> In board Kconfig file, should do "select DRIVERS_INTEL_ISH" to load ISH driver.

Hi Li,

I see this already there in the Kconfig
config BOARD_GOOGLE_BASEBOARD_DELTAUR
        def_bool n
        select BOARD_ROMSIZE_KB_32768
        select DRIVERS_I2C_GENERIC
        select DRIVERS_INTEL_ISH
        ...

Change in coreboot[master]: mb/google/deltaur: Register ISH firmware name

[Li Feng (Code Review)]

Li Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40537 )

Change subject: mb/google/deltaur: Register ISH firmware name
......................................................................

Patch Set 4:
> Patch Set 4:
> > Patch Set 4:
> > > Patch Set 4:
> > > > Patch Set 4:
> > > >
> > > > Anil, will this cause any downstream failures because we don't have any initial ISH image checked in yet?
> > >
> > > We would need the changes in FIT config for the shim loader (https://chrome-internal-review.googlesource.com/c/chromeos/overlays/baseboar...)
> > >
> > > If we are planning to merge the ISH changes i will remove the DONOT MERGE from the fit config patch
> > >
> > > @Li, Can you please confirm if these two patches are sufficient for ISH enablement on coreboot side?
> > > Am i missing any other dependencies ? I saw the GPIO pin mux settings already taken care of in gpio.c
> > > https://review.coreboot.org/c/coreboot/+/40537
> > > https://chrome-internal-review.googlesource.com/c/chromeos/overlays/baseboar...
> >
> > In board Kconfig file, should do "select DRIVERS_INTEL_ISH" to load ISH driver.
>
> Hi Li,
>
> I see this already there in the Kconfig
> config BOARD_GOOGLE_BASEBOARD_DELTAUR
>         def_bool n
>         select BOARD_ROMSIZE_KB_32768
>         select DRIVERS_I2C_GENERIC
>         select DRIVERS_INTEL_ISH
>         ...

Sounds good. This should be OK. but always we have to wait being verified when HW is available.

[XS] Change in coreboot[master]: mb/google/deltaur: Register ISH firmware name

[Stefan Reinauer (Code Review)]

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40537?usp=email )

Change subject: mb/google/deltaur: Register ISH firmware name
......................................................................

Abandoned