Patch Set 4:

Patch Set 4:

Anil, will this cause any downstream failures because we don't have any initial ISH image checked in yet?

We would need the changes in FIT config for the shim loader (https://chrome-internal-review.googlesource.com/c/chromeos/overlays/baseboard-deltaur-private/+/2872770)

If we are planning to merge the ISH changes i will remove the DONOT MERGE from the fit config patch

@Li, Can you please confirm if these two patches are sufficient for ISH enablement on coreboot side?
Am i missing any other dependencies ? I saw the GPIO pin mux settings already taken care of in gpio.c
https://review.coreboot.org/c/coreboot/+/40537
https://chrome-internal-review.googlesource.com/c/chromeos/overlays/baseboard-deltaur-private/+/2872770
In board Kconfig file, should do "select DRIVERS_INTEL_ISH" to load ISH driver.

View Change

To view, visit change 40537. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic701f224452731e43207836882d649580b76db3a
Gerrit-Change-Number: 40537
Gerrit-PatchSet: 4
Gerrit-Owner: Anil Kumar K <anil.kumar.k@intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k@intel.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego@intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-Reviewer: Li Feng <li1.feng@intel.corp-partner.google.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 30 Apr 2020 18:44:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment