Patch Set 4:

Patch Set 4:

Patch Set 4:

Patch Set 4:

Anil, will this cause any downstream failures because we don't have any initial ISH image checked in yet?

We would need the changes in FIT config for the shim loader (https://chrome-internal-review.googlesource.com/c/chromeos/overlays/baseboard-deltaur-private/+/2872770)

If we are planning to merge the ISH changes i will remove the DONOT MERGE from the fit config patch

@Li, Can you please confirm if these two patches are sufficient for ISH enablement on coreboot side?
Am i missing any other dependencies ? I saw the GPIO pin mux settings already taken care of in gpio.c
https://review.coreboot.org/c/coreboot/+/40537
https://chrome-internal-review.googlesource.com/c/chromeos/overlays/baseboard-deltaur-private/+/2872770
In board Kconfig file, should do "select DRIVERS_INTEL_ISH" to load ISH driver.

Hi Li,

I see this already there in the Kconfig
config BOARD_GOOGLE_BASEBOARD_DELTAUR
        def_bool n
        select BOARD_ROMSIZE_KB_32768
        select DRIVERS_I2C_GENERIC
        select DRIVERS_INTEL_ISH
        ...

Sounds good. This should be OK. but always we have to wait being verified when HW is available.

View Change

To view, visit change 40537. To unsubscribe, or for help writing mail filters, visit settings.