Change in coreboot[master]: emulation/qemu-i440fx: Add \_SB.PCI0.MBRS

[Paul Menzel (Code Review)]

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38304 )

Change subject: emulation/qemu-i440fx: Add _SB.PCI0.MBRS
......................................................................

emulation/qemu-i440fx: Add _SB.PCI0.MBRS

Linux 5.4.8 shows the ACPI error below.

[    0.732324] ACPI BIOS Error (bug): Could not resolve symbol [_SB.PCI0.MBRS], AE_NOT_FOUND (20190816/dswload2-159)
    [    0.732784] ACPI Error: AE_NOT_FOUND, During name lookup/catalog (20190816/psobject-220)

So, add that symbol. Copied from (removed)
`src/mainboard/hp/dl145_g1/dsdt.asl`.

Change-Id: I0243f6a469f5addbf2f09f3aed52d1a067b22cc9
Signed-off-by: Paul Menzel 
---
M src/mainboard/emulation/qemu-i440fx/dsdt.asl
1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/38304/1

diff --git a/src/mainboard/emulation/qemu-i440fx/dsdt.asl b/src/mainboard/emulation/qemu-i440fx/dsdt.asl
index 9bef7d9..95b4b42 100644
--- a/src/mainboard/emulation/qemu-i440fx/dsdt.asl
+++ b/src/mainboard/emulation/qemu-i440fx/dsdt.asl
@@ -33,6 +33,13 @@

Scope(_SB) {
    	Device(PCI0) {
+			/* Dummy device to hold auto generated reserved resources */
+			Device(MBRS) {
+				Name (_HID, EisaId ("PNP0C02"))
+				Name (_UID, 0x01)
+				External(_CRS) /* Resource Template in SSDT */
+			}
+
    		Name(_HID, EisaId("PNP0A03"))
    		Name(_UID, 1)
    	}

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38304 )

Change subject: emulation/qemu-i440fx: Add _SB.PCI0.MBRS
......................................................................

Patch Set 1:

Does not work. Linux 5.4.8 still does not find this.

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38304 )

Change subject: emulation/qemu-i440fx: Add _SB.PCI0.MBRS
......................................................................

Patch Set 1:
> Patch Set 1:
>
> Although, SeaBIOS doesn’t contain an MBRS section in the ASL/DSL files, the Linux kernel started with the firmware provided by QEMU (SeaBIOS), is not looking for that method there.

It's generated by southbridge/intel/i82371eb/isa.c , but as the DSDT is generated by qemu it cannot find the Device. A check if board is not qemu would fix that.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38304 )

Change subject: emulation/qemu-i440fx: Add _SB.PCI0.MBRS
......................................................................

Patch Set 1:

Probably superseded by I770047610e02c08191613b57c989b3bc1d464684 [1].

[1]: https://review.coreboot.org/c/coreboot/+/41457.

[XS] Change in coreboot[master]: emulation/qemu-i440fx: Add \_SB.PCI0.MBRS

[Stefan Reinauer (Code Review)]

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38304?usp=email )

Change subject: emulation/qemu-i440fx: Add _SB.PCI0.MBRS
......................................................................

Abandoned