Change in coreboot[master]: soc/amd/common: Use only byte access for IOMUX

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42978 )

Change subject: soc/amd/common: Use only byte access for IOMUX
......................................................................

soc/amd/common: Use only byte access for IOMUX

Change-Id: Ia3c4fb41b5851b1c0ffc6bbec7d1c051e232fc94
Signed-off-by: Kyösti Mälkki 
---
M src/soc/amd/common/block/include/amdblocks/acpimmio.h
1 file changed, 2 insertions(+), 20 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42978/1

diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h
index e684e36..34300af 100644
--- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h
+++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h
@@ -239,36 +239,18 @@
    write8(acpimmio_smbus + reg, value);
 }

+/* These iomux_read/write8 are to be deprecated to enforce proper
+   use of <gpio.h> API for pin configurations. */
 static inline uint8_t iomux_read8(uint8_t reg)
 {
    return read8(acpimmio_iomux + reg);
 }

-static inline uint16_t iomux_read16(uint8_t reg)
-{
-	return read16(acpimmio_iomux + reg);
-}
-
-static inline uint32_t iomux_read32(uint8_t reg)
-{
-	return read32(acpimmio_iomux + reg);
-}
-
 static inline void iomux_write8(uint8_t reg, uint8_t value)
 {
    write8(acpimmio_iomux + reg, value);
 }

-static inline void iomux_write16(uint8_t reg, uint16_t value)
-{
-	write16(acpimmio_iomux + reg, value);
-}
-
-static inline void iomux_write32(uint8_t reg, uint32_t value)
-{
-	write32(acpimmio_iomux + reg, value);
-}
-
 static inline uint8_t misc_read8(uint8_t reg)
 {
    return read8(acpimmio_misc + reg);

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42978 )

Change subject: soc/amd/common: Use only byte access for IOMUX
......................................................................

Patch Set 2: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42978 )

Change subject: soc/amd/common: Use only byte access for IOMUX
......................................................................

Patch Set 3: Code-Review+2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42978 )

Change subject: soc/amd/common: Use only byte access for IOMUX
......................................................................

Abandoned

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has restored this change. ( https://review.coreboot.org/c/coreboot/+/42978 )

Change subject: soc/amd/common: Use only byte access for IOMUX
......................................................................

Restored

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42978 )

Change subject: soc/amd/common: Use only byte access for IOMUX
......................................................................

Patch Set 3: Code-Review+2

[Hung-Te Lin (Code Review)]

Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42978 )

Change subject: soc/amd/common: Use only byte access for IOMUX
......................................................................

soc/amd/common: Use only byte access for IOMUX

Change-Id: Ia3c4fb41b5851b1c0ffc6bbec7d1c051e232fc94
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42978
Reviewed-by: Angel Pons 
Reviewed-by: Felix Held 
Reviewed-by: Aaron Durbin 
Tested-by: build bot (Jenkins) 
---
M src/soc/amd/common/block/include/amdblocks/acpimmio.h
1 file changed, 2 insertions(+), 20 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved
  Felix Held: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h
index 134e053..8443d29 100644
--- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h
+++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h
@@ -259,36 +259,18 @@
    write8(acpimmio_smbus + reg, value);
 }

+/* These iomux_read/write8 are to be deprecated to enforce proper
+   use of <gpio.h> API for pin configurations. */
 static inline uint8_t iomux_read8(uint8_t reg)
 {
    return read8(acpimmio_iomux + reg);
 }

-static inline uint16_t iomux_read16(uint8_t reg)
-{
-	return read16(acpimmio_iomux + reg);
-}
-
-static inline uint32_t iomux_read32(uint8_t reg)
-{
-	return read32(acpimmio_iomux + reg);
-}
-
 static inline void iomux_write8(uint8_t reg, uint8_t value)
 {
    write8(acpimmio_iomux + reg, value);
 }

-static inline void iomux_write16(uint8_t reg, uint16_t value)
-{
-	write16(acpimmio_iomux + reg, value);
-}
-
-static inline void iomux_write32(uint8_t reg, uint32_t value)
-{
-	write32(acpimmio_iomux + reg, value);
-}
-
 static inline uint8_t misc_read8(uint8_t reg)
 {
    return read8(acpimmio_misc + reg);