Hung-Te Lin submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Felix Held: Looks good to me, approved Angel Pons: Looks good to me, approved
soc/amd/common: Use only byte access for IOMUX

Change-Id: Ia3c4fb41b5851b1c0ffc6bbec7d1c051e232fc94
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42978
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/soc/amd/common/block/include/amdblocks/acpimmio.h
1 file changed, 2 insertions(+), 20 deletions(-)

diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h
index 134e053..8443d29 100644
--- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h
+++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h
@@ -259,36 +259,18 @@
write8(acpimmio_smbus + reg, value);
}

+/* These iomux_read/write8 are to be deprecated to enforce proper
+ use of <gpio.h> API for pin configurations. */
static inline uint8_t iomux_read8(uint8_t reg)
{
return read8(acpimmio_iomux + reg);
}

-static inline uint16_t iomux_read16(uint8_t reg)
-{
- return read16(acpimmio_iomux + reg);
-}
-
-static inline uint32_t iomux_read32(uint8_t reg)
-{
- return read32(acpimmio_iomux + reg);
-}
-
static inline void iomux_write8(uint8_t reg, uint8_t value)
{
write8(acpimmio_iomux + reg, value);
}

-static inline void iomux_write16(uint8_t reg, uint16_t value)
-{
- write16(acpimmio_iomux + reg, value);
-}
-
-static inline void iomux_write32(uint8_t reg, uint32_t value)
-{
- write32(acpimmio_iomux + reg, value);
-}
-
static inline uint8_t misc_read8(uint8_t reg)
{
return read8(acpimmio_misc + reg);

To view, visit change 42978. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3c4fb41b5851b1c0ffc6bbec7d1c051e232fc94
Gerrit-Change-Number: 42978
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged