Change in coreboot[master]: mb/google/octopus/variants/casta: Add support zinitix touchpad
Hello SH Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/48634
to review the following change.
Change subject: mb/google/octopus/variants/casta: Add support zinitix touchpad ......................................................................
mb/google/octopus/variants/casta: Add support zinitix touchpad
This change adds support zinitix touchpad for casta/bluebird.
BRANCH=firmware-octopus-11297.B BUG=b:175618033 TEST=built and verified touchpad worked on casta
Change-Id: I1a8f562de19d1a8160d52c65400553f0c68393e0 Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com --- M src/mainboard/google/octopus/variants/casta/overridetree.cb 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/48634/1
diff --git a/src/mainboard/google/octopus/variants/casta/overridetree.cb b/src/mainboard/google/octopus/variants/casta/overridetree.cb index 3f2a884..be322f5 100644 --- a/src/mainboard/google/octopus/variants/casta/overridetree.cb +++ b/src/mainboard/google/octopus/variants/casta/overridetree.cb @@ -137,6 +137,16 @@ register "probed" = "1" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""ZNT0000"" + register "generic.cid" = ""PNP0C50"" + register "generic.desc" = ""Zinitix Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)" + register "generic.wake" = "GPE0_DW3_27" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0xE" + device i2c 40 on end + end end # - I2C 6 end
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48634 )
Change subject: mb/google/octopus/variants/casta: Add support zinitix touchpad ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48634/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/casta/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48634/1/src/mainboard/google/octopu... PS1, Line 142: register "generic.cid" = ""PNP0C50"" nit: This is not really required. It is set by the hid driver in corebot.
SH Kim has uploaded a new patch set (#2) to the change originally created by shkim. ( https://review.coreboot.org/c/coreboot/+/48634 )
Change subject: mb/google/octopus/variants/casta: Add support zinitix touchpad ......................................................................
mb/google/octopus/variants/casta: Add support zinitix touchpad
This change adds support zinitix touchpad for casta/bluebird.
BRANCH=firmware-octopus-11297.B BUG=b:175618033 TEST=built and verified touchpad worked on casta
Change-Id: I1a8f562de19d1a8160d52c65400553f0c68393e0 Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com --- M src/mainboard/google/octopus/variants/casta/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/48634/2
SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48634 )
Change subject: mb/google/octopus/variants/casta: Add support zinitix touchpad ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48634/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/casta/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48634/1/src/mainboard/google/octopu... PS1, Line 142: register "generic.cid" = ""PNP0C50""
nit: This is not really required. It is set by the hid driver in corebot.
Verified touchpad worked after removing this as well. Thanks.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48634 )
Change subject: mb/google/octopus/variants/casta: Add support zinitix touchpad ......................................................................
Patch Set 2: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48634 )
Change subject: mb/google/octopus/variants/casta: Add support zinitix touchpad ......................................................................
mb/google/octopus/variants/casta: Add support zinitix touchpad
This change adds support zinitix touchpad for casta/bluebird.
BRANCH=firmware-octopus-11297.B BUG=b:175618033 TEST=built and verified touchpad worked on casta
Change-Id: I1a8f562de19d1a8160d52c65400553f0c68393e0 Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48634 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/casta/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/casta/overridetree.cb b/src/mainboard/google/octopus/variants/casta/overridetree.cb index 3f2a884..a09bcbb 100644 --- a/src/mainboard/google/octopus/variants/casta/overridetree.cb +++ b/src/mainboard/google/octopus/variants/casta/overridetree.cb @@ -137,6 +137,15 @@ register "probed" = "1" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""ZNT0000"" + register "generic.desc" = ""Zinitix Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)" + register "generic.wake" = "GPE0_DW3_27" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0xE" + device i2c 40 on end + end end # - I2C 6 end
-
Furquan Shaikh (Code Review) -
Hung-Te Lin (Code Review)
-
SH Kim (Code Review)
-
shkim (Code Review)