Julia Tsai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44074 )
Change subject: CreateLindarvariant ......................................................................
CreateLindarvariant
Signed-off-by: Julia Tsai julia.tsai@lcfc.corp-partner.google.com Change-Id: I08923cde932b7304bcb01cd747530c87949e4692 --- A src/mainboard/google/volteer/variants/lindar/include/variant/ec.h A src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h A src/mainboard/google/volteer/variants/lindar/overridetree.cb 3 files changed, 29 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/44074/1
diff --git a/src/mainboard/google/volteer/variants/lindar/include/variant/ec.h b/src/mainboard/google/volteer/variants/lindar/include/variant/ec.h new file mode 100644 index 0000000..7a2a6ff --- /dev/null +++ b/src/mainboard/google/volteer/variants/lindar/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __VARIANT_EC_H__ +#define __VARIANT_EC_H__ + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h b/src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h new file mode 100644 index 0000000..b5fa8c5 --- /dev/null +++ b/src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef VARIANT_GPIO_H +#define VARIANT_GPIO_H + +#include <baseboard/gpio.h> + +/* Memory configuration board straps */ +/* Copied from baseboard and may need to change for the new variant. */ +#define GPIO_MEM_CONFIG_0 GPP_C12 +#define GPIO_MEM_CONFIG_1 GPP_C15 +#define GPIO_MEM_CONFIG_2 GPP_C14 +#define GPIO_MEM_CONFIG_3 GPP_D15 + +#endif diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb new file mode 100644 index 0000000..32204c5 --- /dev/null +++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb @@ -0,0 +1,6 @@ +chip soc/intel/tigerlake + + device domain 0 on + end + +end
Julia Tsai has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/44074 )
Change subject: volteer: Create lindar variant ......................................................................
volteer: Create lindar variant
Create the lindar variant of the volteer reference board by copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.1.2).
BUG=b:161089195 BRANCH=None TEST=util/abuild/abuild -p none -t google/volteer -x -a make sure the build includes GOOGLE_LINDAR
Signed-off-by: Julia Tsai julia.tsai@lcfc.corp-partner.google.com Change-Id: I08923cde932b7304bcb01cd747530c87949e4692 --- A src/mainboard/google/volteer/variants/lindar/include/variant/ec.h A src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h A src/mainboard/google/volteer/variants/lindar/overridetree.cb 3 files changed, 29 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/44074/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44074
to look at the new patch set (#3).
Change subject: CreateLindarvariant ......................................................................
CreateLindarvariant
Signed-off-by: Julia Tsai julia.tsai@lcfc.corp-partner.google.com Change-Id: I08923cde932b7304bcb01cd747530c87949e4692 --- A src/mainboard/google/volteer/variants/lindar/include/variant/ec.h A src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h A src/mainboard/google/volteer/variants/lindar/overridetree.cb 3 files changed, 29 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/44074/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44074
to look at the new patch set (#4).
Change subject: volteer: Create lindar variant ......................................................................
volteer: Create lindar variant
Create the lindar variant of the volteer reference board by copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.1.2).
BUG=b:161089195 BRANCH=None TEST=util/abuild/abuild -p none -t google/volteer -x -a make sure the build includes GOOGLE_LINDAR
Signed-off-by: Julia Tsai julia.tsai@lcfc.corp-partner.google.com Change-Id: I08923cde932b7304bcb01cd747530c87949e4692 --- A src/mainboard/google/volteer/variants/lindar/include/variant/ec.h A src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h A src/mainboard/google/volteer/variants/lindar/overridetree.cb 3 files changed, 29 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/44074/4
Julia Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44074 )
Change subject: volteer: Create lindar variant ......................................................................
Patch Set 8:
This change is ready for review.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44074 )
Change subject: volteer: Create lindar variant ......................................................................
Patch Set 8: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... PS8, Line 9: /* Copied from baseboard and may need to change for the new variant. */ I'd prefer if this would be corrected here instead of on CB:44079
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... PS8, Line 2: I'd prefer if this would be filled in here instead of on CB:44080
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44074 )
Change subject: volteer: Create lindar variant ......................................................................
Patch Set 8: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... PS8, Line 9: /* Copied from baseboard and may need to change for the new variant. */
I'd prefer if this would be corrected here instead of on CB:44079
This is generated by the tool https://chromium.googlesource.com/chromiumos/platform/dev-util/+/refs/heads/... and template https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/uti... .
I vote to split the gpio setting to the other patch.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44074 )
Change subject: volteer: Create lindar variant ......................................................................
Patch Set 8: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... PS8, Line 9: /* Copied from baseboard and may need to change for the new variant. */
This is generated by the tool https://chromium.googlesource. […]
i would also prefer to see the auto-generated changes as a separate patch from human edits, specially here since this sets up the framework for variant specific work.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44074 )
Change subject: volteer: Create lindar variant ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... PS8, Line 9: /* Copied from baseboard and may need to change for the new variant. */
i would also prefer to see the auto-generated changes as a separate patch […]
IMHO, when adding a new board, the first commit should be able to make it boot. I'm not going to block this from going in as separate commits, but I'd prefer to do it in a single commit.
Plus, there's dependencies between GPIO and devicetree settings: e.g. if UART 1 is enabled, its pins need to use the UART native function and can't be used as GPIOs. Having separate patches for GPIO and devicetree settings makes it harder to compare both.
Julia Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44074 )
Change subject: volteer: Create lindar variant ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... PS8, Line 9: /* Copied from baseboard and may need to change for the new variant. */
IMHO, when adding a new board, the first commit should be able to make it boot. […]
Then I will combine GPIO and devicetree setting in same CL, Can we merge this initial CL?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44074 )
Change subject: volteer: Create lindar variant ......................................................................
Patch Set 8: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... PS8, Line 9: /* Copied from baseboard and may need to change for the new variant. */
Then I will combine GPIO and devicetree setting in same CL, Can we merge this initial CL?
Sounds good.
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... PS8, Line 2:
I'd prefer if this would be filled in here instead of on CB:44080
Ack
Jerry2 Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44074 )
Change subject: volteer: Create lindar variant ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... PS8, Line 2:
Ack
done
Julia Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44074 )
Change subject: volteer: Create lindar variant ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... PS8, Line 9: /* Copied from baseboard and may need to change for the new variant. */
Sounds good.
Done for CL 44079
Julia Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44074 )
Change subject: volteer: Create lindar variant ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... PS8, Line 2:
done
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44074 )
Change subject: volteer: Create lindar variant ......................................................................
volteer: Create lindar variant
Create the lindar variant of the volteer reference board by copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.1.2).
BUG=b:161089195 BRANCH=None TEST=util/abuild/abuild -p none -t google/volteer -x -a make sure the build includes GOOGLE_LINDAR
Signed-off-by: Julia Tsai julia.tsai@lcfc.corp-partner.google.com Change-Id: I08923cde932b7304bcb01cd747530c87949e4692 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44074 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Zhuohao Lee zhuohao@google.com Reviewed-by: Caveh Jalali caveh@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/Kconfig.name A src/mainboard/google/volteer/variants/lindar/include/variant/ec.h A src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h A src/mainboard/google/volteer/variants/lindar/overridetree.cb 5 files changed, 36 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved Zhuohao Lee: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 82edb82..baa71cb 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -71,6 +71,7 @@ default "Delbin" if BOARD_GOOGLE_DELBIN default "Eldrid" if BOARD_GOOGLE_ELDRID default "Halvor" if BOARD_GOOGLE_HALVOR + default "Lindar" if BOARD_GOOGLE_LINDAR default "Malefor" if BOARD_GOOGLE_MALEFOR default "Terrador" if BOARD_GOOGLE_TERRADOR default "Todor" if BOARD_GOOGLE_TODOR @@ -106,6 +107,7 @@ default "delbin" if BOARD_GOOGLE_DELBIN default "eldrid" if BOARD_GOOGLE_ELDRID default "halvor" if BOARD_GOOGLE_HALVOR + default "lindar" if BOARD_GOOGLE_LINDAR default "malefor" if BOARD_GOOGLE_MALEFOR default "terrador" if BOARD_GOOGLE_TERRADOR default "todor" if BOARD_GOOGLE_TODOR diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index f88f63e..1d9a3db 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -14,6 +14,11 @@ select BOARD_GOOGLE_BASEBOARD_VOLTEER select SOC_INTEL_CSE_LITE_SKU
+config BOARD_GOOGLE_LINDAR + bool "-> Lindar" + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select SOC_INTEL_CSE_LITE_SKU + config BOARD_GOOGLE_MALEFOR bool "-> Malefor" select BOARD_GOOGLE_BASEBOARD_VOLTEER diff --git a/src/mainboard/google/volteer/variants/lindar/include/variant/ec.h b/src/mainboard/google/volteer/variants/lindar/include/variant/ec.h new file mode 100644 index 0000000..7a2a6ff --- /dev/null +++ b/src/mainboard/google/volteer/variants/lindar/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __VARIANT_EC_H__ +#define __VARIANT_EC_H__ + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h b/src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h new file mode 100644 index 0000000..b5fa8c5 --- /dev/null +++ b/src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef VARIANT_GPIO_H +#define VARIANT_GPIO_H + +#include <baseboard/gpio.h> + +/* Memory configuration board straps */ +/* Copied from baseboard and may need to change for the new variant. */ +#define GPIO_MEM_CONFIG_0 GPP_C12 +#define GPIO_MEM_CONFIG_1 GPP_C15 +#define GPIO_MEM_CONFIG_2 GPP_C14 +#define GPIO_MEM_CONFIG_3 GPP_D15 + +#endif diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb new file mode 100644 index 0000000..32204c5 --- /dev/null +++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb @@ -0,0 +1,6 @@ +chip soc/intel/tigerlake + + device domain 0 on + end + +end