Patch set 8:Code-Review +1
1 comment:
File src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h:
Patch Set #8, Line 9: /* Copied from baseboard and may need to change for the new variant. */
I'd prefer if this would be corrected here instead of on CB:44079
This is generated by the tool https://chromium.googlesource.com/chromiumos/platform/dev-util/+/refs/heads/master/contrib/variant/create_coreboot_variant.sh and template https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/util/mainboard/google/volteer/template .
I vote to split the gpio setting to the other patch.
To view, visit change 44074. To unsubscribe, or for help writing mail filters, visit settings.