Furquan Shaikh submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved Zhuohao Lee: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
volteer: Create lindar variant

Create the lindar variant of the volteer reference board by copying
the template files to a new directory named for the variant.

(Auto-Generated by create_coreboot_variant.sh version 4.1.2).

BUG=b:161089195
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_LINDAR

Signed-off-by: Julia Tsai <julia.tsai@lcfc.corp-partner.google.com>
Change-Id: I08923cde932b7304bcb01cd747530c87949e4692
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44074
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Zhuohao Lee <zhuohao@google.com>
Reviewed-by: Caveh Jalali <caveh@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/lindar/include/variant/ec.h
A src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h
A src/mainboard/google/volteer/variants/lindar/overridetree.cb
5 files changed, 36 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig
index 82edb82..baa71cb 100644
--- a/src/mainboard/google/volteer/Kconfig
+++ b/src/mainboard/google/volteer/Kconfig
@@ -71,6 +71,7 @@
default "Delbin" if BOARD_GOOGLE_DELBIN
default "Eldrid" if BOARD_GOOGLE_ELDRID
default "Halvor" if BOARD_GOOGLE_HALVOR
+ default "Lindar" if BOARD_GOOGLE_LINDAR
default "Malefor" if BOARD_GOOGLE_MALEFOR
default "Terrador" if BOARD_GOOGLE_TERRADOR
default "Todor" if BOARD_GOOGLE_TODOR
@@ -106,6 +107,7 @@
default "delbin" if BOARD_GOOGLE_DELBIN
default "eldrid" if BOARD_GOOGLE_ELDRID
default "halvor" if BOARD_GOOGLE_HALVOR
+ default "lindar" if BOARD_GOOGLE_LINDAR
default "malefor" if BOARD_GOOGLE_MALEFOR
default "terrador" if BOARD_GOOGLE_TERRADOR
default "todor" if BOARD_GOOGLE_TODOR
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name
index f88f63e..1d9a3db 100644
--- a/src/mainboard/google/volteer/Kconfig.name
+++ b/src/mainboard/google/volteer/Kconfig.name
@@ -14,6 +14,11 @@
select BOARD_GOOGLE_BASEBOARD_VOLTEER
select SOC_INTEL_CSE_LITE_SKU

+config BOARD_GOOGLE_LINDAR
+ bool "-> Lindar"
+ select BOARD_GOOGLE_BASEBOARD_VOLTEER
+ select SOC_INTEL_CSE_LITE_SKU
+
config BOARD_GOOGLE_MALEFOR
bool "-> Malefor"
select BOARD_GOOGLE_BASEBOARD_VOLTEER
diff --git a/src/mainboard/google/volteer/variants/lindar/include/variant/ec.h b/src/mainboard/google/volteer/variants/lindar/include/variant/ec.h
new file mode 100644
index 0000000..7a2a6ff
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/lindar/include/variant/ec.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef __VARIANT_EC_H__
+#define __VARIANT_EC_H__
+
+#include <baseboard/ec.h>
+
+#endif
diff --git a/src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h b/src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h
new file mode 100644
index 0000000..b5fa8c5
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef VARIANT_GPIO_H
+#define VARIANT_GPIO_H
+
+#include <baseboard/gpio.h>
+
+/* Memory configuration board straps */
+/* Copied from baseboard and may need to change for the new variant. */
+#define GPIO_MEM_CONFIG_0 GPP_C12
+#define GPIO_MEM_CONFIG_1 GPP_C15
+#define GPIO_MEM_CONFIG_2 GPP_C14
+#define GPIO_MEM_CONFIG_3 GPP_D15
+
+#endif
diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
new file mode 100644
index 0000000..32204c5
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
@@ -0,0 +1,6 @@
+chip soc/intel/tigerlake
+
+ device domain 0 on
+ end
+
+end

To view, visit change 44074. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08923cde932b7304bcb01cd747530c87949e4692
Gerrit-Change-Number: 44074
Gerrit-PatchSet: 9
Gerrit-Owner: Julia Tsai <julia.tsai@lcfc.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Zhuohao Lee <zhuohao@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang@lcfc.corp-partner.google.com>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh@lcfc.corp-partner.google.com>
Gerrit-MessageType: merged