Change in coreboot[master]: mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Matt DeVillier (Code Review)

1 May 2020 1 May '20

6:49 p.m.

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40950 )

Change subject: mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe ......................................................................

mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe

Per the schematics, SRCCLKREQ2# is used for the NVMe and should be enabled. Enable CLKREQ for PCIe RP9 to match the comment, and just comment to indicate correct value per schematic.

Test: build/boot Librem 15v3 with NVMe drive, verify drive identified properly and no errors in boot log.

Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: I159cb7ce1f5195d95c0229490c3bbde26edbd375 --- M src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/40950/1

diff --git a/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb b/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb index 308688a..d9c4f14 100644 --- a/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb +++ b/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb @@ -164,8 +164,8 @@ register "PcieRpEnable[4]" = "1" register "PcieRpEnable[8]" = "1" # Enable CLKREQ# for RP9 - register "PcieRpClkReqSupport[8]" = "0" - # ClkReq for NVMe - Bruteforced (no other value works) + register "PcieRpClkReqSupport[8]" = "1" + # SRCCLKREQ2# for NVMe per schematic register "PcieRpClkReqNumber[8]" = "2"

Attachments:

attachment.htm (text/html — 3.2 KB)

Show replies by date

Matt DeVillier (Code Review)

1 May 1 May

6:58 p.m.

Hello Nico Huber, Paul Menzel, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40950

to look at the new patch set (#2).

Change subject: mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe ......................................................................

mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe

Per the schematics, SRCCLKREQ2# is used for the NVMe and should be enabled. Enable CLKREQ for PCIe RP9, and adjust comments to indicate correct value used per schematic.

Test: build/boot Librem 15v3 with NVMe drive, verify drive identified properly and no errors in boot log.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/40950/2

Michael Niewöhner (Code Review)

9:41 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40950 )

Change subject: mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/40950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I159cb7ce1f5195d95c0229490c3bbde26edbd375 Gerrit-Change-Number: 40950 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 May 2020 21:41:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

9:44 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40950 )

Change subject: mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I159cb7ce1f5195d95c0229490c3bbde26edbd375 Gerrit-Change-Number: 40950 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 May 2020 21:44:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

3 May 3 May

2:44 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40950 )

Change subject: mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I159cb7ce1f5195d95c0229490c3bbde26edbd375 Gerrit-Change-Number: 40950 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 03 May 2020 02:44:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

4 May 4 May

1:24 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40950 )

Change subject: mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40950/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40950/2//COMMIT_MSG@14 PS2, Line 14: properly and no errors in boot log. So before there were problems? Please cite one of these errors, so users with such an error may search with that.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I159cb7ce1f5195d95c0229490c3bbde26edbd375 Gerrit-Change-Number: 40950 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 May 2020 13:24:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Matt DeVillier (Code Review)

3:15 p.m.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40950 )

Change subject: mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40950/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40950/2//COMMIT_MSG@14 PS2, Line 14: properly and no errors in boot log.

...

So before there were problems? Please cite one of these errors, so users with such an error may sear […]

any errors that might have occurred were early on when this board was initially ported without schematics, and the proper PCIe SRCCLK was not known, hence the trial and error in the original comment. The test comment here only serves to indicate that there were no issues with the change, enabling SRCCLK usage for the NVMe drive

-- To view, visit https://review.coreboot.org/c/coreboot/+/40950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I159cb7ce1f5195d95c0229490c3bbde26edbd375 Gerrit-Change-Number: 40950 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 May 2020 15:15:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Paul Menzel (Code Review)

5:08 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40950 )

Change subject: mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40950/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40950/2//COMMIT_MSG@14 PS2, Line 14: properly and no errors in boot log.

...

any errors that might have occurred were early on when this board was initially ported without schem […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/40950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I159cb7ce1f5195d95c0229490c3bbde26edbd375 Gerrit-Change-Number: 40950 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 May 2020 17:08:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Georgi (Code Review)

6:52 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40950 )

Change subject: mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe ......................................................................

mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe

Per the schematics, SRCCLKREQ2# is used for the NVMe and should be enabled. Enable CLKREQ for PCIe RP9, and adjust comments to indicate correct value used per schematic.

Test: build/boot Librem 15v3 with NVMe drive, verify drive identified properly and no errors in boot log.

Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: I159cb7ce1f5195d95c0229490c3bbde26edbd375 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40950 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved Michael Niewöhner: Looks good to me, but someone else must approve

diff --git a/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb b/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb index d273462..ceeeb43 100644 --- a/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb +++ b/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb @@ -167,8 +167,8 @@ register "PcieRpEnable[4]" = "1" register "PcieRpEnable[8]" = "1" # Enable CLKREQ# for RP9 - register "PcieRpClkReqSupport[8]" = "0" - # ClkReq for NVMe - Bruteforced (no other value works) + register "PcieRpClkReqSupport[8]" = "1" + # SRCCLKREQ2# for NVMe per schematic register "PcieRpClkReqNumber[8]" = "2"

-- To view, visit https://review.coreboot.org/c/coreboot/+/40950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I159cb7ce1f5195d95c0229490c3bbde26edbd375 Gerrit-Change-Number: 40950 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

7:05 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40950 )

Change subject: mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe ......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3187 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3186 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3185 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3184

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/40950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I159cb7ce1f5195d95c0229490c3bbde26edbd375 Gerrit-Change-Number: 40950 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Mon, 04 May 2020 19:05:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1460

days inactive

1463

days old

coreboot-gerrit@coreboot.org

9 comments

7 participants

tags (0)

participants (7)

9elements QA (Code Review)
Angel Pons (Code Review)
Matt DeVillier (Code Review)
Michael Niewöhner (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)