
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40950 ) Change subject: mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/40950/2//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40950/2//COMMIT_MSG@14 PS2, Line 14: properly and no errors in boot log.
So before there were problems? Please cite one of these errors, so users with such an error may sear […] any errors that might have occurred were early on when this board was initially ported without schematics, and the proper PCIe SRCCLK was not known, hence the trial and error in the original comment. The test comment here only serves to indicate that there were no issues with the change, enabling SRCCLK usage for the NVMe drive
-- To view, visit https://review.coreboot.org/c/coreboot/+/40950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I159cb7ce1f5195d95c0229490c3bbde26edbd375 Gerrit-Change-Number: 40950 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 04 May 2020 15:15:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment