Change in coreboot[master]: Documentation: Update vboot on lenovo
Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40775 ) Change subject: Documentation: Update vboot on lenovo ...................................................................... Documentation: Update vboot on lenovo Update the documentation now that CB:32705 is merged. Change-Id: I9845c0750ec4016188478154610400d1b8556793 Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> --- M Documentation/mainboard/lenovo/vboot.md 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/40775/1 diff --git a/Documentation/mainboard/lenovo/vboot.md b/Documentation/mainboard/lenovo/vboot.md index 4e1b946..24fbdad 100644 --- a/Documentation/mainboard/lenovo/vboot.md +++ b/Documentation/mainboard/lenovo/vboot.md @@ -18,8 +18,8 @@ partition that acts as failsafe in case the regular firmware update, that goes to the `A` or `B` partition fails. -**Note:** The `RO` partition isn't write-protected by default. There's a patch -pending on gerrit [CB:32705] that write-protects the `RO` partition. +**Note:** The `RO` partition isn't write-protected by default, as you +have to enable the protection in the security Kconfig menu by yourself. On *Lenovo* devices you can enable the *Fn* key as recovery mode switch, by enabling `CONFIG_H8_FN_KEY_AS_VBOOT_RECOVERY_SW`. @@ -35,5 +35,4 @@ [vboot] on *Lenovo* devices uses the CMOS to store configuration data, like boot failures and the last successfully booted partition. -[CB:32705]: https://review.coreboot.org/32705 [vboot]: ../../security/vboot/index.md -- To view, visit https://review.coreboot.org/c/coreboot/+/40775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9845c0750ec4016188478154610400d1b8556793 Gerrit-Change-Number: 40775 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-MessageType: newchange
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40775 ) Change subject: Documentation: Update vboot on lenovo ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/40775/1/Documentation/mainboard/len... File Documentation/mainboard/lenovo/vboot.md: https://review.coreboot.org/c/coreboot/+/40775/1/Documentation/mainboard/len... PS1, Line 21: as "so", "therefore"? -- To view, visit https://review.coreboot.org/c/coreboot/+/40775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9845c0750ec4016188478154610400d1b8556793 Gerrit-Change-Number: 40775 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Patrick Georgi <pgeorgi@google.com> Gerrit-Comment-Date: Tue, 28 Apr 2020 06:15:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Marcello Sylvester Bauer has uploaded a new patch set (#2) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/40775 ) Change subject: Documentation: Update vboot on lenovo ...................................................................... Documentation: Update vboot on lenovo Update the documentation now that CB:32705 is merged. Change-Id: I9845c0750ec4016188478154610400d1b8556793 Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> --- M Documentation/mainboard/lenovo/vboot.md 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/40775/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/40775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9845c0750ec4016188478154610400d1b8556793 Gerrit-Change-Number: 40775 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv@sylv.io> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi@google.com> Gerrit-MessageType: newpatchset
Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40775 ) Change subject: Documentation: Update vboot on lenovo ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/40775/1/Documentation/mainboard/len... File Documentation/mainboard/lenovo/vboot.md: https://review.coreboot.org/c/coreboot/+/40775/1/Documentation/mainboard/len... PS1, Line 21: as
"so", "therefore"? Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9845c0750ec4016188478154610400d1b8556793 Gerrit-Change-Number: 40775 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv@sylv.io> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi@google.com> Gerrit-Comment-Date: Mon, 04 May 2020 11:44:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Patrick Georgi <pgeorgi@google.com> Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40775 ) Change subject: Documentation: Update vboot on lenovo ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/40775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9845c0750ec4016188478154610400d1b8556793 Gerrit-Change-Number: 40775 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv@sylv.io> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi@google.com> Gerrit-Comment-Date: Mon, 04 May 2020 12:33:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40775 ) Change subject: Documentation: Update vboot on lenovo ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/40775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9845c0750ec4016188478154610400d1b8556793 Gerrit-Change-Number: 40775 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv@sylv.io> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 04 May 2020 19:17:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40775 ) Change subject: Documentation: Update vboot on lenovo ...................................................................... Documentation: Update vboot on lenovo Update the documentation now that CB:32705 is merged. Change-Id: I9845c0750ec4016188478154610400d1b8556793 Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/40775 Reviewed-by: Marcello Sylvester Bauer <sylv@sylv.io> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> --- M Documentation/mainboard/lenovo/vboot.md 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Marcello Sylvester Bauer: Looks good to me, but someone else must approve diff --git a/Documentation/mainboard/lenovo/vboot.md b/Documentation/mainboard/lenovo/vboot.md index 4e1b946..3f15360 100644 --- a/Documentation/mainboard/lenovo/vboot.md +++ b/Documentation/mainboard/lenovo/vboot.md @@ -18,8 +18,8 @@ partition that acts as failsafe in case the regular firmware update, that goes to the `A` or `B` partition fails. -**Note:** The `RO` partition isn't write-protected by default. There's a patch -pending on gerrit [CB:32705] that write-protects the `RO` partition. +**Note:** The `RO` partition isn't write-protected by default, therefore you +have to enable the protection in the security Kconfig menu by yourself. On *Lenovo* devices you can enable the *Fn* key as recovery mode switch, by enabling `CONFIG_H8_FN_KEY_AS_VBOOT_RECOVERY_SW`. @@ -35,5 +35,4 @@ [vboot] on *Lenovo* devices uses the CMOS to store configuration data, like boot failures and the last successfully booted partition. -[CB:32705]: https://review.coreboot.org/32705 [vboot]: ../../security/vboot/index.md -- To view, visit https://review.coreboot.org/c/coreboot/+/40775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9845c0750ec4016188478154610400d1b8556793 Gerrit-Change-Number: 40775 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv@sylv.io> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: merged
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40775 ) Change subject: Documentation: Update vboot on lenovo ...................................................................... Patch Set 3: Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3191 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3190 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3189 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3188 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/40775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9845c0750ec4016188478154610400d1b8556793 Gerrit-Change-Number: 40775 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv@sylv.io> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot@gmail.com> Gerrit-Comment-Date: Mon, 04 May 2020 19:32:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
participants (5)
-
9elements QA (Code Review) -
Marcello Sylvester Bauer (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)