Change in coreboot[master]: acpi: Add support for privacy_gpio

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Ricardo Ribalda (Code Review)

29 Oct 2020 29 Oct '20

2:17 p.m.

Ricardo Ribalda has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: acpi: Add support for privacy_gpio ......................................................................

acpi: Add support for privacy_gpio

Some devices, such as cameras, can implement a physical switch to disable the input on demand. Think of it like the typical privacy sticker on the notebooks, but more elegant.

In order to notify the system about the status this feature, a GPIO is typically used.

The map between a GPIO and the feature is done via ACPI, the same way as the reset_gpio works.

This patch implements an extra field for the described privacy gpio. This gpio does not require any extra handling from the power management.

Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Signed-off-by: Ricardo Ribalda ribalda@chromium.org --- M src/drivers/usb/acpi/chip.h M src/drivers/usb/acpi/usb_acpi.c 2 files changed, 18 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/46961/1

diff --git a/src/drivers/usb/acpi/chip.h b/src/drivers/usb/acpi/chip.h index 8cd9268..4a55cc6 100644 --- a/src/drivers/usb/acpi/chip.h +++ b/src/drivers/usb/acpi/chip.h @@ -45,6 +45,7 @@ struct acpi_pld custom_pld;

struct acpi_gpio reset_gpio; + struct acpi_gpio privacy_gpio; };

#endif /* __USB_ACPI_CHIP_H__ */ diff --git a/src/drivers/usb/acpi/usb_acpi.c b/src/drivers/usb/acpi/usb_acpi.c index d33b7de..9b45483 100644 --- a/src/drivers/usb/acpi/usb_acpi.c +++ b/src/drivers/usb/acpi/usb_acpi.c @@ -13,10 +13,13 @@ /* * Return false if reset GPIO is not provided. */ - if (cfg->reset_gpio.pin_count == 0) - return false; + if (cfg->reset_gpio.pin_count) + return true;

- return true; + if (cfg->privacy_gpio.pin_count) + return true; + + return false; }

static void usb_acpi_fill_ssdt_generator(const struct device *dev) @@ -49,15 +52,23 @@ /* Resources */ if (usb_acpi_add_gpios_to_crs(config) == true) { struct acpi_dp *dsd; + int idx = 0;

acpigen_write_name("_CRS"); acpigen_write_resourcetemplate_header(); - acpi_device_write_gpio(&config->reset_gpio); + if (config->reset_gpio.pin_count) + acpi_device_write_gpio(&config->reset_gpio); + if (config->privacy_gpio.pin_count) + acpi_device_write_gpio(&config->privacy_gpio); acpigen_write_resourcetemplate_footer();

dsd = acpi_dp_new_table("_DSD"); - acpi_dp_add_gpio(dsd, "reset-gpio", path, 0, 0, - config->reset_gpio.active_low); + if (config->reset_gpio.pin_count) + acpi_dp_add_gpio(dsd, "reset-gpio", path, idx++, 0, + config->reset_gpio.active_low); + if (config->privacy_gpio.pin_count) + acpi_dp_add_gpio(dsd, "privacy-gpio", path, idx++, 0, + config->privacy_gpio.active_low); acpi_dp_write(dsd); }

Attachments:

attachment.htm (text/html — 5.8 KB)

Show replies by date

Angel Pons (Code Review)

2 Nov 2 Nov

6:19 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: acpi: Add support for privacy_gpio ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 1 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 02 Nov 2020 18:19:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

4 Nov 4 Nov

10:21 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: acpi: Add support for privacy_gpio ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46961/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46961/1//COMMIT_MSG@7 PS1, Line 7: acpi drivers/usb/acpi

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 1 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 04 Nov 2020 22:21:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

10:33 p.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Hello build bot (Jenkins), Furquan Shaikh, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46961

to look at the new patch set (#2).

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

drivers/usb/acpi: Add support for privacy_gpio

Some devices, such as cameras, can implement a physical switch to disable the input on demand. Think of it like the typical privacy sticker on the notebooks, but more elegant.

In order to notify the system about the status this feature, a GPIO is typically used.

The map between a GPIO and the feature is done via ACPI, the same way as the reset_gpio works.

This patch implements an extra field for the described privacy gpio. This gpio does not require any extra handling from the power management.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/46961/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 2 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Ricardo Ribalda (Code Review)

10:34 p.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46961/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46961/1//COMMIT_MSG@7 PS1, Line 7: acpi

...

drivers/usb/acpi

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 2 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 04 Nov 2020 22:34:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

11:14 p.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46961/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46961/2//COMMIT_MSG@13 PS2, Line 13: In order to notify the system about the status this feature, a GPIO is : typically used. : : The map between a GPIO and the feature is done via ACPI, the same way as : the reset_gpio works. Would you mind pointing me to the patches that implement this on the kernel side?

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 2 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 04 Nov 2020 23:14:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

11:21 p.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46961/2//COMMIT_MSG Commit Message:

...

Would you mind pointing me to the patches that implement this on the kernel side?

For the privacy_pin, this is the series: https://patchwork.linuxtv.org/project/linux-media/list/?series=3787

for the reset_gpio https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/driv... https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docu...

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 2 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 04 Nov 2020 23:21:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

5 Nov 5 Nov

12:27 a.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 2:

(4 comments)

https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/chip.h File src/drivers/usb/acpi/chip.h:

https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/chip.h... PS2, Line 48: privacy If we decide to go with this name, I think we should have a comment block explaining what this is used for and what kind of devices would use it.

https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:

https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/usb_ac... PS2, Line 13: /* : * Return false if reset GPIO is not provided. : */ Comment needs update. Or we can probably drop it since it isn't really very helpful.

https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/usb_ac... PS2, Line 60: I think it would be safer to set reset_index and privacy_index here instead of expecting the same order of _CRS and _DSD writes for the GPIOs.

reset_index = acpi_device_write_gpio(&config->reset_gpio, &index); privacy_index = acpi_device_write_gpio(&config->privacy_gpio, &index);

acpi_device_write_gpio() can return -1 if gpio.pin_count is 0. Else the index used for the GPIO and increment current index.

https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/usb_ac... PS2, Line 70: privacy Do we have the liberty to choose the gpio name string that the driver uses? I would prefer using "irq-gpio" if possible because it aligns well with how the other drivers are written and the GPIOs they expose.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 2 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Thu, 05 Nov 2020 00:27:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

9:29 a.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Hello build bot (Jenkins), Furquan Shaikh, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46961

to look at the new patch set (#3).

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

drivers/usb/acpi: Add support for privacy_gpio

Some devices, such as cameras, can implement a physical switch to disable the input on demand. Think of it like the typical privacy sticker on the notebooks, but more elegant.

In order to notify the system about the status this feature, a GPIO is typically used.

The map between a GPIO and the feature is done via ACPI, the same way as the reset_gpio works.

This patch implements an extra field for the described privacy gpio. This gpio does not require any extra handling from the power management.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/46961/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 3 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Ricardo Ribalda (Code Review)

9:29 a.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 3:

(4 comments)

https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/chip.h File src/drivers/usb/acpi/chip.h:

https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/chip.h... PS2, Line 48: privacy

...

If we decide to go with this name, I think we should have a comment block explaining what this is us […]

Done

https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:

https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/usb_ac... PS2, Line 13: /* : * Return false if reset GPIO is not provided. : */

...

Comment needs update. Or we can probably drop it since it isn't really very helpful.

Done

https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/usb_ac... PS2, Line 60:

...

I think it would be safer to set reset_index and privacy_index here instead of expecting the same or […]

Done

https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/usb_ac... PS2, Line 70: privacy

...

Do we have the liberty to choose the gpio name string that the driver uses? I would prefer using "ir […]

I think I prefer the privacy-gpio name. It shows the function of the pin and also allows device to have privacy and irq pins.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 3 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Thu, 05 Nov 2020 09:29:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

6 Nov 6 Nov

3:19 a.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 3: Code-Review+1

(2 comments)

LGTM. We just need to co-ordinate with CB:46713 to ensure the changes don't conflict.

https://review.coreboot.org/c/coreboot/+/46961/3/src/drivers/usb/acpi/chip.h File src/drivers/usb/acpi/chip.h:

https://review.coreboot.org/c/coreboot/+/46961/3/src/drivers/usb/acpi/chip.h... PS3, Line 51: recodring nit: recording

https://review.coreboot.org/c/coreboot/+/46961/3/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:

https://review.coreboot.org/c/coreboot/+/46961/3/src/drivers/usb/acpi/usb_ac... PS3, Line 11: usb_acpi_add_gpios_to_crs Looks like there is another change that is touching the same file/function - CB:46713.

We will have to rebase on top of it.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 3 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 06 Nov 2020 03:19:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

9:17 a.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46961/3/src/drivers/usb/acpi/chip.h File src/drivers/usb/acpi/chip.h:

https://review.coreboot.org/c/coreboot/+/46961/3/src/drivers/usb/acpi/chip.h... PS3, Line 51: recodring

...

nit: recording

Done

https://review.coreboot.org/c/coreboot/+/46961/3/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:

https://review.coreboot.org/c/coreboot/+/46961/3/src/drivers/usb/acpi/usb_ac... PS3, Line 11: usb_acpi_add_gpios_to_crs

...

Looks like there is another change that is touching the same file/function - CB:46713. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 3 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 06 Nov 2020 09:17:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

9:17 a.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Hello build bot (Jenkins), Furquan Shaikh, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46961

to look at the new patch set (#4).

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

drivers/usb/acpi: Add support for privacy_gpio

Some devices, such as cameras, can implement a physical switch to disable the input on demand. Think of it like the typical privacy sticker on the notebooks, but more elegant.

In order to notify the system about the status this feature, a GPIO is typically used.

The map between a GPIO and the feature is done via ACPI, the same way as the reset_gpio works.

This patch implements an extra field for the described privacy gpio. This gpio does not require any extra handling from the power management.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/46961/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 4 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

9:57 a.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46961/4/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:

https://review.coreboot.org/c/coreboot/+/46961/4/src/drivers/usb/acpi/usb_ac... PS4, Line 16: if (cfg->reset_gpio.pin_count && !cfg->has_power_resource ) space prohibited before that close parenthesis ')'

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 4 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 06 Nov 2020 09:57:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

12:04 p.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Hello build bot (Jenkins), Furquan Shaikh, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46961

to look at the new patch set (#5).

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

drivers/usb/acpi: Add support for privacy_gpio

Some devices, such as cameras, can implement a physical switch to disable the input on demand. Think of it like the typical privacy sticker on the notebooks, but more elegant.

In order to notify the system about the status this feature, a GPIO is typically used.

The map between a GPIO and the feature is done via ACPI, the same way as the reset_gpio works.

This patch implements an extra field for the described privacy gpio. This gpio does not require any extra handling from the power management.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/46961/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 5 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

5:01 p.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:

https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... PS5, Line 22: int *curr_index The caller doesn't seem to use the 'idx' parameter anywhere else, could it just be a static variable in this function?

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 5 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 06 Nov 2020 17:01:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

5:14 p.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 5: Code-Review+1

(3 comments)

https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:

https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... PS5, Line 22: int *curr_index

...

The caller doesn't seem to use the 'idx' parameter anywhere else, could it just be a static variable […]

No, because the chip driver can be used by multiple devices. And we want to ensure that the index count starts from 0 for each device.

https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... PS5, Line 67: 1 -1? Since that is used to skip adding the gpio to DSD.

https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... PS5, Line 68: = 1 nit: not required since it is set before using.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 5 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 06 Nov 2020 17:14:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

5:14 p.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46961/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46961/5//COMMIT_MSG@21 PS5, Line 21: You probably want to add BUG=b:<>

to ensure that the bug gets updated when the CL is cherry-picked to chromium tree.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 5 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 06 Nov 2020 17:14:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

5:20 p.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:

https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... PS5, Line 22: int *curr_index

...

No, because the chip driver can be used by multiple devices. […]

True, this is just ugly... I guess you could use a file-level static and reset it on calls to fill_ssdt, but that isn't much better

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 5 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 06 Nov 2020 17:20:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

5:25 p.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:

https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... PS5, Line 22: int *curr_index

...

True, this is just ugly... […]

Yeah. I think we need a way to tie the adding of gpios to _CRS such that it can be used to add GPIOs to _DSD later. Anyways, out of scope for this change, but something we should think about for making SSDT generation easier.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 5 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 06 Nov 2020 17:25:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

5:32 p.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:

https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... PS5, Line 67: 1

...

-1? Since that is used to skip adding the gpio to DSD.

Done

https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... PS5, Line 68: = 1

...

nit: not required since it is set before using.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 5 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 06 Nov 2020 17:32:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

5:37 p.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46961/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46961/5//COMMIT_MSG@21 PS5, Line 21:

...

You probably want to add […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 5 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 06 Nov 2020 17:37:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

5:39 p.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Hello build bot (Jenkins), Furquan Shaikh, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46961

to look at the new patch set (#6).

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

drivers/usb/acpi: Add support for privacy_gpio

Some devices, such as cameras, can implement a physical switch to disable the input on demand. Think of it like the typical privacy sticker on the notebooks, but more elegant.

In order to notify the system about the status this feature, a GPIO is typically used.

The map between a GPIO and the feature is done via ACPI, the same way as the reset_gpio works.

This patch implements an extra field for the described privacy gpio. This gpio does not require any extra handling from the power management.

BUG=b:169840271

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/46961/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 6 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

5:52 p.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 6 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 06 Nov 2020 17:52:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

9 Nov 9 Nov

7:40 a.m.

New subject: Change in coreboot[master]: drivers/usb/acpi: Add support for privacy_gpio

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46961 )

Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................

drivers/usb/acpi: Add support for privacy_gpio

Some devices, such as cameras, can implement a physical switch to disable the input on demand. Think of it like the typical privacy sticker on the notebooks, but more elegant.

In order to notify the system about the status this feature, a GPIO is typically used.

The map between a GPIO and the feature is done via ACPI, the same way as the reset_gpio works.

This patch implements an extra field for the described privacy gpio. This gpio does not require any extra handling from the power management.

BUG=b:169840271

Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Signed-off-by: Ricardo Ribalda ribalda@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/46961 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/drivers/usb/acpi/chip.h M src/drivers/usb/acpi/usb_acpi.c 2 files changed, 44 insertions(+), 10 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/drivers/usb/acpi/chip.h b/src/drivers/usb/acpi/chip.h index 8afdf6f..73c69cc 100644 --- a/src/drivers/usb/acpi/chip.h +++ b/src/drivers/usb/acpi/chip.h @@ -59,6 +59,13 @@ unsigned int enable_delay_ms; /* Delay to be inserted after device is disabled. */ unsigned int enable_off_delay_ms; + + /* + * Define a GPIO that shows the privacy status of the USB device. + * E.g. On a camera: if it is one, it is recording black frames. + * E.g. On a mic: if it is one, it is recording white-noise. + */ + struct acpi_gpio privacy_gpio; };

#endif /* __USB_ACPI_CHIP_H__ */ diff --git a/src/drivers/usb/acpi/usb_acpi.c b/src/drivers/usb/acpi/usb_acpi.c index 8a597e3..9d68d0a 100644 --- a/src/drivers/usb/acpi/usb_acpi.c +++ b/src/drivers/usb/acpi/usb_acpi.c @@ -10,14 +10,27 @@

static bool usb_acpi_add_gpios_to_crs(struct drivers_usb_acpi_config *cfg) { - /* - * Return false if reset GPIO is not provided or is provided as part of power - * resource. - */ - if (cfg->has_power_resource || cfg->reset_gpio.pin_count == 0) - return false; + if (cfg->privacy_gpio.pin_count) + return true;

- return true; + if (cfg->reset_gpio.pin_count && !cfg->has_power_resource) + return true; + + return false; +} + +static int usb_acpi_write_gpio(struct acpi_gpio *gpio, int *curr_index) +{ + int ret = -1; + + if (gpio->pin_count == 0) + return ret; + + acpi_device_write_gpio(gpio); + ret = *curr_index; + (*curr_index)++; + + return ret; }

static void usb_acpi_fill_ssdt_generator(const struct device *dev) @@ -50,15 +63,29 @@ /* Resources */ if (usb_acpi_add_gpios_to_crs(config) == true) { struct acpi_dp *dsd; + int idx = 0; + int reset_gpio_index = -1; + int privacy_gpio_index;

acpigen_write_name("_CRS"); acpigen_write_resourcetemplate_header(); - acpi_device_write_gpio(&config->reset_gpio); + if (!config->has_power_resource) { + reset_gpio_index = usb_acpi_write_gpio( + &config->reset_gpio, &idx); + } + privacy_gpio_index = usb_acpi_write_gpio(&config->privacy_gpio, + &idx); acpigen_write_resourcetemplate_footer();

dsd = acpi_dp_new_table("_DSD"); - acpi_dp_add_gpio(dsd, "reset-gpio", path, 0, 0, - config->reset_gpio.active_low); + if (reset_gpio_index >= 0) + acpi_dp_add_gpio(dsd, "reset-gpio", path, + reset_gpio_index, 0, + config->reset_gpio.active_low); + if (privacy_gpio_index >= 0) + acpi_dp_add_gpio(dsd, "privacy-gpio", path, + privacy_gpio_index, 0, + config->privacy_gpio.active_low); acpi_dp_write(dsd); }

-- To view, visit https://review.coreboot.org/c/coreboot/+/46961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcc65c9a13eca6f076ac3c68aaa1bed3c481df3d Gerrit-Change-Number: 46961 Gerrit-PatchSet: 7 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: merged

1512

days inactive

1523

days old

coreboot-gerrit@coreboot.org

24 comments

6 participants

tags (0)

participants (6)

Angel Pons (Code Review)
build bot (Jenkins) (Code Review)
Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Ricardo Ribalda (Code Review)
Tim Wawrzynczak (Code Review)