4 comments:
File src/drivers/usb/acpi/chip.h:
Patch Set #2, Line 48: privacy
If we decide to go with this name, I think we should have a comment block explaining what this is us […]
Done
File src/drivers/usb/acpi/usb_acpi.c:
/*
* Return false if reset GPIO is not provided.
*/
Comment needs update. Or we can probably drop it since it isn't really very helpful.
Done
I think it would be safer to set reset_index and privacy_index here instead of expecting the same or […]
Done
Patch Set #2, Line 70: privacy
Do we have the liberty to choose the gpio name string that the driver uses? I would prefer using "ir […]
I think I prefer the privacy-gpio name. It shows the function of the pin and also allows device to have privacy and irq pins.
To view, visit change 46961. To unsubscribe, or for help writing mail filters, visit settings.