Patch set 5:Code-Review +1
3 comments:
File src/drivers/usb/acpi/usb_acpi.c:
Patch Set #5, Line 22: int *curr_index
The caller doesn't seem to use the 'idx' parameter anywhere else, could it just be a static variable […]
No, because the chip driver can be used by multiple devices. And we want to ensure that the index count starts from 0 for each device.
-1? Since that is used to skip adding the gpio to DSD.
nit: not required since it is set before using.
To view, visit change 46961. To unsubscribe, or for help writing mail filters, visit settings.