4 comments:
File src/drivers/usb/acpi/chip.h:
Patch Set #2, Line 48: privacy
If we decide to go with this name, I think we should have a comment block explaining what this is used for and what kind of devices would use it.
File src/drivers/usb/acpi/usb_acpi.c:
/*
* Return false if reset GPIO is not provided.
*/
Comment needs update. Or we can probably drop it since it isn't really very helpful.
I think it would be safer to set reset_index and privacy_index here instead of expecting the same order of _CRS and _DSD writes for the GPIOs.
reset_index = acpi_device_write_gpio(&config->reset_gpio, &index);
privacy_index = acpi_device_write_gpio(&config->privacy_gpio, &index);
acpi_device_write_gpio() can return -1 if gpio.pin_count is 0. Else the index used for the GPIO and increment current index.
Patch Set #2, Line 70: privacy
Do we have the liberty to choose the gpio name string that the driver uses? I would prefer using "irq-gpio" if possible because it aligns well with how the other drivers are written and the GPIOs they expose.
To view, visit change 46961. To unsubscribe, or for help writing mail filters, visit settings.