Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37852 )
Change subject: mb/google/beltino/**/hda_verb.c: Correct pin configs ......................................................................
mb/google/beltino/**/hda_verb.c: Correct pin configs
NIDs 0x18 and 0x19 are flipped, and the verbs for NID 0x1b are instead applied onto NID 0x1a. Fix that.
Change-Id: I20cc4b282602f8557fa4f25489adf899b7460a09 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/beltino/variants/mccloud/hda_verb.c M src/mainboard/google/beltino/variants/monroe/hda_verb.c M src/mainboard/google/beltino/variants/panther/hda_verb.c M src/mainboard/google/beltino/variants/tricky/hda_verb.c M src/mainboard/google/beltino/variants/zako/hda_verb.c 5 files changed, 25 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37852/1
diff --git a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c index 19c7c62..c6b12f8 100644 --- a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c +++ b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c @@ -39,8 +39,11 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
+ /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + /* - * Pin Complex (NID 0x18) MIC1 PORTB + * Pin Complex (NID 0x19) MIC2 PORTF * group 1, cap 1 * black, jack detect * mic in, analog @@ -48,14 +51,11 @@ */ AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
- /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x18, 0x411111f0), - /* Pin Complex (NID 0x1a) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1b) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
/* * Pin Complex (NID 0x1d) PCBeep diff --git a/src/mainboard/google/beltino/variants/monroe/hda_verb.c b/src/mainboard/google/beltino/variants/monroe/hda_verb.c index 42729cc..a778dc7 100644 --- a/src/mainboard/google/beltino/variants/monroe/hda_verb.c +++ b/src/mainboard/google/beltino/variants/monroe/hda_verb.c @@ -39,17 +39,17 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled*/ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), - - /* Pin Complex (NID 0x19) MIC2 PORTF - 3.5mm Jack*/ + /* Pin Complex (NID 0x18) MIC1 PORTB - 3.5mm Jack*/ AZALIA_PIN_CFG(0, 0x18, 0x03a11020),
+ /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled*/ + AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + /* Pin Complex (NID 0x1a) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1b) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
/* * Pin Complex (NID 0x1d) PCBeep diff --git a/src/mainboard/google/beltino/variants/panther/hda_verb.c b/src/mainboard/google/beltino/variants/panther/hda_verb.c index 19c7c62..c6b12f8 100644 --- a/src/mainboard/google/beltino/variants/panther/hda_verb.c +++ b/src/mainboard/google/beltino/variants/panther/hda_verb.c @@ -39,8 +39,11 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
+ /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + /* - * Pin Complex (NID 0x18) MIC1 PORTB + * Pin Complex (NID 0x19) MIC2 PORTF * group 1, cap 1 * black, jack detect * mic in, analog @@ -48,14 +51,11 @@ */ AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
- /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x18, 0x411111f0), - /* Pin Complex (NID 0x1a) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1b) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
/* * Pin Complex (NID 0x1d) PCBeep diff --git a/src/mainboard/google/beltino/variants/tricky/hda_verb.c b/src/mainboard/google/beltino/variants/tricky/hda_verb.c index 19c7c62..c6b12f8 100644 --- a/src/mainboard/google/beltino/variants/tricky/hda_verb.c +++ b/src/mainboard/google/beltino/variants/tricky/hda_verb.c @@ -39,8 +39,11 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
+ /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + /* - * Pin Complex (NID 0x18) MIC1 PORTB + * Pin Complex (NID 0x19) MIC2 PORTF * group 1, cap 1 * black, jack detect * mic in, analog @@ -48,14 +51,11 @@ */ AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
- /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x18, 0x411111f0), - /* Pin Complex (NID 0x1a) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1b) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
/* * Pin Complex (NID 0x1d) PCBeep diff --git a/src/mainboard/google/beltino/variants/zako/hda_verb.c b/src/mainboard/google/beltino/variants/zako/hda_verb.c index 19c7c62..c6b12f8 100644 --- a/src/mainboard/google/beltino/variants/zako/hda_verb.c +++ b/src/mainboard/google/beltino/variants/zako/hda_verb.c @@ -39,8 +39,11 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
+ /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + /* - * Pin Complex (NID 0x18) MIC1 PORTB + * Pin Complex (NID 0x19) MIC2 PORTF * group 1, cap 1 * black, jack detect * mic in, analog @@ -48,14 +51,11 @@ */ AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
- /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x18, 0x411111f0), - /* Pin Complex (NID 0x1a) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1b) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
/* * Pin Complex (NID 0x1d) PCBeep
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37852 )
Change subject: mb/google/beltino/**/hda_verb.c: Correct pin configs ......................................................................
Patch Set 1: Code-Review-1
this isn't correct for verbs 0x18 and 0x19.
for all except Monroe, 0x18 should be 0x03a71011 (MIC1 port B) and 0x19 should be disabled (0x411111f0). for Monroe, 0x18 is disabled and 0x19 is 0x03a11020 (MIC2 port F)
ref: original Chromium sources for the boards
Hello HAOUAS Elyes, Matt DeVillier, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37852
to look at the new patch set (#2).
Change subject: mb/google/beltino/**/hda_verb.c: Correct pin configs ......................................................................
mb/google/beltino/**/hda_verb.c: Correct pin configs
NIDs 0x18 and 0x19 are flipped, and the verbs for NID 0x1b are instead applied onto NID 0x1a. Fix that.
Change-Id: I20cc4b282602f8557fa4f25489adf899b7460a09 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/beltino/variants/mccloud/hda_verb.c M src/mainboard/google/beltino/variants/monroe/hda_verb.c M src/mainboard/google/beltino/variants/panther/hda_verb.c M src/mainboard/google/beltino/variants/tricky/hda_verb.c M src/mainboard/google/beltino/variants/zako/hda_verb.c 5 files changed, 16 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37852/2
Hello HAOUAS Elyes, Matt DeVillier, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37852
to look at the new patch set (#3).
Change subject: mb/google/beltino/**/hda_verb.c: Correct pin configs ......................................................................
mb/google/beltino/**/hda_verb.c: Correct pin configs
NIDs 0x18 and 0x19 are flipped, and the verbs for NID 0x1b are instead applied onto NID 0x1a. Fix that, so that it matches original Chromium sources for the boards.
Change-Id: I20cc4b282602f8557fa4f25489adf899b7460a09 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/beltino/variants/mccloud/hda_verb.c M src/mainboard/google/beltino/variants/monroe/hda_verb.c M src/mainboard/google/beltino/variants/panther/hda_verb.c M src/mainboard/google/beltino/variants/tricky/hda_verb.c M src/mainboard/google/beltino/variants/zako/hda_verb.c 5 files changed, 16 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37852/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37852 )
Change subject: mb/google/beltino/**/hda_verb.c: Correct pin configs ......................................................................
Patch Set 3:
Patch Set 1: Code-Review-1
this isn't correct for verbs 0x18 and 0x19.
for all except Monroe, 0x18 should be 0x03a71011 (MIC1 port B) and 0x19 should be disabled (0x411111f0). for Monroe, 0x18 is disabled and 0x19 is 0x03a11020 (MIC2 port F)
ref: original Chromium sources for the boards
Thanks, should be good now
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37852 )
Change subject: mb/google/beltino/**/hda_verb.c: Correct pin configs ......................................................................
Patch Set 3: Code-Review+2
Hello HAOUAS Elyes, Matt DeVillier, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37852
to look at the new patch set (#4).
Change subject: mb/google/beltino/**/hda_verb.c: Correct pin configs ......................................................................
mb/google/beltino/**/hda_verb.c: Correct pin configs
NIDs 0x18 and 0x19 are flipped, and the verbs for NID 0x1b are instead applied onto NID 0x1a. Fix that, so that it matches original Chromium sources for the boards.
Change-Id: I20cc4b282602f8557fa4f25489adf899b7460a09 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/beltino/variants/mccloud/hda_verb.c M src/mainboard/google/beltino/variants/monroe/hda_verb.c M src/mainboard/google/beltino/variants/panther/hda_verb.c M src/mainboard/google/beltino/variants/tricky/hda_verb.c M src/mainboard/google/beltino/variants/zako/hda_verb.c 5 files changed, 15 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37852/4
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37852 )
Change subject: mb/google/beltino/**/hda_verb.c: Correct pin configs ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37852 )
Change subject: mb/google/beltino/**/hda_verb.c: Correct pin configs ......................................................................
mb/google/beltino/**/hda_verb.c: Correct pin configs
NIDs 0x18 and 0x19 are flipped, and the verbs for NID 0x1b are instead applied onto NID 0x1a. Fix that, so that it matches original Chromium sources for the boards.
Change-Id: I20cc4b282602f8557fa4f25489adf899b7460a09 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37852 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/beltino/variants/mccloud/hda_verb.c M src/mainboard/google/beltino/variants/monroe/hda_verb.c M src/mainboard/google/beltino/variants/panther/hda_verb.c M src/mainboard/google/beltino/variants/tricky/hda_verb.c M src/mainboard/google/beltino/variants/zako/hda_verb.c 5 files changed, 15 insertions(+), 15 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c index a60bee4..14f1410 100644 --- a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c +++ b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c @@ -45,16 +45,16 @@ // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x19, 0x03a71011), + AZALIA_PIN_CFG(0, 0x18, 0x03a71011),
/* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x411111f0),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
/* Pin Complex (NID 0x1d) PCBeep */ // eapd low on ex-amp, laptop, custom enable diff --git a/src/mainboard/google/beltino/variants/monroe/hda_verb.c b/src/mainboard/google/beltino/variants/monroe/hda_verb.c index 9ca85e9..964687c 100644 --- a/src/mainboard/google/beltino/variants/monroe/hda_verb.c +++ b/src/mainboard/google/beltino/variants/monroe/hda_verb.c @@ -41,16 +41,16 @@ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
/* Pin Complex (NID 0x18) MIC1 PORTB - Disabled*/ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x18, 0x411111f0),
/* Pin Complex (NID 0x19) MIC2 PORTF - 3.5mm Jack*/ - AZALIA_PIN_CFG(0, 0x18, 0x03a11020), + AZALIA_PIN_CFG(0, 0x19, 0x03a11020),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
/* Pin Complex (NID 0x1d) PCBeep */ // eapd low on ex-amp, laptop, custom enable diff --git a/src/mainboard/google/beltino/variants/panther/hda_verb.c b/src/mainboard/google/beltino/variants/panther/hda_verb.c index a60bee4..14f1410 100644 --- a/src/mainboard/google/beltino/variants/panther/hda_verb.c +++ b/src/mainboard/google/beltino/variants/panther/hda_verb.c @@ -45,16 +45,16 @@ // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x19, 0x03a71011), + AZALIA_PIN_CFG(0, 0x18, 0x03a71011),
/* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x411111f0),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
/* Pin Complex (NID 0x1d) PCBeep */ // eapd low on ex-amp, laptop, custom enable diff --git a/src/mainboard/google/beltino/variants/tricky/hda_verb.c b/src/mainboard/google/beltino/variants/tricky/hda_verb.c index a60bee4..14f1410 100644 --- a/src/mainboard/google/beltino/variants/tricky/hda_verb.c +++ b/src/mainboard/google/beltino/variants/tricky/hda_verb.c @@ -45,16 +45,16 @@ // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x19, 0x03a71011), + AZALIA_PIN_CFG(0, 0x18, 0x03a71011),
/* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x411111f0),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
/* Pin Complex (NID 0x1d) PCBeep */ // eapd low on ex-amp, laptop, custom enable diff --git a/src/mainboard/google/beltino/variants/zako/hda_verb.c b/src/mainboard/google/beltino/variants/zako/hda_verb.c index a60bee4..14f1410 100644 --- a/src/mainboard/google/beltino/variants/zako/hda_verb.c +++ b/src/mainboard/google/beltino/variants/zako/hda_verb.c @@ -45,16 +45,16 @@ // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x19, 0x03a71011), + AZALIA_PIN_CFG(0, 0x18, 0x03a71011),
/* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x411111f0),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
/* Pin Complex (NID 0x1d) PCBeep */ // eapd low on ex-amp, laptop, custom enable
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)