Change in coreboot[master]: mb/google/beltino/**/hda_verb.c: remove preprocessor guards

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37851 )

Change subject: mb/google/beltino/**/hda_verb.c: remove preprocessor guards
......................................................................

mb/google/beltino/**/hda_verb.c: remove preprocessor guards

These files are not headers.

Change-Id: Ibe6c9a96c1c4b0952a8d03b7a8b17869a66511f2
Signed-off-by: Angel Pons 
---
M src/mainboard/google/beltino/variants/mccloud/hda_verb.c
M src/mainboard/google/beltino/variants/monroe/hda_verb.c
M src/mainboard/google/beltino/variants/panther/hda_verb.c
M src/mainboard/google/beltino/variants/tricky/hda_verb.c
M src/mainboard/google/beltino/variants/zako/hda_verb.c
5 files changed, 0 insertions(+), 25 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/37851/1

diff --git a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c
index 8641455..19c7c62 100644
--- a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c
+++ b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c
@@ -13,9 +13,6 @@
  * GNU General Public License for more details.
  */

-#ifndef HDA_VERB_H
-#define HDA_VERB_H
-
 #include <device/azalia_device.h>

const u32 cim_verb_data[] = {
@@ -104,6 +101,4 @@
    0x00b37410,	/* unmute mixer nid 0xb beep input and set volume */
 };

-#endif /* HDA_VERB_H */
-
 AZALIA_ARRAY_SIZES;
diff --git a/src/mainboard/google/beltino/variants/monroe/hda_verb.c b/src/mainboard/google/beltino/variants/monroe/hda_verb.c
index 545933d..42729cc 100644
--- a/src/mainboard/google/beltino/variants/monroe/hda_verb.c
+++ b/src/mainboard/google/beltino/variants/monroe/hda_verb.c
@@ -13,9 +13,6 @@
  * GNU General Public License for more details.
  */

-#ifndef HDA_VERB_H
-#define HDA_VERB_H
-
 #include <device/azalia_device.h>

const u32 cim_verb_data[] = {
@@ -102,6 +99,4 @@
    0x00b37410,	/* unmute mixer nid 0xb beep input and set volume */
 };

-#endif /* HDA_VERB_H */
-
 AZALIA_ARRAY_SIZES;
diff --git a/src/mainboard/google/beltino/variants/panther/hda_verb.c b/src/mainboard/google/beltino/variants/panther/hda_verb.c
index 8641455..19c7c62 100644
--- a/src/mainboard/google/beltino/variants/panther/hda_verb.c
+++ b/src/mainboard/google/beltino/variants/panther/hda_verb.c
@@ -13,9 +13,6 @@
  * GNU General Public License for more details.
  */

-#ifndef HDA_VERB_H
-#define HDA_VERB_H
-
 #include <device/azalia_device.h>

const u32 cim_verb_data[] = {
@@ -104,6 +101,4 @@
    0x00b37410,	/* unmute mixer nid 0xb beep input and set volume */
 };

-#endif /* HDA_VERB_H */
-
 AZALIA_ARRAY_SIZES;
diff --git a/src/mainboard/google/beltino/variants/tricky/hda_verb.c b/src/mainboard/google/beltino/variants/tricky/hda_verb.c
index 8641455..19c7c62 100644
--- a/src/mainboard/google/beltino/variants/tricky/hda_verb.c
+++ b/src/mainboard/google/beltino/variants/tricky/hda_verb.c
@@ -13,9 +13,6 @@
  * GNU General Public License for more details.
  */

-#ifndef HDA_VERB_H
-#define HDA_VERB_H
-
 #include <device/azalia_device.h>

const u32 cim_verb_data[] = {
@@ -104,6 +101,4 @@
    0x00b37410,	/* unmute mixer nid 0xb beep input and set volume */
 };

-#endif /* HDA_VERB_H */
-
 AZALIA_ARRAY_SIZES;
diff --git a/src/mainboard/google/beltino/variants/zako/hda_verb.c b/src/mainboard/google/beltino/variants/zako/hda_verb.c
index 8641455..19c7c62 100644
--- a/src/mainboard/google/beltino/variants/zako/hda_verb.c
+++ b/src/mainboard/google/beltino/variants/zako/hda_verb.c
@@ -13,9 +13,6 @@
  * GNU General Public License for more details.
  */

-#ifndef HDA_VERB_H
-#define HDA_VERB_H
-
 #include <device/azalia_device.h>

const u32 cim_verb_data[] = {
@@ -104,6 +101,4 @@
    0x00b37410,	/* unmute mixer nid 0xb beep input and set volume */
 };

-#endif /* HDA_VERB_H */
-
 AZALIA_ARRAY_SIZES;

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37851 )

Change subject: mb/google/beltino/**/hda_verb.c: remove preprocessor guards
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Hello HAOUAS Elyes, Matt DeVillier, build bot (Jenkins), Nico Huber, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37851

to look at the new patch set (#2).

Change subject: mb/google/beltino/**/hda_verb.c: remove preprocessor guards
......................................................................

mb/google/beltino/**/hda_verb.c: remove preprocessor guards

These files are not headers.

Change-Id: Ibe6c9a96c1c4b0952a8d03b7a8b17869a66511f2
Signed-off-by: Angel Pons 
---
M src/mainboard/google/beltino/variants/mccloud/hda_verb.c
M src/mainboard/google/beltino/variants/monroe/hda_verb.c
M src/mainboard/google/beltino/variants/panther/hda_verb.c
M src/mainboard/google/beltino/variants/tricky/hda_verb.c
M src/mainboard/google/beltino/variants/zako/hda_verb.c
5 files changed, 0 insertions(+), 25 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/37851/2

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37851 )

Change subject: mb/google/beltino/**/hda_verb.c: remove preprocessor guards
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37851 )

Change subject: mb/google/beltino/**/hda_verb.c: remove preprocessor guards
......................................................................

mb/google/beltino/**/hda_verb.c: remove preprocessor guards

These files are not headers.

Change-Id: Ibe6c9a96c1c4b0952a8d03b7a8b17869a66511f2
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37851
Tested-by: build bot (Jenkins) 
Reviewed-by: Matt DeVillier 
---
M src/mainboard/google/beltino/variants/mccloud/hda_verb.c
M src/mainboard/google/beltino/variants/monroe/hda_verb.c
M src/mainboard/google/beltino/variants/panther/hda_verb.c
M src/mainboard/google/beltino/variants/tricky/hda_verb.c
M src/mainboard/google/beltino/variants/zako/hda_verb.c
5 files changed, 0 insertions(+), 25 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Matt DeVillier: Looks good to me, approved

diff --git a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c
index 6b319db..a60bee4 100644
--- a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c
+++ b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c
@@ -13,9 +13,6 @@
  * GNU General Public License for more details.
  */

-#ifndef HDA_VERB_H
-#define HDA_VERB_H
-
 #include <device/azalia_device.h>

const u32 cim_verb_data[] = {
@@ -99,6 +96,4 @@
    0x00b37410,	/* unmute mixer nid 0xb beep input and set volume */
 };

-
-#endif /* HDA_VERB_H */
 AZALIA_ARRAY_SIZES;
diff --git a/src/mainboard/google/beltino/variants/monroe/hda_verb.c b/src/mainboard/google/beltino/variants/monroe/hda_verb.c
index 5af715d..9ca85e9 100644
--- a/src/mainboard/google/beltino/variants/monroe/hda_verb.c
+++ b/src/mainboard/google/beltino/variants/monroe/hda_verb.c
@@ -13,9 +13,6 @@
  * GNU General Public License for more details.
  */

-#ifndef HDA_VERB_H
-#define HDA_VERB_H
-
 #include <device/azalia_device.h>

const u32 cim_verb_data[] = {
@@ -100,6 +97,4 @@
    0x00b37410,	/* unmute mixer nid 0xb beep input and set volume */
 };

-
-#endif /* HDA_VERB_H */
 AZALIA_ARRAY_SIZES;
diff --git a/src/mainboard/google/beltino/variants/panther/hda_verb.c b/src/mainboard/google/beltino/variants/panther/hda_verb.c
index 6b319db..a60bee4 100644
--- a/src/mainboard/google/beltino/variants/panther/hda_verb.c
+++ b/src/mainboard/google/beltino/variants/panther/hda_verb.c
@@ -13,9 +13,6 @@
  * GNU General Public License for more details.
  */

-#ifndef HDA_VERB_H
-#define HDA_VERB_H
-
 #include <device/azalia_device.h>

const u32 cim_verb_data[] = {
@@ -99,6 +96,4 @@
    0x00b37410,	/* unmute mixer nid 0xb beep input and set volume */
 };

-
-#endif /* HDA_VERB_H */
 AZALIA_ARRAY_SIZES;
diff --git a/src/mainboard/google/beltino/variants/tricky/hda_verb.c b/src/mainboard/google/beltino/variants/tricky/hda_verb.c
index 6b319db..a60bee4 100644
--- a/src/mainboard/google/beltino/variants/tricky/hda_verb.c
+++ b/src/mainboard/google/beltino/variants/tricky/hda_verb.c
@@ -13,9 +13,6 @@
  * GNU General Public License for more details.
  */

-#ifndef HDA_VERB_H
-#define HDA_VERB_H
-
 #include <device/azalia_device.h>

const u32 cim_verb_data[] = {
@@ -99,6 +96,4 @@
    0x00b37410,	/* unmute mixer nid 0xb beep input and set volume */
 };

-
-#endif /* HDA_VERB_H */
 AZALIA_ARRAY_SIZES;
diff --git a/src/mainboard/google/beltino/variants/zako/hda_verb.c b/src/mainboard/google/beltino/variants/zako/hda_verb.c
index 6b319db..a60bee4 100644
--- a/src/mainboard/google/beltino/variants/zako/hda_verb.c
+++ b/src/mainboard/google/beltino/variants/zako/hda_verb.c
@@ -13,9 +13,6 @@
  * GNU General Public License for more details.
  */

-#ifndef HDA_VERB_H
-#define HDA_VERB_H
-
 #include <device/azalia_device.h>

const u32 cim_verb_data[] = {
@@ -99,6 +96,4 @@
    0x00b37410,	/* unmute mixer nid 0xb beep input and set volume */
 };

-
-#endif /* HDA_VERB_H */
 AZALIA_ARRAY_SIZES;