Patch Set 1: Code-Review-1

this isn't correct for verbs 0x18 and 0x19.

for all except Monroe, 0x18 should be 0x03a71011 (MIC1 port B) and 0x19 should be disabled (0x411111f0).
for Monroe, 0x18 is disabled and 0x19 is 0x03a11020 (MIC2 port F)

ref: original Chromium sources for the boards

Thanks, should be good now

View Change

To view, visit change 37852. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20cc4b282602f8557fa4f25489adf899b7460a09
Gerrit-Change-Number: 37852
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 19 Dec 2019 21:08:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment