Change in coreboot[master]: mb/intel/d945gclf: Remove unused include
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37898 ) Change subject: mb/intel/d945gclf: Remove unused include ...................................................................... mb/intel/d945gclf: Remove unused include Change-Id: I023ce20b4144d782f22243911f845f6e28fdb2a3 Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> --- M src/mainboard/intel/d945gclf/acpi_tables.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/37898/1 diff --git a/src/mainboard/intel/d945gclf/acpi_tables.c b/src/mainboard/intel/d945gclf/acpi_tables.c index ba3995e..c212315 100644 --- a/src/mainboard/intel/d945gclf/acpi_tables.c +++ b/src/mainboard/intel/d945gclf/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <stdint.h> #include <southbridge/intel/i82801gx/nvs.h> void acpi_create_gnvs(global_nvs_t *gnvs) -- To view, visit https://review.coreboot.org/c/coreboot/+/37898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I023ce20b4144d782f22243911f845f6e28fdb2a3 Gerrit-Change-Number: 37898 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: newchange
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37898 ) Change subject: mb/intel/d945gclf: Remove unused include ...................................................................... Patch Set 5: Merged CB:37899 should fix the build -- To view, visit https://review.coreboot.org/c/coreboot/+/37898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I023ce20b4144d782f22243911f845f6e28fdb2a3 Gerrit-Change-Number: 37898 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Comment-Date: Tue, 31 Dec 2019 08:06:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37898 ) Change subject: mb/intel/d945gclf: Remove unused include ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/37898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I023ce20b4144d782f22243911f845f6e28fdb2a3 Gerrit-Change-Number: 37898 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 31 Dec 2019 09:20:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37898 ) Change subject: mb/intel/d945gclf: Remove unused include ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/37898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I023ce20b4144d782f22243911f845f6e28fdb2a3 Gerrit-Change-Number: 37898 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 02 Jan 2020 14:27:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37898 ) Change subject: mb/intel/d945gclf: Remove unused include ...................................................................... mb/intel/d945gclf: Remove unused include Change-Id: I023ce20b4144d782f22243911f845f6e28fdb2a3 Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/37898 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-by: Patrick Georgi <pgeorgi@google.com> --- M src/mainboard/intel/d945gclf/acpi_tables.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/intel/d945gclf/acpi_tables.c b/src/mainboard/intel/d945gclf/acpi_tables.c index ba3995e..c212315 100644 --- a/src/mainboard/intel/d945gclf/acpi_tables.c +++ b/src/mainboard/intel/d945gclf/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <stdint.h> #include <southbridge/intel/i82801gx/nvs.h> void acpi_create_gnvs(global_nvs_t *gnvs) -- To view, visit https://review.coreboot.org/c/coreboot/+/37898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I023ce20b4144d782f22243911f845f6e28fdb2a3 Gerrit-Change-Number: 37898 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: merged
participants (3)
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)