coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
2949 discussions

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the SSD
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87073?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the SSD ...................................................................... mb/starlabs/starbook/adl_n: Tidy GPIO comments for the SSD This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: Ief80e0527c9e1bfdc31ce9a28fb0bd997ba4493e Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87073 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index f89cabc..7cf23e8 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -39,6 +39,11 @@ PAD_CFG_NF(GPP_B8, NONE, DEEP, NF2), /* Clock */ PAD_CFG_GPI_APIC_LOW(GPP_E12, NONE, PLTRST), /* Interrupt */ + /* SSD */ + PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), /* Clock Request 0 */ + PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* Reset */ + PAD_CFG_GPO(GPP_D16, 1, DEEP), /* Enable */ + PAD_NC(GPD2, NONE), PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ @@ -198,8 +203,6 @@ PAD_NC(GPP_D3, NONE), /* D4: Not Connected */ PAD_NC(GPP_D4, NONE), - /* D5: Clock Request 0 PCH M.2 SSD */ - PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), /* D6: Clock Request 1 Wireless LAN */ PAD_CFG_NF(GPP_D6, NONE, DEEP, NF1), /* D7: Clock Request 2 */ @@ -220,8 +223,6 @@ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), - /* D16: PCH M.2 SSD Power Enable */ - PAD_CFG_GPO(GPP_D16, 1, DEEP), /* D17: Not used Fingerprint ID */ PAD_NC(GPP_D17, NONE), /* D18: Not Connected */ @@ -329,8 +330,6 @@ /* F23: Not Connected */ PAD_NC(GPP_F23, NONE), - /* H0: PCH M.2 SSD Reset */ - PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ PAD_CFG_GPO(GPP_H1, 0, DEEP), /* H2: Wireless LAN Reset */ -- To view, visit https://review.coreboot.org/c/coreboot/+/87073?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ief80e0527c9e1bfdc31ce9a28fb0bd997ba4493e Gerrit-Change-Number: 87073 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the touchpad
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87072?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the touchpad ...................................................................... mb/starlabs/starbook/adl_n: Tidy GPIO comments for the touchpad This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: I65d055955c0abf04b597e6972ef95f5c2983563e Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87072 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 3994818..f89cabc 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -34,6 +34,11 @@ // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* Touchpad */ + PAD_CFG_NF(GPP_B7, NONE, DEEP, NF2), /* Data */ + PAD_CFG_NF(GPP_B8, NONE, DEEP, NF2), /* Clock */ + PAD_CFG_GPI_APIC_LOW(GPP_E12, NONE, PLTRST), /* Interrupt */ + PAD_NC(GPD2, NONE), PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ @@ -91,10 +96,6 @@ PAD_NC(GPP_B5, NONE), /* B6: I2C 2 SCL Touch Panel Clock */ PAD_NC(GPP_B6, NONE), - /* B7: I2C 3 SDA Test Point 15 */ - PAD_CFG_NF(GPP_B7, NONE, DEEP, NF2), - /* B8: I2C 3 SCL Test Point 16 */ - PAD_CFG_NF(GPP_B8, NONE, DEEP, NF2), /* B9: Not Connected */ PAD_NC(GPP_B9, NONE), /* B10: Not Connected */ @@ -254,8 +255,6 @@ PAD_NC(GPP_E10, NONE), /* E11: TPM IRQ */ PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), - /* E12: Touchpad Interrupt */ - PAD_CFG_GPI_APIC_LOW(GPP_E12, NONE, PLTRST), /* E13: Not connected */ PAD_NC(GPP_E13, NONE), /* E14: EDP HPD */ -- To view, visit https://review.coreboot.org/c/coreboot/+/87072?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I65d055955c0abf04b597e6972ef95f5c2983563e Gerrit-Change-Number: 87072 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for eSPI
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87071?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for eSPI ...................................................................... mb/starlabs/starbook/adl_n: Tidy GPIO comments for eSPI This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: I8cf7342e6442d283c5ba4b7ee545aa8ac524e365 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87071 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 705f6ee..3994818 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -25,6 +25,15 @@ PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ + /* eSPI */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A0, UP_20K, DEEP, NF1), /* eSPI IO 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A1, UP_20K, DEEP, NF1), /* eSPI IO 1 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A2, UP_20K, DEEP, NF1), /* eSPI IO 2 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A3, UP_20K, DEEP, NF1), /* eSPI IO 3 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A4, UP_20K, DEEP, NF1), /* eSPI CS 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + PAD_NC(GPD2, NONE), PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ @@ -33,11 +42,6 @@ PAD_NC(GPD10, NONE), PAD_NC(GPD11, NONE), - /* A0: ESPI IO 0 */ - /* A1: ESPI IO 1 */ - /* A2: ESPI IO 2 */ - /* A3: ESPI IO 3 */ - /* A4: ESPI CS 0 */ /* A5: Not Connected */ PAD_NC(GPP_A5, NONE), /* A6: Not Connected */ @@ -46,8 +50,6 @@ PAD_NC(GPP_A7, NONE), /* A8: Not Connected */ PAD_NC(GPP_A8, NONE), - /* A9: ESPI Clock */ - /* A10: ESPI Reset */ /* A11: Not Connected */ PAD_NC(GPP_A11, NONE), /* A12: Not Connected */ -- To view, visit https://review.coreboot.org/c/coreboot/+/87071?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8cf7342e6442d283c5ba4b7ee545aa8ac524e365 Gerrit-Change-Number: 87071 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for deep GPIOs
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87070?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for deep GPIOs ...................................................................... mb/starlabs/starbook/adl_n: Tidy GPIO comments for deep GPIOs This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: Ic69920c052707a44ecdd44c5879bbbf612cc03f8 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87070 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 8 insertions(+), 17 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 5f98b2b..705f6ee 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -17,29 +17,20 @@ /* Pad configuration in ramstage. */ const struct pad_config gpio_table[] = { - /* GPD0: Battery Low */ - PAD_CFG_NF(GPD0, NONE, DEEP, NF1), - /* GPD1: Charger Connected */ - PAD_CFG_NF(GPD1, NONE, DEEP, NF1), - /* GPD2: LAN Wake */ + /* General Purpose I/O Deep */ + PAD_CFG_NF(GPD0, NONE, DEEP, NF1), /* Battery Low */ + PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* Charger Connected */ + PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* Power Button */ + PAD_CFG_NF(GPD4, NONE, DEEP, NF1), /* Sleep S3 */ + PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* Sleep S4 */ + PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ + PAD_NC(GPD2, NONE), - /* GPD3: Power Button */ - PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), - /* GPD4: Sleep S3 */ - PAD_CFG_NF(GPD4, NONE, DEEP, NF1), - /* GPD5: Sleep S4 */ - PAD_CFG_NF(GPD5, NONE, DEEP, NF1), - /* GPD6: Sleep A */ PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ PAD_CFG_GPO(GPD7, 0, PWROK), - /* GPD8: Suspend Clock */ - PAD_CFG_NF(GPD8, NONE, DEEP, NF1), - /* GPD9: Wireless LAN Sleep */ PAD_NC(GPD9, NONE), - /* GPD10: Sleep S5 */ PAD_NC(GPD10, NONE), - /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE), /* A0: ESPI IO 0 */ -- To view, visit https://review.coreboot.org/c/coreboot/+/87070?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic69920c052707a44ecdd44c5879bbbf612cc03f8 Gerrit-Change-Number: 87070 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for debug connector
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87069?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for debug connector ...................................................................... mb/starlabs/starbook/adl_n: Tidy GPIO comments for debug connector This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: I1284e9947edca20d113ca2e810963fcfffb92831 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87069 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 11cab70..5f98b2b 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -4,10 +4,9 @@ /* Early pad configuration in bootblock */ const struct pad_config early_gpio_table[] = { - /* H10: UART0 RXD Debug Connector */ - PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), - /* H11: UART0 TXD Debug Connector */ - PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2), + /* Debug Connector */ + PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), /* RXD */ + PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2), /* TXD */ }; const struct pad_config *variant_early_gpio_table(size_t *num) -- To view, visit https://review.coreboot.org/c/coreboot/+/87069?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1284e9947edca20d113ca2e810963fcfffb92831 Gerrit-Change-Number: 87069 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the PCH Straps
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Matt DeVillier. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87080?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the PCH Straps ...................................................................... Patch Set 2: (1 comment) File src/mainboard/starlabs/starbook/variants/adl_n/gpio.c: https://review.coreboot.org/c/coreboot/+/87080/comment/dd9ea196_5f0c0a4e?us… : PS1, Line 95: > fix alignment Done -- To view, visit https://review.coreboot.org/c/coreboot/+/87080?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I658cd6ddf2d418da0e36a8e1969041a696a10d87 Gerrit-Change-Number: 87080 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 08:18:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[M] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the PCH Straps
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Matt DeVillier, Sean Rhodes. Hello Matt DeVillier, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87080?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Matt DeVillier, Verified+1 by build bot (Jenkins) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the PCH Straps ...................................................................... mb/starlabs/starbook/adl_n: Tidy GPIO comments for the PCH Straps This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: I658cd6ddf2d418da0e36a8e1969041a696a10d87 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 14 insertions(+), 36 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/87080/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87080?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I658cd6ddf2d418da0e36a8e1969041a696a10d87 Gerrit-Change-Number: 87080 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/starlabs/byte_adl/cfr: Drop CONFIG guards for CFR elements
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87067?usp=email ) Change subject: mb/starlabs/byte_adl/cfr: Drop CONFIG guards for CFR elements ...................................................................... mb/starlabs/byte_adl/cfr: Drop CONFIG guards for CFR elements The byte_adl is an Alderlake board, so we don't need to do any SoC checks to determine which CFR elements to include. TEST=build/boot starlabs/byte_adl, verify CFR options unchanged. Change-Id: Ie21a873ad7af1504f46db769c3abba00c0e61008 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87067 Reviewed-by: Sean Rhodes <sean(a)starlabs.systems> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/byte_adl/cfr.c 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: build bot (Jenkins): Verified Sean Rhodes: Looks good to me, approved diff --git a/src/mainboard/starlabs/byte_adl/cfr.c b/src/mainboard/starlabs/byte_adl/cfr.c index 81d74b9..442326f 100644 --- a/src/mainboard/starlabs/byte_adl/cfr.c +++ b/src/mainboard/starlabs/byte_adl/cfr.c @@ -38,14 +38,12 @@ SM_ENUM_VALUE_END }, }); -#if CONFIG(SOC_INTEL_TIGERLAKE) || CONFIG(SOC_INTEL_ALDERLAKE) || CONFIG(SOC_INTEL_RAPTORLAKE) static const struct sm_object gna = SM_DECLARE_BOOL({ .opt_name = "gna", .ui_name = "Gaussian & Neural Accelerator", .ui_helptext = "Enable or Disable the Gaussian & Neural Accelerator", .default_value = false, }); -#endif static const struct sm_object me_state = SM_DECLARE_ENUM({ .opt_name = "me_state", @@ -84,7 +82,6 @@ SM_ENUM_VALUE_END }, }); -#if CONFIG(SOC_INTEL_ALDERLAKE) static const struct sm_object pciexp_aspm = SM_DECLARE_ENUM({ .opt_name = "pciexp_aspm", .ui_name = "PCI ASPM", @@ -124,7 +121,6 @@ { "L1.2", L1_SS_L1_2 }, SM_ENUM_VALUE_END }, }); -#endif static const struct sm_object reboot_counter = SM_DECLARE_NUMBER({ .opt_name = "reboot_counter", @@ -169,9 +165,7 @@ static struct sm_obj_form devices = { .ui_name = "Devices", .obj_list = (const struct sm_object *[]) { - #if CONFIG(SOC_INTEL_TIGERLAKE) || CONFIG(SOC_INTEL_ALDERLAKE) || CONFIG(SOC_INTEL_RAPTORLAKE) &gna, - #endif NULL }, }; @@ -179,11 +173,9 @@ static struct sm_obj_form pci = { .ui_name = "PCI", .obj_list = (const struct sm_object *[]) { - #if CONFIG(SOC_INTEL_ALDERLAKE) &pciexp_clk_pm, &pciexp_aspm, &pciexp_l1ss, - #endif NULL }, }; -- To view, visit https://review.coreboot.org/c/coreboot/+/87067?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie21a873ad7af1504f46db769c3abba00c0e61008 Gerrit-Change-Number: 87067 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Enable DDC for DDIA
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Matt DeVillier. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86914?usp=email ) Change subject: mb/starlabs/*: Enable DDC for DDIA ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86914?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic05ec3cece911f61347bceb82e5798729dcaecfe Gerrit-Change-Number: 86914 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 07:53:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8189: Add NOR-Flash support
by Yidi Lin (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Hung-Te Lin, Vince Liu, Yu-Ping Wu. Yidi Lin has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/86997?usp=email ) Change subject: soc/mediatek/mt8189: Add NOR-Flash support ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: @yupingso@google.com please take the final review. -- To view, visit https://review.coreboot.org/c/coreboot/+/86997?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3a5b7682e4093f9eddf825bc57267b0180cf8b3c Gerrit-Change-Number: 86997 Gerrit-PatchSet: 2 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 07:25:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025