coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
2965 discussions

[S] Change in coreboot[main]: mb/starlabs/*: Enable DDC for DDIA
by Matt DeVillier (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86914?usp=email ) Change subject: mb/starlabs/*: Enable DDC for DDIA ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86914?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic05ec3cece911f61347bceb82e5798729dcaecfe Gerrit-Change-Number: 86914 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 02 Apr 2025 14:25:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: ec/dasharo/ec: Add DTT power and battery participants
by Michał Żygowski (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Maciej Pijanowski, Michał Kopeć. Michał Żygowski has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/86820?usp=email ) Change subject: ec/dasharo/ec: Add DTT power and battery participants ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: Don't we need any DPTF policies in the devicetree? -- To view, visit https://review.coreboot.org/c/coreboot/+/86820?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e215366a79c0dd0f8a5d54c33fc718ba6b1302b Gerrit-Change-Number: 86820 Gerrit-PatchSet: 8 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 14:24:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: security/intel/txt: Verify Intel TXT required TPM2 indices presence
by Filip Lewiński (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Arthur Heymans, Felix Singer, Julius Werner, Krystian Hebel, Martin Roth, Michał Kopeć, Yu-Ping Wu. Filip Lewiński has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82417?usp=email ) Change subject: security/intel/txt: Verify Intel TXT required TPM2 indices presence ...................................................................... Patch Set 21: (1 comment) File src/security/intel/txt/common.c: https://review.coreboot.org/c/coreboot/+/82417/comment/c59514e9_9bbfa9ed?us… : PS21, Line 627: #if CONFIG(TPM2) > Wouldn't it complain about undeclared `check_tpm_indices()`? Yeah, the preprocessor guard is necessary, otherwise we get an error about the `check_tpm_indices` function -- To view, visit https://review.coreboot.org/c/coreboot/+/82417?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5b4267b2d51e21cfa514e96301f30ebf7437c470 Gerrit-Change-Number: 82417 Gerrit-PatchSet: 21 Gerrit-Owner: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 14:23:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com>

1 0

[XL] Change in coreboot[main]: mb/novacustom/mtl-h: Add discrete graphics variant
by Michał Żygowski (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć. Michał Żygowski has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/86790?usp=email ) Change subject: mb/novacustom/mtl-h: Add discrete graphics variant ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86790?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2b8194c486de1ba3e04aa74ed63caa7a151fbb8b Gerrit-Change-Number: 86790 Gerrit-PatchSet: 9 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 14:23:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in coreboot[main]: mb/novacustom/mtl-h: Add discrete graphics variant
by Michał Żygowski (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć. Michał Żygowski has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/86790?usp=email ) Change subject: mb/novacustom/mtl-h: Add discrete graphics variant ...................................................................... Patch Set 9: (1 comment) File src/mainboard/novacustom/mtl-h/variants/igpu/ramstage.c: https://review.coreboot.org/c/coreboot/+/86790/comment/8e34d858_6c71eb4a?us… : PS3, Line 1: /* SPDX-License-Identifier: CC-PDDC */ > ... […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/86790?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2b8194c486de1ba3e04aa74ed63caa7a151fbb8b Gerrit-Change-Number: 86790 Gerrit-PatchSet: 9 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 14:22:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com>

1 0

[XS] Change in coreboot[main]: mb/novacustom/mtl-h/ramstage.c: Set Pinmux FSP UPDs
by Michał Żygowski (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć. Michał Żygowski has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/86788?usp=email ) Change subject: mb/novacustom/mtl-h/ramstage.c: Set Pinmux FSP UPDs ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/86788/comment/d36e3941_5ca21098?us… : PS2, Line 9: Set Pin Mux FSP UPDs as per mainboard schematic. Enable Port Reset : Message on USB2 lanes corresponding to Type-C ports. > Okay, added https://review.coreboot. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/86788?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id075e236cee64527aab644616186a3e223c1bfc3 Gerrit-Change-Number: 86788 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 14:22:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com>

1 0

[XS] Change in coreboot[main]: mb/novacustom/mtl-h/romstage.c: Set Loadline FSP UPDs
by Michał Żygowski (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć. Michał Żygowski has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/86787?usp=email ) Change subject: mb/novacustom/mtl-h/romstage.c: Set Loadline FSP UPDs ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86787?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4cf729fc55ed6f2722606f393b6aa45afe396a6e Gerrit-Change-Number: 86787 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 14:21:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/novacustom/mtl-h/romstage.c: Set Loadline FSP UPDs
by Michał Żygowski (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć. Michał Żygowski has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/86787?usp=email ) Change subject: mb/novacustom/mtl-h/romstage.c: Set Loadline FSP UPDs ...................................................................... Patch Set 5: (1 comment) File src/mainboard/novacustom/mtl-h/romstage.c: https://review.coreboot.org/c/coreboot/+/86787/comment/63ffd2be_e83d1ffc?us… : PS2, Line 30: mupd->FspmConfig.PrimaryDisplay = 0x0; // iGPU > Removed, it's not necessary for now, we can revisit it in the future if needed. Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/86787?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4cf729fc55ed6f2722606f393b6aa45afe396a6e Gerrit-Change-Number: 86787 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 14:18:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com>

1 0

[S] Change in coreboot[main]: drivers/smmstore: add ability to write to whole flash
by Michał Żygowski (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Arthur Heymans, Felix Held, Krystian Hebel, Martin L Roth, Patrick Rudolph, Sergii Dmytruk. Michał Żygowski has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83424?usp=email ) Change subject: drivers/smmstore: add ability to write to whole flash ...................................................................... Patch Set 15: (1 comment) Patchset: PS15: > The changes were split like that from the start in https://github. […] One has to opt-in for CONFIG_DRIVERS_EFI_UPDATE_CAPSULES and that's it. It will allow the SMMSTOR handler to write to whole flash. That's what I am talking about. So I think it would be better to squash it with the subsequent commit that already checks for cpasule presence to unlock full flash access in SMMSTORE handler. -- To view, visit https://review.coreboot.org/c/coreboot/+/83424?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7f3dbfa965b9dcbade8b2f06a5bd2ac1345c7972 Gerrit-Change-Number: 83424 Gerrit-PatchSet: 15 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 02 Apr 2025 14:16:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[S] Change in coreboot[main]: payloads/external/iPXE/: Allow building EFI target
by Filip Lewiński (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Felix Singer, Krystian Hebel, Maciej Pijanowski, Martin L Roth, Matt DeVillier, Michał Kopeć, Michał Żygowski. Filip Lewiński has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/83385?usp=email ) Change subject: payloads/external/iPXE/: Allow building EFI target ...................................................................... Patch Set 4: (2 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/83385/comment/76047900_92dfcc12?us… : PS3, Line 7: Build iPXE for EFI target if requested > Suggestion: […] [Done](https://review.coreboot.org/c/coreboot/+/83385/4//COMMIT_MSG#7) https://review.coreboot.org/c/coreboot/+/83385/comment/ce3b2333_96256e54?us… : PS3, Line 7: /Makefile > Remove "Makefile" from the title. [Done](https://review.coreboot.org/c/coreboot/+/83385/4//COMMIT_MSG#7) -- To view, visit https://review.coreboot.org/c/coreboot/+/83385?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7f247a59a65aeb18a67475d4d543f519af88aeb9 Gerrit-Change-Number: 83385 Gerrit-PatchSet: 4 Gerrit-Owner: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 14:09:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025