coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
2949 discussions

[S] Change in coreboot[main]: soc/mediatek/mt8189: Add NOR-Flash support
by Yu-Ping Wu (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Hung-Te Lin, Vince Liu. Yu-Ping Wu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/86997?usp=email ) Change subject: soc/mediatek/mt8189: Add NOR-Flash support ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86997?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3a5b7682e4093f9eddf825bc57267b0180cf8b3c Gerrit-Change-Number: 86997 Gerrit-PatchSet: 2 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 09:53:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: google/chromeec: Add function to report the SKU ID
by Aamir Bohra (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Dinesh Gehlot, Eran Mitrani, Eric Lai, Hung-Te Lin, Jakub "Kuba" Czapiga, Jason Nien, Jayvik Desai, Julius Werner, Kapil Porwal, Martin Roth, Nick Vaccaro, Paul Menzel, Pranava Y N, Subrata Banik, Subrata Banik, Tarun. Aamir Bohra has posted comments on this change by Aamir Bohra. ( https://review.coreboot.org/c/coreboot/+/86810?usp=email ) Change subject: google/chromeec: Add function to report the SKU ID ...................................................................... Patch Set 12: (1 comment) File src/ec/google/chromeec/Makefile.mk: https://review.coreboot.org/c/coreboot/+/86810/comment/6b112208_0bbb6773?us… : PS12, Line 14: y > > > if you need google_chromeec_get_board_sku for platform w/ EC_GOOGLE_CHROMEEC_SMBIOS, then you ca […] With this implementation, google_chromeec_get_board_sku is not linked with EC_GOOGLE_CHROMEEC_SKUID, now EC_GOOGLE_CHROMEEC_SMBIOS does not have any dependency on EC_GOOGLE_CHROMEEC_SKUID as google_chromeec_get_board_sku is available for all boards selecting EC_GOOGLE_CHROMEEC -- To view, visit https://review.coreboot.org/c/coreboot/+/86810?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I958cc88bf316dd2327b6545c5a37e8010e96c5d7 Gerrit-Change-Number: 86810 Gerrit-PatchSet: 12 Gerrit-Owner: Aamir Bohra <aamirbohra(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 09:38:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Aamir Bohra <aamirbohra(a)google.com>

1 0

[S] Change in coreboot[main]: mb/starlabs/byte_adl: Remove the override verb function
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87095?usp=email ) Change subject: mb/starlabs/byte_adl: Remove the override verb function ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/87095?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic47f9c3b40dd76a78325b024ba8f93a117f7d031 Gerrit-Change-Number: 87095 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 02 Apr 2025 09:13:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: mb/starlabs/starbook: Simplify CFR options
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Matt DeVillier. Sean Rhodes has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/87088?usp=email ) Change subject: mb/starlabs/starbook: Simplify CFR options ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/mainboard/starlabs/starbook/Kconfig: https://review.coreboot.org/c/coreboot/+/87088/comment/68931944_c07d301f?us… : PS1, Line 267: BOARD_SUPPORTS_PCIE_ASPM Can use SOC_INTEL_COMMON_BLOCK_ASPM -- To view, visit https://review.coreboot.org/c/coreboot/+/87088?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I43dfa6795708e9975b938ce1359629f6b9c4f1cf Gerrit-Change-Number: 87088 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 09:07:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the SMBUS
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87079?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the SMBUS ...................................................................... mb/starlabs/starbook/adl_n: Tidy GPIO comments for the SMBUS This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: I8456c5fa72d0c8620469e9c9ea260c60100db40e Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87079 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 514d2d8..e7a68c2 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -74,6 +74,11 @@ /* TPM */ PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* Interrupt */ + /* SMBus */ + PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* Data */ + PAD_CFG_GPO(GPP_E8, 1, DEEP), /* DRAM Sleep */ + PAD_NC(GPD2, NONE), PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ @@ -157,10 +162,6 @@ /* B25: Not Connected */ PAD_NC(GPP_B25, NONE), - /* C0: SMB Clock */ - PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), - /* C1: SMB Data */ - PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* C2: TLS Confidentiality Weak Internal PD 20K Low: Disabled High: Enabled */ @@ -261,8 +262,6 @@ PAD_CFG_GPO(GPP_E6, 0, DEEP), /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), - /* E8: DRAM Sleep */ - PAD_CFG_GPO(GPP_E8, 1, DEEP), /* E9: USB OverCurrent 0 */ PAD_NC(GPP_E9, NONE), /* E10: PWD Amplifier Input */ -- To view, visit https://review.coreboot.org/c/coreboot/+/87079?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8456c5fa72d0c8620469e9c9ea260c60100db40e Gerrit-Change-Number: 87079 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the TPM
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87078?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the TPM ...................................................................... mb/starlabs/starbook/adl_n: Tidy GPIO comments for the TPM This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: I147d0b9770c6a1d10b4e8996591508a42805a18c Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87078 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 782538a..514d2d8 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -71,6 +71,9 @@ PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1), /* Vendor ID 1 */ PAD_CFG_GPI_SCI(GPP_B2, NONE, PLTRST, EDGE_SINGLE, INVERT), /* Processor Hot */ + /* TPM */ + PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* Interrupt */ + PAD_NC(GPD2, NONE), PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ @@ -264,8 +267,6 @@ PAD_NC(GPP_E9, NONE), /* E10: PWD Amplifier Input */ PAD_NC(GPP_E10, NONE), - /* E11: TPM IRQ */ - PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* E13: Not connected */ PAD_NC(GPP_E13, NONE), /* E15: Not Connected */ -- To view, visit https://review.coreboot.org/c/coreboot/+/87078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I147d0b9770c6a1d10b4e8996591508a42805a18c Gerrit-Change-Number: 87078 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for PCH
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87077?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for PCH ...................................................................... mb/starlabs/starbook/adl_n: Tidy GPIO comments for PCH This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: I710f3ab84a4c6d76941a2a7dc3d41f87ba0c0415 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87077 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 8 insertions(+), 10 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 4fdabc5..782538a 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -64,6 +64,13 @@ PAD_CFG_NF(GPP_R3, NATIVE, DEEP, NF1), /* Data Input */ PAD_CFG_NF(GPP_R4, NATIVE, DEEP, NF1), /* Reset */ + /* PCH */ + PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), /* C10 Gate */ + PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), /* Platform Reset */ + PAD_CFG_NF(GPP_B0, NONE, DEEP, NF1), /* Vendor ID 0 */ + PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1), /* Vendor ID 1 */ + PAD_CFG_GPI_SCI(GPP_B2, NONE, PLTRST, EDGE_SINGLE, INVERT), /* Processor Hot */ + PAD_NC(GPD2, NONE), PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ @@ -101,12 +108,7 @@ /* A23: Not Connected */ PAD_NC(GPP_A23, NONE), - /* B0: Core Vendor ID 0 */ - PAD_CFG_NF(GPP_B0, NONE, DEEP, NF1), - /* B1: Core Vendor ID 1 */ - PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1), - /* B2: BC PROCHOT */ - PAD_CFG_GPI_SCI(GPP_B2, NONE, PLTRST, EDGE_SINGLE, INVERT), + /* B3: Not Connected */ PAD_NC(GPP_B3, NONE), /* B4: Not Connected */ @@ -123,8 +125,6 @@ PAD_NC(GPP_B11, NONE), /* B12: PM SLP S0 */ PAD_NC(GPP_B12, NONE), - /* B13: PLT RST */ - PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), /* B14: Top Swap Override Weak Internal PD 20K High: Enabled Low: Disabled */ @@ -362,8 +362,6 @@ PAD_NC(GPP_H14, NONE), /* H16: Not Connected */ PAD_NC(GPP_H16, NONE), - /* H18: CPI C10 Gate */ - PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), /* H19: Clock Request 4 CPU M.2 SSD */ PAD_NC(GPP_H19, NONE), /* H20: Not Connected */ -- To view, visit https://review.coreboot.org/c/coreboot/+/87077?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I710f3ab84a4c6d76941a2a7dc3d41f87ba0c0415 Gerrit-Change-Number: 87077 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for HDA
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87076?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for HDA ...................................................................... mb/starlabs/starbook/adl_n: Tidy GPIO comments for HDA This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: Ib40431a24037535e7c4d1bc49a5ae50576b62e33 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87076 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 7 insertions(+), 11 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 2bcc4ac..4fdabc5 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -57,6 +57,13 @@ PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* HDMI Data */ PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), /* TCP0 Hot Plug */ + /* High-Definition Audio */ + PAD_CFG_NF(GPP_R0, NATIVE, DEEP, NF1), /* Clock */ + PAD_CFG_NF(GPP_R1, NATIVE, DEEP, NF1), /* Sync */ + PAD_CFG_NF(GPP_R2, NATIVE, DEEP, NF1), /* Data Output */ + PAD_CFG_NF(GPP_R3, NATIVE, DEEP, NF1), /* Data Input */ + PAD_CFG_NF(GPP_R4, NATIVE, DEEP, NF1), /* Reset */ + PAD_NC(GPD2, NONE), PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ @@ -418,17 +425,6 @@ /* T15: Not Connected */ PAD_NC(GPP_T15, NONE), - /* R0: HDA BCLK */ - PAD_CFG_NF(GPP_R0, NATIVE, DEEP, NF1), - /* R1: HDA SYNC */ - PAD_CFG_NF(GPP_R1, NATIVE, DEEP, NF1), - /* R2: HDA SDO */ - PAD_CFG_NF(GPP_R2, NATIVE, DEEP, NF1), - /* R3: HDA SDI */ - PAD_CFG_NF(GPP_R3, NATIVE, DEEP, NF1), - /* R4: HDA Reset */ - PAD_CFG_NF(GPP_R4, NATIVE, DEEP, NF1), - /* R5: MiPi Cam Reset */ PAD_NC(GPP_R5, NONE), /* R6: Not Connected */ PAD_NC(GPP_R6, NONE), -- To view, visit https://review.coreboot.org/c/coreboot/+/87076?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib40431a24037535e7c4d1bc49a5ae50576b62e33 Gerrit-Change-Number: 87076 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for display outputs
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87075?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for display outputs ...................................................................... mb/starlabs/starbook/adl_n: Tidy GPIO comments for display outputs This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: Iaac4672fec3e282ffc3ea6acf07cfb56072ad850 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87075 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 7 insertions(+), 10 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 43ef9f2..2bcc4ac 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -50,6 +50,13 @@ PAD_CFG_GPO(GPP_E3, 1, DEEP), /* WiFi RF Kill */ PAD_CFG_GPO(GPP_A13, 1, DEEP), /* Bluetooth RF Kill */ + /* Display */ + PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* eDP Hot Plug */ + PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), /* HDMI Hot Plug */ + PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* HDMI Clock */ + PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* HDMI Data */ + PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), /* TCP0 Hot Plug */ + PAD_NC(GPD2, NONE), PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ @@ -78,10 +85,6 @@ PAD_NC(GPP_A16, NONE), /* A17: Not Connected */ PAD_NC(GPP_A17, NONE), - /* A18: DDI B DP HPD */ - PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), - /* A19: TCP0 HPD */ - PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), /* A20: Test Point 44 */ PAD_NC(GPP_A20, NONE), /* A21: Fingerprint Reader Interrupt */ @@ -258,8 +261,6 @@ PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* E13: Not connected */ PAD_NC(GPP_E13, NONE), - /* E14: EDP HPD */ - PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* E15: Not Connected */ PAD_NC(GPP_E15, NONE), /* E16: Not Connected */ @@ -352,12 +353,8 @@ PAD_NC(GPP_H13, NONE), /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), - /* H15: DDPB Control Clock */ - PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* H16: Not Connected */ PAD_NC(GPP_H16, NONE), - /* H17: DDPB Control Data */ - PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* H18: CPI C10 Gate */ PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), /* H19: Clock Request 4 CPU M.2 SSD */ -- To view, visit https://review.coreboot.org/c/coreboot/+/87075?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaac4672fec3e282ffc3ea6acf07cfb56072ad850 Gerrit-Change-Number: 87075 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the wireless
by Sean Rhodes (Code Review) 02 Apr '25

02 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87074?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the wireless ...................................................................... mb/starlabs/starbook/adl_n: Tidy GPIO comments for the wireless This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: Ie93658cc4f8f17be1ff59244c038f53095751be7 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87074 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 6 insertions(+), 8 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 7cf23e8..43ef9f2 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -44,6 +44,12 @@ PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* Reset */ PAD_CFG_GPO(GPP_D16, 1, DEEP), /* Enable */ + /* Wireless */ + PAD_CFG_NF(GPP_D6, NONE, DEEP, NF1), /* Clock Request 1 */ + PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* Reset */ + PAD_CFG_GPO(GPP_E3, 1, DEEP), /* WiFi RF Kill */ + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* Bluetooth RF Kill */ + PAD_NC(GPD2, NONE), PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ @@ -64,8 +70,6 @@ PAD_NC(GPP_A11, NONE), /* A12: Not Connected */ PAD_NC(GPP_A12, NONE), - /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A14: Test Point 45 */ PAD_NC(GPP_A14, NONE), /* A15: Test Point 52 */ @@ -203,8 +207,6 @@ PAD_NC(GPP_D3, NONE), /* D4: Not Connected */ PAD_NC(GPP_D4, NONE), - /* D6: Clock Request 1 Wireless LAN */ - PAD_CFG_NF(GPP_D6, NONE, DEEP, NF1), /* D7: Clock Request 2 */ PAD_NC(GPP_D7, NONE), /* D8: Clock Request 3 */ @@ -236,8 +238,6 @@ PAD_NC(GPP_E1, NONE), /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), - /* E3: WiFi RF Kill */ - PAD_CFG_GPO(GPP_E3, 1, DEEP), /* E4: Test Point 14 */ PAD_NC(GPP_E4, NONE), /* E5: Not Connected */ @@ -332,8 +332,6 @@ /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ PAD_CFG_GPO(GPP_H1, 0, DEEP), - /* H2: Wireless LAN Reset */ - PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */ PAD_NC(GPP_H3, NONE), /* H4: I2C 0 SDA Touchpad */ -- To view, visit https://review.coreboot.org/c/coreboot/+/87074?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie93658cc4f8f17be1ff59244c038f53095751be7 Gerrit-Change-Number: 87074 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025