coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[S] Change in coreboot[main]: mb/google/nissa/var/meliks: Generate SPD ID for supported parts
by SH Kim (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. SH Kim has posted comments on this change by SH Kim. ( https://review.coreboot.org/c/coreboot/+/86375?usp=email ) Change subject: mb/google/nissa/var/meliks: Generate SPD ID for supported parts ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: Ready for review. -- To view, visit https://review.coreboot.… [View More]

1 0

[S] Change in coreboot[main]: util/cbfstool: Add missing \n in debug messages
by Angel Pons (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, Intel coreboot Reviewers, Jincheng Li, Patrick Rudolph, Shuo Liu. Angel Pons has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/86567?usp=email ) Change subject: util/cbfstool: Add missing \n in debug messages ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/… [View More]

1 0

[S] Change in coreboot[main]: util/cbfstool: Add missing \n in debug messages
by Frans Hendriks (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, Intel coreboot Reviewers, Jincheng Li, Patrick Rudolph, Shuo Liu. Frans Hendriks has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/86567?usp=email ) Change subject: util/cbfstool: Add missing \n in debug messages ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/… [View More]

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Disable HWRot's clocks
by Guangjie Song (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin. Guangjie Song has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86553?usp=email ) Change subject: soc/mediatek/mt8196: Disable HWRot's clocks ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/86553/comment/264d5738_fd247f93?us… : PS4, Line 9: HWRot (Hardware Root of … [View More]

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Disable HWRot's clocks
by Guangjie Song (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Guangjie Song, Hung-Te Lin, Jarried Lin, Yidi Lin. Guangjie Song has uploaded a new patch set (#5) to the change originally created by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86553?usp=email ) Change subject: soc/mediatek/mt8196: Disable HWRot's clocks ...................................................................... soc/mediatek/mt8196: Disable HWRot's clocks HWRot (Hardware Root of trust) is not used, so we disable its clocks to … [View More]

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/pujjoniru: Modify the gpio of GPIO_PCH_WP
by hualin wei (Code Review) 24 Feb '25

24 Feb '25

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/pujjoniru: Modify the gpio of GPIO_PCH_WP
by hualin wei (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Subrata Banik. hualin wei has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/86554?usp=email ) Change subject: mb/google/nissa/var/pujjoniru: Modify the gpio of GPIO_PCH_WP ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/brya/variants/pujjoniru/include/… [View More]variant/gpio.h: https://review.coreboot.org/c/coreboot/+/86554/comment/a6d78f73_fd2f7a88?us… : PS3, Line 8: #undef GPIO_PCH_WP > do u need this ? Yes, I need. Otherwise there will be duplicate definitions In file included from src/mainboard/google/brya/variants/pujjoniru/gpio.c:3: src/mainboard/google/brya/variants/pujjoniru/include/variant/gpio.h:9: error: "GPIO_PCH_WP" redefined [-Werror] 9 | #define GPIO_PCH_WP GPP_E17 | In file included from src/mainboard/google/brya/variants/pujjoniru/include/variant/gpio.h:6, from src/mainboard/google/brya/variants/pujjoniru/gpio.c:3: src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/gpio.h:14: note: this is the location of the previous definition 14 | #define GPIO_PCH_WP GPP_E12 -- To view, visit https://review.coreboot.org/c/coreboot/+/86554?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic92ff33a5fde50a1a400043b2daba0414eb9e255 Gerrit-Change-Number: 86554 Gerrit-PatchSet: 3 Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 24 Feb 2025 07:38:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> [View Less]

1 0

[S] Change in coreboot[main]: soc/intel/pantherlake: Add early shutdown notification hook
by Subrata Banik (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Christian Walter, Intel coreboot Reviewers, Jayvik Desai, Julius Werner, Kapil Porwal, Karthik Ramasubramanian, Pranava Y N, Subrata Banik. Hello Christian Walter, Intel coreboot Reviewers, Jayvik Desai, Julius Werner, Kapil Porwal, Karthik Ramasubramanian, Pranava Y N, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86476?usp=email to look at the new patch set (#4). The following … [View More]approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/intel/pantherlake: Add early shutdown notification hook ...................................................................... soc/intel/pantherlake: Add early shutdown notification hook This commit display UX message for low-battery shutdown using platform_display_early_shutdown_notification(). This commit also enables the HAVE_ESOL_SUPPORT_FOR_LOW_BATTERY_INDICATOR Kconfig option, which is required for displaying the VGA text message during early shutdown. This patch also refactor `fill_fspm_sign_of_life` to use UX API `ux_inform_user_of_update_operation` for memory training notification. BUG=b:339673254 TEST=Verified low battery boot event logging and controlled shutdown. Change-Id: I45c0fb07b984fcde6209631612cb8b4a08ac2041 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/soc/intel/pantherlake/Kconfig M src/soc/intel/pantherlake/romstage/fsp_params.c 2 files changed, 12 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/86476/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/86476?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I45c0fb07b984fcde6209631612cb8b4a08ac2041 Gerrit-Change-Number: 86476 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> [View Less]

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Disable HWRot's clocks
by Yu-Ping Wu (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Guangjie Song, Hung-Te Lin, Jarried Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86553?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/mediatek/mt8196: Disable HWRot's clocks ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Commit Message: https://review.… [View More]

1 0

[XS] Change in coreboot[main]: mb/google/trulo: Lock GPIO pad configuration for GPP_F17
by Kapil Porwal (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Nick Vaccaro, Subrata Banik. Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86579?usp=email ) Change subject: mb/google/trulo: Lock GPIO pad configuration for GPP_F17 ...................................................................... mb/google/trulo: Lock GPIO pad configuration for GPP_F17 BUG=b:397905085 TEST=Make sure that GPP_F17 pad configuration is locked. … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025