Attention is currently required from: Maxim Polyakov.
Maximilian Brune has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/70307?usp=email )
Change subject: util/intelp2m: Drop multi-template support
......................................................................
Patch Set 17: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70307?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07124cca487f11641c4e107134efb8cfc29c6731
Gerrit-Change-Number: 70307
Gerrit-PatchSet: 17
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 18:18:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Daniel Maslowski, Maxim Polyakov.
David Hendricks has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/70308?usp=email )
Change subject: util/intelp2m/config: Rework configuration package
......................................................................
Patch Set 17: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70308?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia1b19ae3122bcf6ec740ae4683d62f31570670b1
Gerrit-Change-Number: 70308
Gerrit-PatchSet: 17
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 18:18:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Maxim Polyakov.
David Hendricks has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/70307?usp=email )
Change subject: util/intelp2m: Drop multi-template support
......................................................................
Patch Set 17: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70307?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07124cca487f11641c4e107134efb8cfc29c6731
Gerrit-Change-Number: 70307
Gerrit-PatchSet: 17
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 18:16:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Kapil Porwal, Matt DeVillier, Tarun.
Subrata Banik has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86611?usp=email )
Change subject: soc/intel/meteorlake: Hook up FSP repo
......................................................................
Patch Set 1: Code-Review-2
Copied votes on follow-up patch sets have been updated:
* Code-Review-2 has been copied to patch set 2 (copy condition: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN").
(1 comment)
Patchset:
PS1:
This is FSP coming from IOT team and not from clients . so, please use a specific Kconfig if required to override the default path.
FSP implementation for client and iot SoC are different.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86611?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I44ee923f4d1151f0e11104af7db53ce59551cf37
Gerrit-Change-Number: 86611
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 18:10:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Kapil Porwal, Matt DeVillier, Subrata Banik, Tarun.
Hello Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Kapil Porwal, Subrata Banik, Tarun, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86611?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: soc/intel/meteorlake: Hook up FSP repo
......................................................................
soc/intel/meteorlake: Hook up FSP repo
FSP binaries for MTL are now available on github, so select
'HAVE_INTEL_FSP_REPO' and add/correct the path for the FSP headers
and binary.
TEST=build/boot starlabs/starbook_mtl
Change-Id: I44ee923f4d1151f0e11104af7db53ce59551cf37
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/soc/intel/meteorlake/Kconfig
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/86611/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86611?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I44ee923f4d1151f0e11104af7db53ce59551cf37
Gerrit-Change-Number: 86611
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Attention is currently required from: Aamir Bohra, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change by Aamir Bohra. ( https://review.coreboot.org/c/coreboot/+/86599?usp=email )
Change subject: mb/google/brya: Add support to get sku ID
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> >> in that case, can you implement sku_id() inside cros_ec file itself so you don't need to implement per board basic ? and use some smart method to call into ADC PIN when CONFIG_SKUID_VIA_CHROMEEC vs CONFIG_SKUID_VIA_ADC_PIN.
>
> IIUC, cros_ec hosts the ec<->host APIs, Since sku_id is specific to mainboards and allows to define mainboard specific SKU ID mechanisms, this can be implemented per board.
>
> >> In any case, you need a better commit msg, the current code doesn't convey what you are trying to achieve
>
> Agree, updated the commit, PTAL.
you can always push code into some common directory like vendor to implement a common API that works for CrOS specific implementation rather duplicating one api across different main boards.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86599?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie55a9d83871f41e191574e554fe7d287c1ee60bd
Gerrit-Change-Number: 86599
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra <aamirbohra(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Aamir Bohra <aamirbohra(a)google.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 18:09:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Aamir Bohra <aamirbohra(a)google.com>
Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Aamir Bohra has posted comments on this change by Aamir Bohra. ( https://review.coreboot.org/c/coreboot/+/86599?usp=email )
Change subject: mb/google/brya: Add support to get sku ID
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> > I am implementing the sku_id defined in https://github. […]
>> in that case, can you implement sku_id() inside cros_ec file itself so you don't need to implement per board basic ? and use some smart method to call into ADC PIN when CONFIG_SKUID_VIA_CHROMEEC vs CONFIG_SKUID_VIA_ADC_PIN.
IIUC, cros_ec hosts the ec<->host APIs, Since sku_id is specific to mainboards and allows to define mainboard specific SKU ID mechanisms, this can be implemented per board.
>> In any case, you need a better commit msg, the current code doesn't convey what you are trying to achieve
Agree, updated the commit, PTAL.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86599?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie55a9d83871f41e191574e554fe7d287c1ee60bd
Gerrit-Change-Number: 86599
Gerrit-PatchSet: 2
Gerrit-Owner: Aamir Bohra <aamirbohra(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Wed, 26 Feb 2025 17:57:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Aamir Bohra <aamirbohra(a)google.com>
Attention is currently required from: Aamir Bohra, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro.
Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86599?usp=email
to look at the new patch set (#3).
Change subject: mb/google/brya: Add support to get sku ID
......................................................................
mb/google/brya: Add support to get sku ID
Sku ID is provisioned in the CBI EEPROM for the brya mainboard.
Implement sku_id function that gets the sku ID infomration from the CBI
EEPROM via ec host command. The sku_id function is further be used for
sending the SKU ID information via coreboot tables.
BUG=b:396366352
TEST=Verify coreboot table has valid SKU ID entry
Change-Id: Ie55a9d83871f41e191574e554fe7d287c1ee60bd
Signed-off-by: Aamir Bohra <aamirbohra(a)google.com>
---
M src/mainboard/google/brya/Makefile.mk
A src/mainboard/google/brya/sku_id.c
2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/86599/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/86599?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie55a9d83871f41e191574e554fe7d287c1ee60bd
Gerrit-Change-Number: 86599
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra <aamirbohra(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Aamir Bohra <aamirbohra(a)google.com>
Attention is currently required from: Christian Walter, Intel coreboot Reviewers, Johnny Lin, Jonathan Zhang, Patrick Rudolph, Shuo Liu, Tim Chu.
Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86604?usp=email )
Change subject: soc/intel/xeon_sp/spr: Use default turbo ratio
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86604?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib8fbc78997fc7f8e6c80b2029d63b70f6117542e
Gerrit-Change-Number: 86604
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 17:43:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes