coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[L] Change in coreboot[main]: mb/*/*/irq_tables.c: Use PCI_DEVFN(dev, fn)
by Maximilian Brune (Code Review) 26 Feb '25

26 Feb '25

Attention is currently required from: Elyes Haouas. Maximilian Brune has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/69066?usp=email ) Change subject: mb/*/*/irq_tables.c: Use PCI_DEVFN(dev, fn) ...................................................................... Patch Set 9: Code-Review+2 (14 comments) File src/mainboard/asus/p2b/variants/p2b/irq_tables.c: https://review.coreboot.org/c/coreboot/+/69066/comment/9d63f144_e37932b1?us… : PS9, Line 21: {0x00,PCI_DEVFN(0x0c, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x1, 0x0}, > `space required after that ',' (ctx:VxV)` Please fix. https://review.coreboot.org/c/coreboot/+/69066/comment/589853ce_8c3ce779?us… : PS9, Line 22: {0x00,PCI_DEVFN(0x0b, 0), {{0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x1eb8}, {0x60, 0x01eb8}}, 0x2, 0x0}, > `space required after that ',' (ctx:VxV)` Please fix. https://review.coreboot.org/c/coreboot/+/69066/comment/a602b5df_d67f64cd?us… : PS9, Line 23: {0x00,PCI_DEVFN(0x0a, 0), {{0x62, 0x1eb8}, {0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x01eb8}}, 0x3, 0x0}, > `space required after that ',' (ctx:VxV)` Please fix. https://review.coreboot.org/c/coreboot/+/69066/comment/de00d852_3516cc92?us… : PS9, Line 24: {0x00,PCI_DEVFN(0x09, 0), {{0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x01eb8}}, 0x4, 0x0}, > `space required after that ',' (ctx:VxV)` Please fix. https://review.coreboot.org/c/coreboot/+/69066/comment/16c20c92_93b48b2e?us… : PS9, Line 25: {0x00,PCI_DEVFN(0x04, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x0, 0x0}, > `space required after that ',' (ctx:VxV)` Please fix. https://review.coreboot.org/c/coreboot/+/69066/comment/b8c6aa9f_0cb38c4e?us… : PS9, Line 26: {0x00,PCI_DEVFN(0x01, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x0, 0x0}, > `space required after that ',' (ctx:VxV)` Please fix. File src/mainboard/asus/p2b/variants/p3b-f/irq_tables.c: https://review.coreboot.org/c/coreboot/+/69066/comment/3d257076_90ec63aa?us… : PS9, Line 21: {0x00,PCI_DEVFN(0x0c, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x1, 0x0}, > `space required after that ',' (ctx:VxV)` Please fix. https://review.coreboot.org/c/coreboot/+/69066/comment/472e9fa9_1bbe6e0f?us… : PS9, Line 22: {0x00,PCI_DEVFN(0x0b, 0), {{0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x1eb8}, {0x60, 0x01eb8}}, 0x2, 0x0}, > `space required after that ',' (ctx:VxV)` Please fix. https://review.coreboot.org/c/coreboot/+/69066/comment/811f2568_39d8a2dc?us… : PS9, Line 23: {0x00,PCI_DEVFN(0x0a, 0), {{0x62, 0x1eb8}, {0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x01eb8}}, 0x3, 0x0}, > `space required after that ',' (ctx:VxV)` Please fix. https://review.coreboot.org/c/coreboot/+/69066/comment/6638f70e_dd3a8d11?us… : PS9, Line 24: {0x00,PCI_DEVFN(0x09, 0), {{0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x01eb8}}, 0x4, 0x0}, > `space required after that ',' (ctx:VxV)` Please fix. https://review.coreboot.org/c/coreboot/+/69066/comment/76676668_af5f47f4?us… : PS9, Line 25: {0x00,PCI_DEVFN(0x0d, 0), {{0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x01eb8}}, 0x5, 0x0}, > `space required after that ',' (ctx:VxV)` Please fix. https://review.coreboot.org/c/coreboot/+/69066/comment/4818ba64_9235f8aa?us… : PS9, Line 26: {0x00,PCI_DEVFN(0x0e, 0), {{0x62, 0x1eb8}, {0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x01eb8}}, 0x6, 0x0}, > `space required after that ',' (ctx:VxV)` Please fix. https://review.coreboot.org/c/coreboot/+/69066/comment/a4c5bc0f_c5cd053f?us… : PS9, Line 27: {0x00,PCI_DEVFN(0x04, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x0, 0x0}, > `space required after that ',' (ctx:VxV)` Please fix. https://review.coreboot.org/c/coreboot/+/69066/comment/6c464141_46902140?us… : PS9, Line 28: {0x00,PCI_DEVFN(0x01, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x0, 0x0}, > `space required after that ',' (ctx:VxV)` Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/69066?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic97bf7c8f04edbb56f200c34060d22a8c5fb7ec2 Gerrit-Change-Number: 69066 Gerrit-PatchSet: 9 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 26 Feb 2025 18:58:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: util/intelp2m: Drop multi-template support
by Maximilian Brune (Code Review) 26 Feb '25

26 Feb '25

Attention is currently required from: Maxim Polyakov. Maximilian Brune has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/70307?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: util/intelp2m: Drop multi-template support ...................................................................... Patch Set 17: -Code-Review (1 comment) Patchset: PS17: Looking at this patch series it seems that 80% of all changes in each patch are just about formatting. Can you put the formating stuff (everything that doesn't change the binary) into 1 single patch? I know its asking a lot but it is really hard to review if only 20% of the changes you do in each patch actually matter functionality wise. -- To view, visit https://review.coreboot.org/c/coreboot/+/70307?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I07124cca487f11641c4e107134efb8cfc29c6731 Gerrit-Change-Number: 70307 Gerrit-PatchSet: 17 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Feb 2025 18:28:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel/meteorlake: Hook up FSP repo for IOT
by Subrata Banik (Code Review) 26 Feb '25

26 Feb '25

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Kapil Porwal, Matt DeVillier, Tarun. Subrata Banik has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86611?usp=email ) Change subject: soc/intel/meteorlake: Hook up FSP repo for IOT ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > done Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/86611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I44ee923f4d1151f0e11104af7db53ce59551cf37 Gerrit-Change-Number: 86611 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Feb 2025 18:27:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[S] Change in coreboot[main]: soc/intel/meteorlake: Hook up FSP repo for IOT
by Subrata Banik (Code Review) 26 Feb '25

26 Feb '25

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Kapil Porwal, Matt DeVillier, Tarun. Subrata Banik has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86611?usp=email ) Change subject: soc/intel/meteorlake: Hook up FSP repo for IOT ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/86611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I44ee923f4d1151f0e11104af7db53ce59551cf37 Gerrit-Change-Number: 86611 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Feb 2025 18:26:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: util/intelp2m/config: Rework configuration package
by Maximilian Brune (Code Review) 26 Feb '25

26 Feb '25

Attention is currently required from: Daniel Maslowski, Maxim Polyakov. Maximilian Brune has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/70308?usp=email ) Change subject: util/intelp2m/config: Rework configuration package ...................................................................... Patch Set 17: Code-Review+2 (1 comment) File util/intelp2m/platforms/apl/macro.go: https://review.coreboot.org/c/coreboot/+/70308/comment/406e99b3_094d9766?us… : PS17, Line 132: & nit: looks worse then before in my opinion. -- To view, visit https://review.coreboot.org/c/coreboot/+/70308?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia1b19ae3122bcf6ec740ae4683d62f31570670b1 Gerrit-Change-Number: 70308 Gerrit-PatchSet: 17 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Feb 2025 18:24:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel/meteorlake: Hook up FSP repo for IOT
by Matt DeVillier (Code Review) 26 Feb '25

26 Feb '25

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Kapil Porwal, Subrata Banik, Tarun. Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86611?usp=email ) Change subject: soc/intel/meteorlake: Hook up FSP repo for IOT ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > This is FSP coming from IOT team and not from clients . […] done -- To view, visit https://review.coreboot.org/c/coreboot/+/86611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I44ee923f4d1151f0e11104af7db53ce59551cf37 Gerrit-Change-Number: 86611 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Feb 2025 18:24:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[M] Change in coreboot[main]: Documentation/util/intelp2m: Add info for developers
by David Hendricks (Code Review) 26 Feb '25

26 Feb '25

Attention is currently required from: Maxim Polyakov. David Hendricks has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/85791?usp=email ) Change subject: Documentation/util/intelp2m: Add info for developers ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85791?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9cc886e607c1aba92b94e06419d45d9581371065 Gerrit-Change-Number: 85791 Gerrit-PatchSet: 4 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Feb 2025 18:24:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: util/intelp2m/platforms: Add support for Elkhart Lake
by David Hendricks (Code Review) 26 Feb '25

26 Feb '25

Attention is currently required from: Alexander Couzens, Maxim Polyakov. David Hendricks has posted comments on this change by Alexander Couzens. ( https://review.coreboot.org/c/coreboot/+/84191?usp=email ) Change subject: util/intelp2m/platforms: Add support for Elkhart Lake ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84191?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0f60d182bc5cc3d0d1d1177fbda0cfe8e2279e46 Gerrit-Change-Number: 84191 Gerrit-PatchSet: 11 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 26 Feb 2025 18:23:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel/meteorlake: Hook up FSP repo for IOT
by Matt DeVillier (Code Review) 26 Feb '25

26 Feb '25

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Kapil Porwal, Matt DeVillier, Tarun. Hello Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Kapil Porwal, Subrata Banik, Tarun, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86611?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: soc/intel/meteorlake: Hook up FSP repo for IOT ...................................................................... soc/intel/meteorlake: Hook up FSP repo for IOT IOT FSP binaries for MTL are available on github, so add FSP_TYPE_IOT Kconfig option, select 'HAVE_INTEL_FSP_REPO', and add the paths for the FSP headers and binary. TEST=build/boot starlabs/starbook_mtl Change-Id: I44ee923f4d1151f0e11104af7db53ce59551cf37 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/soc/intel/meteorlake/Kconfig 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/86611/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/86611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I44ee923f4d1151f0e11104af7db53ce59551cf37 Gerrit-Change-Number: 86611 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com>

1 0

[NoOp] Change in coreboot[main]: intelp2m/platforms: Rename macro.go to match module name
by David Hendricks (Code Review) 26 Feb '25

26 Feb '25

Attention is currently required from: Maxim Polyakov. David Hendricks has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/85770?usp=email ) Change subject: intelp2m/platforms: Rename macro.go to match module name ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85770?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5eeb24d668a8d478720ecccf1522238e70dd8a71 Gerrit-Change-Number: 85770 Gerrit-PatchSet: 5 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Feb 2025 18:23:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025