coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2887 discussions

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v4.0
by Yu-Ping Wu (Code Review) 06 Feb '25

06 Feb '25

Attention is currently required from: Jarried Lin, Kenji Yu. Yu-Ping Wu has posted comments on this change by Kenji Yu. ( https://review.coreboot.org/c/blobs/+/86293?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v4.0 ...................................................................... Patch Set 3: Code-Review+2 Verified+1 -- To view, visit https://review.coreboot.org/c/blobs/+/86293?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Ic717aba8ec18c55659cb3197c19984718646bfec Gerrit-Change-Number: 86293 Gerrit-PatchSet: 3 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Thu, 06 Feb 2025 09:53:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: [This Must Fail]Upgrade GCC to 15-20250202 Snapshot
by Elyes Haouas (Code Review) 06 Feb '25

06 Feb '25

Attention is currently required from: Felix Singer, Julius Werner, Martin L Roth, Maximilian Brune. Hello Felix Singer, Julius Werner, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86100?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: [This Must Fail]Upgrade GCC to 15-20250202 Snapshot ...................................................................... [This Must Fail]Upgrade GCC to 15-20250202 Snapshot Must fail, at least to build qemu-i440fx: from build/mainboard/emulation/qemu-i440fx/static.c:2: src/commonlib/include/commonlib/loglevel.h:170:26: error: initializer-string for array of 'char' is too long [-Werror=unterminated-string-initialization] 170 | [BIOS_EMERG] = "EMERG", | ^~~~~~~ otherwise there is a problem, Jenkins is doing wrong! Change-Id: I5e6c3745eebeb6ded494c153010283b761498184 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc R util/crossgcc/patches/gcc-15-20250202_asan_shadow_offset_callback.patch R util/crossgcc/patches/gcc-15-20250202_gnat.patch R util/crossgcc/patches/gcc-15-20250202_libcpp.patch R util/crossgcc/patches/gcc-15-20250202_libgcc.patch R util/crossgcc/patches/gcc-15-20250202_musl_poisoned_calloc.patch R util/crossgcc/patches/gcc-15-20250202_rv32iafc.patch D util/crossgcc/sum/gcc-14.2.0.tar.xz.cksum A util/crossgcc/sum/gcc-15-20250202.tar.xz.cksum 9 files changed, 48 insertions(+), 39 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/86100/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/86100?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e6c3745eebeb6ded494c153010283b761498184 Gerrit-Change-Number: 86100 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>

1 0

[S] Change in coreboot[main]: [only for test]Switch to C23
by Elyes Haouas (Code Review) 06 Feb '25

06 Feb '25

Attention is currently required from: Felix Singer, Jakub "Kuba" Czapiga, Julius Werner, Martin L Roth, Maximilian Brune. Hello Jakub "Kuba" Czapiga, Julius Werner, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86012?usp=email to look at the new patch set (#3). Change subject: [only for test]Switch to C23 ...................................................................... [only for test]Switch to C23 Change-Id: Ib4b2184e5c57143b11e3cc433d09d74a83028420 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk M payloads/libpayload/Makefile M payloads/libpayload/tests/Makefile.mk M tests/Makefile.common M util/cbfstool/Makefile.mk M util/cbfstool/lz4/lib/Makefile M util/superiotool/Makefile 7 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/86012/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/86012?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4b2184e5c57143b11e3cc433d09d74a83028420 Gerrit-Change-Number: 86012 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v4.0
by Yidi Lin (Code Review) 06 Feb '25

06 Feb '25

Attention is currently required from: Jarried Lin, Kenji Yu, Yu-Ping Wu. Yidi Lin has posted comments on this change by Kenji Yu. ( https://review.coreboot.org/c/blobs/+/86293?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v4.0 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/86293?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Ic717aba8ec18c55659cb3197c19984718646bfec Gerrit-Change-Number: 86293 Gerrit-PatchSet: 3 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 06 Feb 2025 09:34:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v4.0
by Jarried Lin (Code Review) 06 Feb '25

06 Feb '25

Attention is currently required from: Kenji Yu, Yidi Lin, Yu-Ping Wu. Jarried Lin has posted comments on this change by Kenji Yu. ( https://review.coreboot.org/c/blobs/+/86293?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v4.0 ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/blobs/+/86293/comment/b1ef23f5_042c9853?usp=e… : PS2, Line 9: Update sspm.bin to fix EMI unmap register issue and make syetem fully sleep to meet power consumption. > line too long Done https://review.coreboot.org/c/blobs/+/86293/comment/4ea28b5c_39dadaeb?usp=e… : PS2, Line 9: syetem > system Done -- To view, visit https://review.coreboot.org/c/blobs/+/86293?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Ic717aba8ec18c55659cb3197c19984718646bfec Gerrit-Change-Number: 86293 Gerrit-PatchSet: 3 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Thu, 06 Feb 2025 09:32:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v4.0
by Jarried Lin (Code Review) 06 Feb '25

06 Feb '25

Attention is currently required from: Kenji Yu, Yidi Lin. Jarried Lin has uploaded a new patch set (#3) to the change originally created by Kenji Yu. ( https://review.coreboot.org/c/blobs/+/86293?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v4.0 ...................................................................... soc/mediatek/mt8196: Update SSPM firmware to v4.0 Update sspm.bin to fix EMI unmap register issue and make system fully sleep to meet power consumption. BRANCH=rauru TEST=Build pass BUG=b:394704589 Change-Id: Ic717aba8ec18c55659cb3197c19984718646bfec Signed-off-by: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/sspm.bin M soc/mediatek/mt8196/sspm.bin.md5 M soc/mediatek/mt8196/sspm_release_notes.txt 3 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/93/86293/3 -- To view, visit https://review.coreboot.org/c/blobs/+/86293?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Ic717aba8ec18c55659cb3197c19984718646bfec Gerrit-Change-Number: 86293 Gerrit-PatchSet: 3 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v4.0
by Yu-Ping Wu (Code Review) 06 Feb '25

06 Feb '25

Attention is currently required from: Kenji Yu, Yidi Lin. Yu-Ping Wu has posted comments on this change by Kenji Yu. ( https://review.coreboot.org/c/blobs/+/86293?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v4.0 ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/blobs/+/86293/comment/8054319d_4f27b5fc?usp=e… : PS2, Line 9: syetem system https://review.coreboot.org/c/blobs/+/86293/comment/eb2495ba_23fab6d8?usp=e… : PS2, Line 9: Update sspm.bin to fix EMI unmap register issue and make syetem fully sleep to meet power consumption. line too long -- To view, visit https://review.coreboot.org/c/blobs/+/86293?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Ic717aba8ec18c55659cb3197c19984718646bfec Gerrit-Change-Number: 86293 Gerrit-PatchSet: 2 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Thu, 06 Feb 2025 09:29:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: [only for test]Switch to C23
by Elyes Haouas (Code Review) 06 Feb '25

06 Feb '25

Attention is currently required from: Felix Singer, Jakub "Kuba" Czapiga, Julius Werner, Martin L Roth, Maximilian Brune. Hello Jakub "Kuba" Czapiga, Julius Werner, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86012?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: [only for test]Switch to C23 ...................................................................... [only for test]Switch to C23 Change-Id: Ib4b2184e5c57143b11e3cc433d09d74a83028420 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk M util/cbfstool/Makefile.mk M util/cbfstool/lz4/lib/Makefile 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/86012/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86012?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4b2184e5c57143b11e3cc433d09d74a83028420 Gerrit-Change-Number: 86012 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>

1 0

[S] Change in coreboot[main]: mb/google/rauru: Support the panel with a load switch control
by Yu-Ping Wu (Code Review) 06 Feb '25

06 Feb '25

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/86282?usp=email ) Change subject: mb/google/rauru: Support the panel with a load switch control ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86282?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I57dcaa2a0b5af94fe3fa3eaf04e9f3159c51d144 Gerrit-Change-Number: 86282 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Thu, 06 Feb 2025 09:28:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: drivers/intel/gma: Drop unused MAILBOXES_DESKTOP
by Sean Rhodes (Code Review) 06 Feb '25

06 Feb '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86279?usp=email ) Change subject: drivers/intel/gma: Drop unused MAILBOXES_DESKTOP ...................................................................... drivers/intel/gma: Drop unused MAILBOXES_DESKTOP MAILBOXES_DESKTOP is unused, and the IGD opregion spec makes no distinction in the mailboxes supported between desktop and mobile platforms. Rename MAILBOXES_MOBILE to IGD_MAILBOXES for consistency with other mailbox variables and clean up the comment. Change-Id: Ia06fe75702887aa6953bf17bd4bc14af4038bec5 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86279 Reviewed-by: Jérémy Compostella <jeremy.compostella(a)intel.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/drivers/intel/gma/opregion.c M src/drivers/intel/gma/opregion.h 2 files changed, 3 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Jérémy Compostella: Looks good to me, approved diff --git a/src/drivers/intel/gma/opregion.c b/src/drivers/intel/gma/opregion.c index 92665e0..4f5f802 100644 --- a/src/drivers/intel/gma/opregion.c +++ b/src/drivers/intel/gma/opregion.c @@ -367,8 +367,8 @@ /* 8kb */ opregion->header.size = sizeof(igd_opregion_t) / 1024; - // FIXME We just assume we're mobile for now - opregion->header.mailboxes = MAILBOXES_MOBILE; + // Supported mailboxes + opregion->header.mailboxes = IGD_MAILBOXES; // TODO Initialize Mailbox 1 opregion->mailbox1.clid = 1; diff --git a/src/drivers/intel/gma/opregion.h b/src/drivers/intel/gma/opregion.h index 2de9213..77fccf8 100644 --- a/src/drivers/intel/gma/opregion.h +++ b/src/drivers/intel/gma/opregion.h @@ -41,8 +41,7 @@ #define IGD_MBOX4 (1 << 3) #define IGD_MBOX5 (1 << 4) -#define MAILBOXES_MOBILE (IGD_MBOX1 | IGD_MBOX3 | IGD_MBOX4 | IGD_MBOX5) -#define MAILBOXES_DESKTOP (IGD_MBOX2 | IGD_MBOX4) +#define IGD_MAILBOXES (IGD_MBOX1 | IGD_MBOX3 | IGD_MBOX4 | IGD_MBOX5) #define SBIOS_VERSION_SIZE 32 -- To view, visit https://review.coreboot.org/c/coreboot/+/86279?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia06fe75702887aa6953bf17bd4bc14af4038bec5 Gerrit-Change-Number: 86279 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025