coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[S] Change in coreboot[main]: soc/intel/cmn/blk: Remove boot partition check for forced cse sync
by Dinesh Gehlot (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Intel coreboot Reviewers, Martin L Roth. Hello Intel coreboot Reviewers, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86153?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: soc/intel/cmn/blk: Remove boot partition check for forced cse sync ............................… [View More]

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v4.0
by Kenji Yu (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Jarried Lin. Kenji Yu has posted comments on this change by Kenji Yu. ( https://review.coreboot.org/c/blobs/+/86293?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v4.0 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/blobs/+/86293?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/… [View More]

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v3.0
by Kenji Yu (Code Review) 07 Feb '25

07 Feb '25

Kenji Yu has posted comments on this change by Kenji Yu. ( https://review.coreboot.org/c/blobs/+/86251?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v3.0 ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://review.coreboot.org/c/blobs/+/86251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-… [View More]

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Display low battery message on screen
by Subrata Banik (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86224?usp=email ) Change subject: soc/intel/alderlake: Display low battery message on screen ...................................................................... Patch Set 7: (1 comment) Commit Message: https://… [View More]

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/francka: Decrease trace length of USB-A phy to s...
by Ian Feng (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Amanda Hwang, Jayvik Desai, Kapil Porwal, Paul Menzel, Pranava Y N. Ian Feng has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/86285?usp=email ) Change subject: mb/google/fatcat/var/francka: Decrease trace length of USB-A phy to short ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86285?usp=email … [View More]

1 0

[XS] Change in coreboot[main]: mainboard/google/fatcat: Set TCC offset
by Jamie Ryu (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Jayvik Desai, Kapil Porwal, Pranava Y N, Subrata Banik. Jamie Ryu has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86292?usp=email ) Change subject: mainboard/google/fatcat: Set TCC offset ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86292?usp=email To unsubscribe, or for help writing mail … [View More]

1 0

[M] Change in coreboot[main]: lib: Refactor ux_locales_get_text API
by Subrata Banik (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Julius Werner, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Tarun. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86283?usp=email ) Change subject: lib: Refactor ux_locales_get_text API ...................................................................... Patch Set 6: (1 comment) File src/include/… [View More]ux_locales.h: https://review.coreboot.org/c/coreboot/+/86283/comment/f9e7d83c_f5e7b894?us… : PS5, Line 23: const char *ux_locales_get_text(const char *name, const char *fallback_text); > > Why should we still keep this API around? I think we should switch everything to using IDs. > > Please take a look at https://github.com/coreboot/coreboot/blob/main/tests/lib/ux_locales-test.c#…, > related to unit-tests for ux-locales where certain expectation about default text won't meet as we are now limiting the msg_id and default test within the ux_locales.c itself. Meaning any outside caller of `ux_locales_get_text_by_id()` without passing valid msg_id other than what present inside ux_locales.h would ended up getting a text msg "Trying to display unknown message?". This is something that would make ux_locales unit test fail. > > ``` > enum ux_locale_msg { > UX_LOCALE_MSG_MEMORY_TRAINING, > UX_LOCALE_MSG_NUM, > }; > ``` > > therefore, the consumer of `ux_locales_get_text` is just unit-test whereelse `ux_locales_get_text_by_id` will be in use widely inside coreboot/src the only way we could drop `ux_locales_get_text` API if we also include all msg_ids listed in ux-locales.unit-tests into the ux_locales.c (which I don't think making any sense) -- To view, visit https://review.coreboot.org/c/coreboot/+/86283?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4952802396265b9ee8d164d6e43a7f2b3599d6c0 Gerrit-Change-Number: 86283 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Fri, 07 Feb 2025 06:47:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> [View Less]

1 0

[M] Change in coreboot[main]: lib: Refactor ux_locales_get_text API
by Subrata Banik (Code Review) 06 Feb '25

06 Feb '25

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Julius Werner, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Tarun. Hello Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Julius Werner, Kapil Porwal, Nick Vaccaro, Tarun, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86283?usp=email to look at the … [View More]new patch set (#6). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: lib: Refactor ux_locales_get_text API ...................................................................... lib: Refactor ux_locales_get_text API This patch refactors the `ux_locales_get_text` API to handle fallback text (English) internally, rather than relying on the caller. It introduces message IDs for lookups, enabling the API to locate both the UX locale name and fallback text based on the ID. - ux_locales_get_text: Get UX locales message based on locales name. - ux_locales_get_text_by_id: Get UX locales message based on msg ID. `ux_locales_get_text_by_id` retrieves fallback text message depending upon the message ID if UX locales not available. `ux_locales_get_text` API now takes an additional argument as `fallback_text` if provided, otherwise return `NULL`. This centralizes fallback handling and simplifies adding future messages without per-SoC duplication. BUG=b:339673254 TEST=Built and booted google/brox. Verified eSOL display. Change-Id: I4952802396265b9ee8d164d6e43a7f2b3599d6c0 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/include/ux_locales.h M src/lib/ux_locales.c M src/soc/intel/alderlake/romstage/ux.c M src/soc/intel/meteorlake/romstage/fsp_params.c M tests/lib/ux_locales-test.c 5 files changed, 53 insertions(+), 31 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/86283/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/86283?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4952802396265b9ee8d164d6e43a7f2b3599d6c0 Gerrit-Change-Number: 86283 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> [View Less]

1 0

[M] Change in coreboot[main]: lib: Refactor ux_locales_get_text API
by Subrata Banik (Code Review) 06 Feb '25

06 Feb '25

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Julius Werner, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Tarun. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86283?usp=email ) Change subject: lib: Refactor ux_locales_get_text API ...................................................................... Patch Set 5: (4 comments) File src/… [View More]include/ux_locales.h: https://review.coreboot.org/c/coreboot/+/86283/comment/7e1f13fd_cca3ca26?us… : PS5, Line 23: const char *ux_locales_get_text(const char *name, const char *fallback_text); > Why should we still keep this API around? I think we should switch everything to using IDs. Please take a look at https://github.com/coreboot/coreboot/blob/main/tests/lib/ux_locales-test.c#…, related to unit-tests for ux-locales where certain expectation about default text won't meet as we are now limiting the msg_id and default test within the ux_locales.c itself. Meaning any outside caller of `ux_locales_get_text_by_id()` without passing valid msg_id other than what present inside ux_locales.h would ended up getting a text msg "Trying to display unknown message?". This is something that would make ux_locales unit test fail. ``` enum ux_locale_msg { UX_LOCALE_MSG_MEMORY_TRAINING, UX_LOCALE_MSG_NUM, }; ``` therefore, the consumer of `ux_locales_get_text` is just unit-test whereelse `ux_locales_get_text_by_id` will be in use widely inside coreboot/src File src/lib/ux_locales.c: https://review.coreboot.org/c/coreboot/+/86283/comment/fddf4901_44688c44?us… : PS5, Line 28: "Please do not turn off your device." > +1 Acknowledged https://review.coreboot.org/c/coreboot/+/86283/comment/8cac1e3b_daffa344?us… : PS5, Line 32: enum ux_locale_msg locale_msg_id; > +1 Acknowledged https://review.coreboot.org/c/coreboot/+/86283/comment/aa8a6c72_cc484df9?us… : PS5, Line 213: switch (msg_id) { > +1 […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/86283?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4952802396265b9ee8d164d6e43a7f2b3599d6c0 Gerrit-Change-Number: 86283 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Fri, 07 Feb 2025 05:54:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> [View Less]

1 0

[XS] Change in coreboot[main]: mainboard/google/fatcat: Set TCC offset
by Dinesh Gehlot (Code Review) 06 Feb '25

06 Feb '25

Attention is currently required from: Jamie Ryu, Jayvik Desai, Kapil Porwal, Pranava Y N, Subrata Banik. Dinesh Gehlot has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86292?usp=email ) Change subject: mainboard/google/fatcat: Set TCC offset ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86292?usp=email To unsubscribe, or for help … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025