coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[XS] Change in coreboot[main]: soc/mediatek/common: Measure mtk_fsp_load_and_run() execution time
by Yidi Lin (Code Review) 07 Feb '25

07 Feb '25

Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86325?usp=email ) Change subject: soc/mediatek/common: Measure mtk_fsp_load_and_run() execution time ...................................................................... soc/mediatek/common: Measure mtk_fsp_load_and_run() execution time Measure mtk_fsp_load_and_run() execution time. This info helps AP boot time analysis. The logs show as below. [INFO ] mtk_fsp_load_and_run: run fallback/mtk_fsp_romstage at phase 0x30 in 0 msecs [INFO ] mtk_fsp_load_and_run: run fallback/mtk_fsp_ramstage at phase 0x50 in 41 msecs BUG=none BRANCH=rauru TEST=cbmem -1|grep "mtk_fsp_load_and_run" Change-Id: I61706952bef4590c5bfd09707a08a4f1a25fbda2 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/common/mtk_fsp.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/86325/1 diff --git a/src/soc/mediatek/common/mtk_fsp.c b/src/soc/mediatek/common/mtk_fsp.c index bc1b5d5..073a079 100644 --- a/src/soc/mediatek/common/mtk_fsp.c +++ b/src/soc/mediatek/common/mtk_fsp.c @@ -3,6 +3,7 @@ #include <cbfs.h> #include <console/console.h> #include <soc/mtk_fsp.h> +#include <timer.h> #define MAX_PARAM_ENTRIES 32 #define FSP_INTF_SIZE (sizeof(struct mtk_fsp_intf) + \ @@ -82,7 +83,9 @@ enum cb_err mtk_fsp_load_and_run(void) { struct prog fsp = PROG_INIT(PROG_REFCODE, mtk_fsp_file()); + struct stopwatch sw; + stopwatch_init(&sw); if (cbfs_prog_stage_load(&fsp)) { printk(BIOS_ERR, "%s: CBFS load program failed\n", __func__); return CB_ERR; @@ -101,8 +104,8 @@ return CB_ERR; } - printk(BIOS_INFO, "%s: run %s at phase %#x done\n", - __func__, mtk_fsp_file(), intf->phase); + printk(BIOS_INFO, "%s: run %s at phase %#x in %lld msecs\n", + __func__, mtk_fsp_file(), intf->phase, stopwatch_duration_msecs(&sw)); return CB_SUCCESS; } -- To view, visit https://review.coreboot.org/c/coreboot/+/86325?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I61706952bef4590c5bfd09707a08a4f1a25fbda2 Gerrit-Change-Number: 86325 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/pujjoniru: Update I2C_5 parameters
by hualin wei (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Weimin Wu. hualin wei has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/86324?usp=email ) Change subject: mb/google/nissa/var/pujjoniru: Update I2C_5 parameters ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/86324/comment/ef90cf61_1843ef4d?us… : PS3, Line 7: Tune I2C touchpad for freq and Thd > Update I2C_5 parameters Done -- To view, visit https://review.coreboot.org/c/coreboot/+/86324?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3c8c8d3b78236247ca7be810ac152085f615a6ef Gerrit-Change-Number: 86324 Gerrit-PatchSet: 5 Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cindy Lu <luyi8(a)huaqin.corp-partner.google.com> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Sat, 08 Feb 2025 03:00:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/pujjoniru: Update I2C_5 parameters
by hualin wei (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Weimin Wu, hualin wei. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Subrata Banik, Weimin Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86324?usp=email to look at the new patch set (#5). Change subject: mb/google/nissa/var/pujjoniru: Update I2C_5 parameters ...................................................................... mb/google/nissa/var/pujjoniru: Update I2C_5 parameters 1. Modify the I2C frequency of the touchpad between 380 Khz and 400 Khz to meet the spec. 2. Modify the Thd dat of DATA between 0.3 us and 0.9 us to meet the spec. Before: I2C5 - 407KHz Thd - 0.06us After: I2C5 - 387Khz Thd - 0.34us BUG=b:391796230,b:391788680 TEST=Check that the wave form meets the spec. Change-Id: I3c8c8d3b78236247ca7be810ac152085f615a6ef Signed-off-by: Hualin Wei <weihualin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/pujjoniru/overridetree.cb 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/86324/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/86324?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3c8c8d3b78236247ca7be810ac152085f615a6ef Gerrit-Change-Number: 86324 Gerrit-PatchSet: 5 Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cindy Lu <luyi8(a)huaqin.corp-partner.google.com> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/pujjoniru: Tune I2C_5 parameters for freq and Thd
by hualin wei (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Weimin Wu, hualin wei. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Subrata Banik, Weimin Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86324?usp=email to look at the new patch set (#4). Change subject: mb/google/nissa/var/pujjoniru: Tune I2C_5 parameters for freq and Thd ...................................................................... mb/google/nissa/var/pujjoniru: Tune I2C_5 parameters for freq and Thd 1. Modify the I2C frequency of the touchpad between 380 Khz and 400 Khz to meet the spec. 2. Modify the Thd dat of DATA between 0.3 us and 0.9 us to meet the spec. Before: I2C5 - 407KHz Thd - 0.06us After: I2C5 - 387Khz Thd - 0.34us BUG=b:391796230,b:391788680 TEST=Check that the wave form meets the spec. Change-Id: I3c8c8d3b78236247ca7be810ac152085f615a6ef Signed-off-by: Hualin Wei <weihualin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/pujjoniru/overridetree.cb 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/86324/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/86324?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3c8c8d3b78236247ca7be810ac152085f615a6ef Gerrit-Change-Number: 86324 Gerrit-PatchSet: 4 Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cindy Lu <luyi8(a)huaqin.corp-partner.google.com> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/pujjoniru: Tune I2C touchpad for freq and Thd
by Eric Lai (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Weimin Wu, hualin wei. Eric Lai has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/86324?usp=email ) Change subject: mb/google/nissa/var/pujjoniru: Tune I2C touchpad for freq and Thd ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/86324/comment/e70b598f_5873030f?us… : PS3, Line 7: Tune I2C touchpad for freq and Thd Update I2C_5 parameters -- To view, visit https://review.coreboot.org/c/coreboot/+/86324?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3c8c8d3b78236247ca7be810ac152085f615a6ef Gerrit-Change-Number: 86324 Gerrit-PatchSet: 3 Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cindy Lu <luyi8(a)huaqin.corp-partner.google.com> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Sat, 08 Feb 2025 02:53:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/google/nissa/var/dirks: Add initial override devicetree
by Eric Lai (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Dinesh Gehlot, Ivy Jian, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Eric Lai has posted comments on this change by Ivy Jian. ( https://review.coreboot.org/c/coreboot/+/86250?usp=email ) Change subject: mb/google/nissa/var/dirks: Add initial override devicetree ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86250?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic0b80e3121d94ede771ecc30cf0c66a67b9a41d0 Gerrit-Change-Number: 86250 Gerrit-PatchSet: 2 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Sat, 08 Feb 2025 02:51:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/pujjoniru: Tune I2C touchpad for freq and Thd
by Qinghong Zeng (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Weimin Wu, hualin wei. Qinghong Zeng has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/86324?usp=email ) Change subject: mb/google/nissa/var/pujjoniru: Tune I2C touchpad for freq and Thd ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/86324?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3c8c8d3b78236247ca7be810ac152085f615a6ef Gerrit-Change-Number: 86324 Gerrit-PatchSet: 3 Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-CC: Cindy Lu <luyi8(a)huaqin.corp-partner.google.com> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Sat, 08 Feb 2025 02:49:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/pujjoniru: Tune I2C touchpad for freq and Thd
by hualin wei (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Subrata Banik, Weimin Wu. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Subrata Banik, Weimin Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86324?usp=email to look at the new patch set (#3). Change subject: mb/google/nissa/var/pujjoniru: Tune I2C touchpad for freq and Thd ...................................................................... mb/google/nissa/var/pujjoniru: Tune I2C touchpad for freq and Thd 1. Modify the I2C frequency of the touchpad between 380 Khz and 400 Khz to meet the spec. 2. Modify the Thd dat of DATA between 0.3 us and 0.9 us to meet the spec. Before: I2C5 - 407KHz Thd - 0.06us After: I2C5 - 387Khz Thd - 0.34us BUG=b:391796230,b:391788680 TEST=Check that the wave form meets the spec. Change-Id: I3c8c8d3b78236247ca7be810ac152085f615a6ef Signed-off-by: Hualin Wei <weihualin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/pujjoniru/overridetree.cb 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/86324/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/86324?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3c8c8d3b78236247ca7be810ac152085f615a6ef Gerrit-Change-Number: 86324 Gerrit-PatchSet: 3 Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-CC: Cindy Lu <luyi8(a)huaqin.corp-partner.google.com> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: mb/google/brya/var/pujjoniru: Tune I2C touchpad for freq and Thd
by hualin wei (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Eric Lai, Qinghong Zeng, Subrata Banik, Weimin Wu. hualin wei has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/86324?usp=email ) Change subject: mb/google/brya/var/pujjoniru: Tune I2C touchpad for freq and Thd ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/86324?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3c8c8d3b78236247ca7be810ac152085f615a6ef Gerrit-Change-Number: 86324 Gerrit-PatchSet: 2 Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-CC: Cindy Lu <luyi8(a)huaqin.corp-partner.google.com> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Sat, 08 Feb 2025 02:41:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: lib: Refactor ux_locales_get_text API
by Julius Werner (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun. Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86283?usp=email ) Change subject: lib: Refactor ux_locales_get_text API ...................................................................... Patch Set 8: (1 comment) File src/include/ux_locales.h: https://review.coreboot.org/c/coreboot/+/86283/comment/3fdc6ae6_832f5ac5?us… : PS5, Line 23: const char *ux_locales_get_text(const char *name, const char *fallback_text); > > Well, then change the test, of course. […] I don't think we should keep tests for an API that we do not want to expose for anyone to call anymore. Also, removing the other function may make the implementation of the `by_id()` function simpler (because then it will just be integrated into the main function and not be a separate thing), and it will also mean we would probably just call it `ux_locales_get_text()`, without the `_by_id`, because then that's the only option. In general, the development flow should always start with deciding how you want the code to work at the high level, then designing the APIs that connect the different pieces, then implementing each of those individual parts, and then writing/adjusting unit tests for them. You should never turn that process around and e.g. have your decision of how to design an API influenced by how existing unit tests are written. The unit tests are there to support the code, not the other way round. -- To view, visit https://review.coreboot.org/c/coreboot/+/86283?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4952802396265b9ee8d164d6e43a7f2b3599d6c0 Gerrit-Change-Number: 86283 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sat, 08 Feb 2025 02:31:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025