Attention is currently required from: Angel Pons, Jérémy Compostella, Matt DeVillier.
Hello Angel Pons, Jérémy Compostella, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86093?usp=email
to look at the new patch set (#5).
Change subject: mb/erying/tgl: Drop specifying which timers to use
......................................................................
mb/erying/tgl: Drop specifying which timers to use
With 8254 …
[View More]timer enabled, system would hang while entering s0ix state.
If we build coreboot with both timers =N, system enters s0ix state (although it doesn't cut the power to the platform) and can be woken up by pressing the key on the keyboard.
Since there's less potential for data loss in case of accidental suspend, I think it makes sense to do it this way.
Change-Id: If6e0ac1d289447c292a49111251d321c951078e2
Signed-off-by: Alicja Michalska <alicja.michalska(a)9elements.com>
---
M src/mainboard/erying/tgl/Kconfig
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/86093/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/86093?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If6e0ac1d289447c292a49111251d321c951078e2
Gerrit-Change-Number: 86093
Gerrit-PatchSet: 5
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
[View Less]
Attention is currently required from: Angel Pons, Arthur Heymans, David Hendricks, Felix Held.
Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/86131?usp=email )
Change subject: device/Kconfig: Make option to allocate above 4G appear in Kconfig
......................................................................
Patch Set 5:
(2 comments)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/86131/comment/…
[View More]5789ea81_b994cf60?us… :
PS4, Line 1015: default y
> Looks like the latest patchset changes the default for non-x86 to n. […]
Gotcha, reverted :)
https://review.coreboot.org/c/coreboot/+/86131/comment/76e8ea9c_eb0dd971?us… :
PS4, Line 1013: bool "Extend resource window for PCIe devices"
> i;d change the prompt text to be more descriptive of what it does; at least to me the name of the op […]
How about this one?
--
To view, visit https://review.coreboot.org/c/coreboot/+/86131?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia17b3312016409d8fd6bcce4321481a7b7e35ce5
Gerrit-Change-Number: 86131
Gerrit-PatchSet: 5
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 07 Feb 2025 23:48:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alicja Michalska <ahplka19(a)gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
[View Less]
Attention is currently required from: Angel Pons, Jérémy Compostella, Matt DeVillier.
Hello Angel Pons, Jérémy Compostella, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86093?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons, Verified+1 by build bot (Jenkins)
Change subject: mb/erying/tgl: Drop specifying which timers to use
.................…
[View More].....................................................
mb/erying/tgl: Drop specifying which timers to use
Change-Id: If6e0ac1d289447c292a49111251d321c951078e2
Signed-off-by: Alicja Michalska <alicja.michalska(a)9elements.com>
---
M src/mainboard/erying/tgl/Kconfig
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/86093/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/86093?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If6e0ac1d289447c292a49111251d321c951078e2
Gerrit-Change-Number: 86093
Gerrit-PatchSet: 4
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
[View Less]
Attention is currently required from: Alicja Michalska, Arthur Heymans, David Hendricks, Felix Held.
Hello Angel Pons, Arthur Heymans, David Hendricks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86131?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+2 by David Hendricks, Verified+1 by build bot (Jenkins)
Change subject: device/Kconfig: Make option to …
[View More]allocate above 4G appear in Kconfig
......................................................................
device/Kconfig: Make option to allocate above 4G appear in Kconfig
Previously only tested on server platforms - it wasn't working correctly
on consumer platforms due to missing boolean.
This patch fixes it, which makes resource allocator use uint64 instead
of uint32. Thanks to that, modern GPUs like Intel Arc or Radeon RX now
work correctly with ReBAR enabled, and correctly initialize the
framebuffer in payload (i.e EDK2) after initializing the OpROMs.
Example of issue caused by resource allocator using uint32 (Intel Arc
A580):
[ERROR] Resource didn't fit!!!
[ERROR] PCI: 00:01:00.0 10 prefmem64 size: 0x0000800000 not assigned
[ERROR] PCI: 00:03:00.0 18 prefmem64 size: 0x0200000000 not assigned
(Followed by Linux reporting that BAR space was limited to 256MB, which
severely hindered the performance).
TESTed on Intel TigerLake-H (mb/erying/tgl) with Intel Arc A580 and AMD
Radeon RX7800XT.
Change-Id: Ia17b3312016409d8fd6bcce4321481a7b7e35ce5
Signed-off-by: Alicja Michalska <alicja.michalska(a)9elements.com>
---
M src/device/Kconfig
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/86131/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/86131?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia17b3312016409d8fd6bcce4321481a7b7e35ce5
Gerrit-Change-Number: 86131
Gerrit-PatchSet: 5
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
[View Less]
Attention is currently required from: Sean Rhodes.
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86322?usp=email )
Change subject: ec/starlabs/merlin: Only include lid switch ACPI when needed
......................................................................
ec/starlabs/merlin: Only include lid switch ACPI when needed
Desktop devices don't need and shouldn't define a lid switch.
TEST=build/boot starlabs/byte,starlite_adl
Change-Id: …
[View More]Iecf3e2558e244cc0bec301a505c0bc86684954aa
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/ec/starlabs/merlin/acpi/ec.asl
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/86322/1
diff --git a/src/ec/starlabs/merlin/acpi/ec.asl b/src/ec/starlabs/merlin/acpi/ec.asl
index 5a8219c..db02f40 100644
--- a/src/ec/starlabs/merlin/acpi/ec.asl
+++ b/src/ec/starlabs/merlin/acpi/ec.asl
@@ -136,8 +136,8 @@
#include "ac.asl"
#if CONFIG(SYSTEM_TYPE_LAPTOP) || CONFIG(SYSTEM_TYPE_DETACHABLE)
#include "battery.asl"
-#endif
#include "lid.asl"
+#endif
#if CONFIG(SYSTEM_TYPE_DETACHABLE)
#include "dock.asl"
#endif
--
To view, visit https://review.coreboot.org/c/coreboot/+/86322?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iecf3e2558e244cc0bec301a505c0bc86684954aa
Gerrit-Change-Number: 86322
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
[View Less]
Attention is currently required from: Sean Rhodes.
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86321?usp=email )
Change subject: ec/starlabs/merlin: Drop unused reference to events.asl
......................................................................
ec/starlabs/merlin: Drop unused reference to events.asl
The events.asl file was removed in commit 43ac56bf434f
("ec/starlabs/merlin: Move common variants to respective files") and
the …
[View More]reference to it should have been dropped as well instead of guarded.
TEST=build various starlabs boards.
Change-Id: Ifbb986378dd49c6a1d316a4922c46c46180497ee
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/ec/starlabs/merlin/acpi/ec.asl
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/86321/1
diff --git a/src/ec/starlabs/merlin/acpi/ec.asl b/src/ec/starlabs/merlin/acpi/ec.asl
index 22a3a4b..5a8219c 100644
--- a/src/ec/starlabs/merlin/acpi/ec.asl
+++ b/src/ec/starlabs/merlin/acpi/ec.asl
@@ -137,9 +137,6 @@
#if CONFIG(SYSTEM_TYPE_LAPTOP) || CONFIG(SYSTEM_TYPE_DETACHABLE)
#include "battery.asl"
#endif
-#if !CONFIG(EC_STARLABS_MERLIN)
- #include "events.asl"
-#endif
#include "lid.asl"
#if CONFIG(SYSTEM_TYPE_DETACHABLE)
#include "dock.asl"
--
To view, visit https://review.coreboot.org/c/coreboot/+/86321?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifbb986378dd49c6a1d316a4922c46c46180497ee
Gerrit-Change-Number: 86321
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
[View Less]