coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[XS] Change in coreboot[main]: mb/erying/tgl: Drop specifying which timers to use
by Alicja Michalska (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Angel Pons, Jérémy Compostella, Matt DeVillier. Hello Angel Pons, Jérémy Compostella, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86093?usp=email to look at the new patch set (#5). Change subject: mb/erying/tgl: Drop specifying which timers to use ...................................................................... mb/erying/tgl: Drop specifying which timers to use With 8254 … [View More]

1 0

[XS] Change in coreboot[main]: device/Kconfig: Make option to allocate above 4G appear in Kconfig
by Alicja Michalska (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Angel Pons, Arthur Heymans, David Hendricks, Felix Held. Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/86131?usp=email ) Change subject: device/Kconfig: Make option to allocate above 4G appear in Kconfig ...................................................................... Patch Set 5: (2 comments) File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/86131/comment/… [View More]

1 0

[XS] Change in coreboot[main]: mb/erying/tgl: Drop specifying which timers to use
by Alicja Michalska (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Angel Pons, Jérémy Compostella, Matt DeVillier. Hello Angel Pons, Jérémy Compostella, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86093?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by Angel Pons, Verified+1 by build bot (Jenkins) Change subject: mb/erying/tgl: Drop specifying which timers to use .................… [View More]

1 0

[XS] Change in coreboot[main]: device/Kconfig: Make option to allocate above 4G appear in Kconfig
by Alicja Michalska (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Alicja Michalska, Arthur Heymans, David Hendricks, Felix Held. Hello Angel Pons, Arthur Heymans, David Hendricks, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86131?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+2 by David Hendricks, Verified+1 by build bot (Jenkins) Change subject: device/Kconfig: Make option to … [View More]allocate above 4G appear in Kconfig ...................................................................... device/Kconfig: Make option to allocate above 4G appear in Kconfig Previously only tested on server platforms - it wasn't working correctly on consumer platforms due to missing boolean. This patch fixes it, which makes resource allocator use uint64 instead of uint32. Thanks to that, modern GPUs like Intel Arc or Radeon RX now work correctly with ReBAR enabled, and correctly initialize the framebuffer in payload (i.e EDK2) after initializing the OpROMs. Example of issue caused by resource allocator using uint32 (Intel Arc A580): [ERROR] Resource didn't fit!!! [ERROR] PCI: 00:01:00.0 10 prefmem64 size: 0x0000800000 not assigned [ERROR] PCI: 00:03:00.0 18 prefmem64 size: 0x0200000000 not assigned (Followed by Linux reporting that BAR space was limited to 256MB, which severely hindered the performance). TESTed on Intel TigerLake-H (mb/erying/tgl) with Intel Arc A580 and AMD Radeon RX7800XT. Change-Id: Ia17b3312016409d8fd6bcce4321481a7b7e35ce5 Signed-off-by: Alicja Michalska <alicja.michalska(a)9elements.com> --- M src/device/Kconfig 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/86131/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/86131?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia17b3312016409d8fd6bcce4321481a7b7e35ce5 Gerrit-Change-Number: 86131 Gerrit-PatchSet: 5 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> [View Less]

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Display low battery message on screen
by Dinesh Gehlot (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Julius Werner, Kapil Porwal, Nick Vaccaro, Subrata Banik. Dinesh Gehlot has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86224?usp=email ) Change subject: soc/intel/alderlake: Display low battery message on screen ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/… [View More]

1 0

[XS] Change in coreboot[main]: lib: Add low battery UX locale message
by Dinesh Gehlot (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Subrata Banik. Dinesh Gehlot has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86284?usp=email ) Change subject: lib: Add low battery UX locale message ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86284?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.… [View More]

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Add low battery indicator screen
by Karthik Ramasubramanian (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Andrey Petrov, Intel coreboot Reviewers, Julius Werner, Jérémy Compostella, Ronak Kanabar, Subrata Banik. Karthik Ramasubramanian has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86225?usp=email ) Change subject: drivers/intel/fsp2_0: Add low battery indicator screen ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.… [View More]

1 0

[S] Change in coreboot[main]: soc/intel/alderlake: Use helper for UX messages
by Dinesh Gehlot (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Dinesh Gehlot has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86278?usp=email ) Change subject: soc/intel/alderlake: Use helper for UX messages ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86278?usp=email To … [View More]

1 0

[XS] Change in coreboot[main]: ec/starlabs/merlin: Only include lid switch ACPI when needed
by Matt DeVillier (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86322?usp=email ) Change subject: ec/starlabs/merlin: Only include lid switch ACPI when needed ...................................................................... ec/starlabs/merlin: Only include lid switch ACPI when needed Desktop devices don't need and shouldn't define a lid switch. TEST=build/boot starlabs/byte,starlite_adl Change-Id: … [View More]

1 0

[XS] Change in coreboot[main]: ec/starlabs/merlin: Drop unused reference to events.asl
by Matt DeVillier (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86321?usp=email ) Change subject: ec/starlabs/merlin: Drop unused reference to events.asl ...................................................................... ec/starlabs/merlin: Drop unused reference to events.asl The events.asl file was removed in commit 43ac56bf434f ("ec/starlabs/merlin: Move common variants to respective files") and the … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025